From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by sourceware.org (Postfix) with ESMTPS id 13ECB3858C2C for ; Mon, 8 Nov 2021 14:19:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 13ECB3858C2C Received: by mail-pj1-x1031.google.com with SMTP id j5-20020a17090a318500b001a6c749e697so6635982pjb.1 for ; Mon, 08 Nov 2021 06:19:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=pOsEOf2mf+gaMpHeL/DbAzhmPJ884AWqzavNjlkD7Gs=; b=Q1ImoCI4dlJVWY5ZR26IEBmGRCu72TXMpC7QRV4AfQc3wLb7Bx+QmOMvdgM+pi6TpQ fAHcGRErairEH46ypesXonFp4tYIPmRRUT7aaxfLr7Sip6xa8Z/HVITfdc/XHjcvVWP+ L119sud9lvxrJ7lkKVRZylBTVZ6XPpWl9ekcwFRiesy2lTfZ1oyzPamtDlnfDowjKXbF mxP9jr7W16C/e7mBgxnvsp/vZ7UULY+h5wxNI123VNundaZ/61Rk17+DZAdwIF5ed82a oaMq/RG4zgBvjmsPpQqgxvl03UzcEFXKAjWgq+ReMZBmPyaqo+kXkQH2QKtFRMuDyN61 rbrQ== X-Gm-Message-State: AOAM531jpTnldDC7zo24Xe8NguxSRrg0lbUAaQfBHV9CCit/lNftNyzv FflsN3/xMJDCCx4NSM3U8iY= X-Google-Smtp-Source: ABdhPJz3y24/tnRrPJkjtB7VtECNRUz9P43lOhwh6Ht/a2pa3T9M3EDCUbDyBa5CdhWMP8H/epngdA== X-Received: by 2002:a17:90b:4c8c:: with SMTP id my12mr51032904pjb.157.1636381173003; Mon, 08 Nov 2021 06:19:33 -0800 (PST) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id t80sm9270905pgb.26.2021.11.08.06.19.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Nov 2021 06:19:32 -0800 (PST) Message-ID: Date: Mon, 8 Nov 2021 08:19:31 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCH] Remove dead code. Content-Language: en-US To: Jakub Jelinek , =?UTF-8?Q?Martin_Li=c5=a1ka?= , hjl.tools@gmail.com Cc: Tobias Burnus , gcc-patches@gcc.gnu.org References: <499b9ae2-1365-a954-ed5e-35aede5d0def@suse.cz> <20211108085918.GH2710@tucnak> From: Jeff Law In-Reply-To: <20211108085918.GH2710@tucnak> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Nov 2021 14:19:35 -0000 On 11/8/2021 2:59 AM, Jakub Jelinek via Gcc-patches wrote: > On Mon, Nov 08, 2021 at 09:45:39AM +0100, Martin Liška wrote: >> This fixes issue reported in the PR. >> >> Ready to be installed? > I'm not sure. liboffloadmic is copied from upstream, so the right > thing if we want to do anything at all (if we don't remove it, nothing > bad happens, the condition is never true anyway, whether removed away > in the source or removed by the compiler) would be to let Intel fix it in > their source and update from that. > But I have no idea where it even lives upstream. I thought MIC as an architecture was dead, so it could well be the case that there isn't a viable upstream anymore for that code. jeff