From: Thomas Koenig <tkoenig@netcologne.de>
To: Tobias Burnus <tobias@codesourcery.com>,
gcc-patches <gcc-patches@gcc.gnu.org>,
fortran <fortran@gcc.gnu.org>
Subject: Re: [Patch] Fortran: Delay vtab generation until after parsing [PR92587]
Date: Thu, 17 Dec 2020 10:02:19 +0100 [thread overview]
Message-ID: <fccd3ea9-9106-c6d0-1350-78b0f00909b5@netcologne.de> (raw)
In-Reply-To: <6b20a856-d983-5e37-47d2-6749a1a6cfcf@codesourcery.com>
Hi Tobias,
> Calling gfc_find_vtab during resolution during parsing
> comes too early for finalizers. This patch just moves it
> to the resolution, which seems to be the simplest solution.
Ah, finalizers - one area where we still are deficient WRT Fortran 2003.
Thanks for doing things in this area!
> (I tried way more complicated ones which do not work; thus,
> I settled for the simple solution ...)
Certainly sounds like a good idea to do so.
> OK for GCC 9/10/mainline?
OK. Just one remark: Could you make the test into a run-time test
to check that the finalizers are called correctly?
Best regards
Thomas
next prev parent reply other threads:[~2020-12-17 9:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 22:23 Tobias Burnus
2020-12-17 9:02 ` Thomas Koenig [this message]
2020-12-17 9:41 ` Tobias Burnus
2020-12-17 10:58 ` Thomas Koenig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fccd3ea9-9106-c6d0-1350-78b0f00909b5@netcologne.de \
--to=tkoenig@netcologne.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).