From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by sourceware.org (Postfix) with ESMTPS id 722E3383237C for ; Mon, 14 Nov 2022 17:53:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 722E3383237C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1033.google.com with SMTP id q1-20020a17090a750100b002139ec1e999so11426952pjk.1 for ; Mon, 14 Nov 2022 09:53:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IAEp/y52rW7+idPytweAF9x07lJFmUHKJxno0IcyDs8=; b=P/1asPR8KRnGzyx2vDzxWhXkPZ/ooda5F2h8gzbCuejEwBIowVb+ShmI9LtGk+kEDD unWt03wQMSJG4x/KGSWeFpxvtiyyIb80I5PqZOBeeJGoSw5BL+HNn37khRGyapTF3cRE 7kIkwvP9mkDJcw+0/hYhfIYdhaQ1Ul5j+FN8IIx7Q+vRpak0aV1Z38NC+M1E8bgu8x2J 53JDWdls+HraChjbV77IKFjGeBUDfCBVVcQ1LdnVekH7VYp54B3H3aSvRRmkz6SoSyF6 WPsJ4bOi8ILf/uSWRyaLDNcOWblEQ4U3goEdjHiNLUfEFuQGt5eLNydvqNynxIVE7tWB h1YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IAEp/y52rW7+idPytweAF9x07lJFmUHKJxno0IcyDs8=; b=oQidTOXj0ABZ+hHoDp/0DzqHR2BCDMVxNCXUHbwedV0o5cWrxvwqhl7grismac2n6V z/b5rUJ3fQKF8o7Wc/jCNlMjHt5U3IyH8zqjs3zppux+gqUJsoCUzY//OgPQCNAU5IC1 GQffS+jhxVamad4CMxFZ6fR4YEc12AlSERbP5AzxTuEs55p71V+kTNBm7nmLe+7407KA yghupF6wQ/gbkGQGk9jCdOMBkS/OO4KCMwIbI87VvlFc7EJmPHyiNKfdhXx7QTG8U7fk 6Ozy/jQMu+RZWhCghNbBl7loYH2ZZOUAgOhRnBoCozinO28WZqFjXjW0Tp3M/lgPpeqc Kivw== X-Gm-Message-State: ANoB5pkFcKQi/dUaraSKdP/XLV/yZaeUmkRAVuUhe1QtZWkC3PIZCaZf WikY3nWGO/SZNDI0JTo0TOs= X-Google-Smtp-Source: AA0mqf6reJq6bPF2TV/+0W1fVdKjMOAXYB/0M6x9Vswt8MlSsHOD4PXtu1iWSzCgoFMRk/7mVI3eTw== X-Received: by 2002:a17:90b:4f41:b0:212:cd99:915c with SMTP id pj1-20020a17090b4f4100b00212cd99915cmr14610735pjb.38.1668448403540; Mon, 14 Nov 2022 09:53:23 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id p6-20020a1709026b8600b0016c5306917fsm7747176plk.53.2022.11.14.09.53.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Nov 2022 09:53:22 -0800 (PST) Message-ID: Date: Mon, 14 Nov 2022 10:53:21 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 1/7] riscv: bitmanip: add orc.b as an unspec Content-Language: en-US From: Jeff Law To: Christoph Muellner , gcc-patches@gcc.gnu.org, Kito Cheng , Jim Wilson , Palmer Dabbelt , Andrew Waterman , Philipp Tomsich , Vineet Gupta References: <20221113230521.712693-1-christoph.muellner@vrull.eu> <20221113230521.712693-2-christoph.muellner@vrull.eu> <15ccec02-5467-81aa-89b7-d75a7aa778c2@gmail.com> In-Reply-To: <15ccec02-5467-81aa-89b7-d75a7aa778c2@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_MANYTO,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/14/22 09:51, Jeff Law wrote: > > On 11/13/22 16:05, Christoph Muellner wrote: >> From: Philipp Tomsich >> >> As a basis for optimized string functions (e.g., the by-pieces >> implementations), we need orc.b available.  This adds orc.b as an >> unspec, so we can expand to it. >> >> gcc/ChangeLog: >> >>          * config/riscv/bitmanip.md (orcb2): Add orc.b as an >>       unspec. >>          * config/riscv/riscv.md: Add UNSPEC_ORC_B. > In general, we should prefer to express things as "real" RTL rather > than UNSPECS.  In this particular case expressing the orc could be > done with a handful of IOR expressions, though they'd probably need to > reference byte SUBREGs of the input and I dislike explicit SUBREGs in > the md file even more than UNSPECs. Mis-read the specs on orc.  So ignore the comment about expressing this as a handful of IORs and about it being reduc_ior_scal. jeff