From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id B9F783858D37 for ; Thu, 20 Apr 2023 17:17:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B9F783858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x331.google.com with SMTP id o9-20020a05600c510900b003f17012276fso3403704wms.4 for ; Thu, 20 Apr 2023 10:17:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682011037; x=1684603037; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=x68dbs26somq4jPrLId/KBNbj4SOZoWuX7Nu2KlQoFk=; b=QXWSTGSC2/+4jgT0ZUHh343CH8VqulPb8/KgxjKlzXsYcXlkWo4J/BPTc9PI7yyLQn 3rixG8R2ioJKo6Bj99ngsxoH2EbThK76PzS7crht96EbLEiYSD19GW54BBelKvjj2Qnq CKNXpapOncKdiQg2Kz5zpgPKycRNuPK4x4Nd2JMbWormOVskHR8flRAos9Tp1r/rG/wM NfU3BLojrSnmd4OUqg8QayiklguBYOfgmr4AWmGTCbs0Rb0/WoEg2g/DVbpV/nakwrc0 vOiSvg60oC1uPsrHZDZSAZSzCSj0teRxXufCqx8d9RxVaqoJAnz4t6H7k0R//GTfSRpi 4gXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682011037; x=1684603037; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=x68dbs26somq4jPrLId/KBNbj4SOZoWuX7Nu2KlQoFk=; b=IgAF9j+7ZPZ2R+0FJ4XfMVo0AOYgMReP8HUDYz9/S/6pLMjh1d2zKAKwk/hLzALIRw jpsmHg3XUDmr5uqYnKLhNlHeZ8DXLjYYMpeJqv+Oy6tKekCriWxXK4Gf1gt5lcjrE9fh XWIJnQm0auSrfc5zvT3RbtYcCfagtFBr2TX5+FVfEV4ViBHfuqDlF28MytKGfaaRc5vA iVq7xPXYryahjjwJcH3M3TEem0Qvcl6jp1lrCeTYfpcEwDAKSJz8axkBRgT8fpBwYRW8 EQkX/6yZ9+bnfy7A5r1pEcvw/SSE1dPHPU8XCfZ3lWRAj16i/HQ6sEb5H3hYPx42e0ZH w0KA== X-Gm-Message-State: AAQBX9d8iTu6gCzGka0E/6NJ3nnxPTdHTHfxpLFPzQBzM7o5HfIJXv// XD2/sT1REzb2wXKhfdATb80= X-Google-Smtp-Source: AKy350ZZs7gEnHRcScc5kGLvqRxtdqSt65NmEhB/+5Zyd6KRx3yGWjXkb5X/hgdX8cM1x+2MFnpUeA== X-Received: by 2002:a1c:4b1a:0:b0:3f1:8167:dc30 with SMTP id y26-20020a1c4b1a000000b003f18167dc30mr1994544wma.2.1682011037384; Thu, 20 Apr 2023 10:17:17 -0700 (PDT) Received: from [192.168.0.160] ([170.253.51.134]) by smtp.gmail.com with ESMTPSA id o2-20020a05600c4fc200b003f1738e64c0sm5991752wmq.20.2023.04.20.10.17.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Apr 2023 10:17:16 -0700 (PDT) Message-ID: Date: Thu, 20 Apr 2023 19:17:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Ping: [PATCH v2] C, ObjC: Add -Wunterminated-string-initialization Content-Language: en-US To: David Malcolm , gcc-patches@gcc.gnu.org Cc: Alejandro Colomar , Doug McIlroy , "G. Branden Robinson" , Ralph Corderoy , Dave Kemper , Larry McVoy , Andrew Pinski , Jonathan Wakely , Andrew Clayton , Martin Uecker References: <20230324133928.14753-1-alx@kernel.org> <7d57dcfbc21caa2c6d9ac1118f4f6a34a8fb341c.camel@redhat.com> <4ba61ffe-2322-728f-871f-930216b6a128@gmail.com> <2061ea8e2d95d4904db84de34b7b25a0f426a4d9.camel@redhat.com> From: Alejandro Colomar In-Reply-To: <2061ea8e2d95d4904db84de34b7b25a0f426a4d9.camel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------4UOw42ndm0CsDQY2PAiGIei0" X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------4UOw42ndm0CsDQY2PAiGIei0 Content-Type: multipart/mixed; boundary="------------TIQgiCOGTcUBVmiCMRzTj0wr"; protected-headers="v1" From: Alejandro Colomar To: David Malcolm , gcc-patches@gcc.gnu.org Cc: Alejandro Colomar , Doug McIlroy , "G. Branden Robinson" , Ralph Corderoy , Dave Kemper , Larry McVoy , Andrew Pinski , Jonathan Wakely , Andrew Clayton , Martin Uecker Message-ID: Subject: Ping: [PATCH v2] C, ObjC: Add -Wunterminated-string-initialization References: <20230324133928.14753-1-alx@kernel.org> <7d57dcfbc21caa2c6d9ac1118f4f6a34a8fb341c.camel@redhat.com> <4ba61ffe-2322-728f-871f-930216b6a128@gmail.com> <2061ea8e2d95d4904db84de34b7b25a0f426a4d9.camel@redhat.com> In-Reply-To: <2061ea8e2d95d4904db84de34b7b25a0f426a4d9.camel@redhat.com> --------------TIQgiCOGTcUBVmiCMRzTj0wr Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi David, On 3/24/23 18:58, David Malcolm wrote: > On Fri, 2023-03-24 at 18:45 +0100, Alejandro Colomar wrote: >> Hi David, >> >> On 3/24/23 15:53, David Malcolm wrote: >>> On Fri, 2023-03-24 at 14:39 +0100, Alejandro Colomar via Gcc- >>> patches >>> wrote: >>>> Warn about the following: >>>> >>>> =C2=A0=C2=A0=C2=A0 char=C2=A0 s[3] =3D "foo"; >>>> >> [...] >> >>>> --- >>>> >>>> Hi, >>> >>> Hi Alex, thanks for the patch. >> >> :) >> >>> >>>> >>>> I sent v1 to the wrong list.=C2=A0 This time I've made sure to write= >>>> to >>>> gcc-patches@. >>> >>> Note that right now we're deep in bug-fixing/stabilization for GCC >>> 13 >>> (and trunk is still tracking that effort), so your patch might be >>> more >>> suitable for GCC 14. >> >> Sure, no problem.=C2=A0 Do you have a "next" branch where you pick pat= ches >> for after the release, or should I resend after the release?=C2=A0=C2=A0= >=20 > We don't; resending it after release is probably best. >=20 >> Is >> discussion of a patch reasonable now, or is it too much distracting >> from your stabilization efforts? >=20 > FWIW I'd prefer to postpone the discussion until after we branch for > the release. Sure. AFAIK it's fair game already to propose patches to GCC 14, right? Would you please have a look into this? Thanks! >=20 >> >>> >>>> >>>> v2 adds some draft of a test, as suggested by Martin.=C2=A0 However,= I >>>> don't >>>> know yet how to write those, so the test is just a draft.=C2=A0 But = I >>>> did >>>> test the feature, by compiling GCC and compiling some small >>>> program >>>> with >>>> it. >>> >>> Unfortunately the answer to the question "how do I run just one >>> testcase in GCC's testsuite" is rather non-trivial; FWIW I've >>> written >>> up some notes on working with the GCC testsuite here: >>> https://gcc-newbies-guide.readthedocs.io/en/latest/working-with-the-t= estsuite.html >> >> Hmm, I'll try following that; thanks!=C2=A0 Is there anything obvious = that >> I might have missed, at first glance? >=20 > The main thing is that there's a difference between compiling the test > case "by hand", versus doing it through the test harness - the latter > sets up the environment in a particular way, injects a particular set > of flags, etc etc. I forgot about this; I'll have a look into it when I find some time. Cheers, Alex >=20 > Dave >=20 --=20 GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5 --------------TIQgiCOGTcUBVmiCMRzTj0wr-- --------------4UOw42ndm0CsDQY2PAiGIei0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6jqH8KTroDDkXfJAnowa+77/2zIFAmRBc5UACgkQnowa+77/ 2zJeYg/+KTZuF0GN8xOodwKeiYI8xK0cRqa6BjjvS65BPzx+wohQauXz7ZFztrtn guye79LY1km9hoEmxhq4H9LmNGJK/pBR4Cm6Nb1ZNx9Ds+RbJScuaqjy8D8EuWRy A4Kk4U7fOG0TfS/6+DeFLIafFk40ydVxsktG+cbnc4uKlzyLCF7fw5egSNnEg8ff 8QA327q1WRPwMkvF8Gf73VLM7vq623ASYqEHfWKCp0XF+44uBjDd38NFsocNDiMY C/B6vhcJWxa1NSJWxhTqDU06+YVzA/ZgJ4QaYJqOqBNZ542SG5ipmtbY9vNnMEfN mWAu6NZMOGzpkGojKbOLckrHZXl/rWKyuW+6Ku7JgfGF2c8alQtgztz1Z9hewp89 3QyROut2wZTS3emmWHZsrwrBrqTLVjFcMZ46Ir0k8WeE6z6OecQyCWdntyrz1e3w 7iXQapIeNLwerLyWfiMLcw7eEyW90lejV0RzHgzRVz0En80bzisOv62t8HgtQsRL nCnwrSGJealMngipNbBhC5GQMoWnpsfczVxdVKGcU/04gNgI0ybbgJauhTcUrlld +Mw+h0Xx4R+Yc4FyRXyL0Ey1/G/5cpQu/acLF0Lyr1iwqX1GJjhOVVajSA/YRL9g Yt9ej9ZTXzMBOdfYH84QhrKYTLLYZ6ZxX3lWr+D2UnBcKz2VhNw= =3ACK -----END PGP SIGNATURE----- --------------4UOw42ndm0CsDQY2PAiGIei0--