From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id E007F3858D28 for ; Fri, 1 Jul 2022 14:57:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E007F3858D28 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CD6E5113E; Fri, 1 Jul 2022 07:57:27 -0700 (PDT) Received: from [10.2.78.56] (unknown [10.2.78.56]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D83C53F66F; Fri, 1 Jul 2022 07:57:26 -0700 (PDT) Message-ID: Date: Fri, 1 Jul 2022 15:57:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 8/12 V2] arm: Introduce multilibs for PACBTI target feature Content-Language: en-GB To: Andrea Corallo , Andrea Corallo via Gcc-patches Cc: Richard Earnshaw , nd References: <075cc158-d681-65b9-4d87-22c8800661fd@foss.arm.com> From: Richard Earnshaw In-Reply-To: <075cc158-d681-65b9-4d87-22c8800661fd@foss.arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3489.2 required=5.0 tests=BAYES_00, BODY_8BITS, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_SHORT, NICE_REPLY_A, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jul 2022 14:57:29 -0000 On 01/07/2022 15:54, Richard Earnshaw via Gcc-patches wrote: > > > On 01/06/2022 13:32, Andrea Corallo via Gcc-patches wrote: >> Hi all, >> >> second iteration of the previous patch adding the following new >> multilibs: >> >> thumb/v8.1-m.main+pacbti/mbranch-protection/nofp >> thumb/v8.1-m.main+pacbti+dp/mbranch-protection/soft >> thumb/v8.1-m.main+pacbti+dp/mbranch-protection/hard >> thumb/v8.1-m.main+pacbti+fp/mbranch-protection/soft >> thumb/v8.1-m.main+pacbti+fp/mbranch-protection/hard >> thumb/v8.1-m.main+pacbti+mve/mbranch-protection/hard >> >> To trigger the following compiler flags: >> >> -mthumb -march=armv8.1-m.main+pacbti -mbranch-protection=standard >> -mfloat-abi=soft >> -mthumb -march=armv8.1-m.main+pacbti+fp -mbranch-protection=standard >> -mfloat-abi=softfp >> -mthumb -march=armv8.1-m.main+pacbti+fp -mbranch-protection=standard >> -mfloat-abi=hard >> -mthumb -march=armv8.1-m.main+pacbti+fp.dp >> -mbranch-protection=standard -mfloat-abi=softfp >> -mthumb -march=armv8.1-m.main+pacbti+fp.dp >> -mbranch-protection=standard -mfloat-abi=hard >> -mthumb -march=armv8.1-m.main+pacbti+mve -mbranch-protection=standard >> -mfloat-abi=hard >> >> gcc/ChangeLog: >> >>     * config/arm/t-rmprofile: Add multilib rules for march +pacbti >>            and mbranch-protection. >> > > +# Map all mbranch-protection values other than 'none' to 'standard'. > +MULTILIB_MATCHES    += mbranch-protection?standard=mbranch-protection?bti > +MULTILIB_MATCHES    += > mbranch-protection?standard=mbranch-protection?pac-ret > +MULTILIB_MATCHES    += > mbranch-protection?standard=mbranch-protection?pac-ret+leaf > +MULTILIB_MATCHES    += > mbranch-protection?standard=mbranch-protection?pac-ret+bti > +MULTILIB_MATCHES    += > mbranch-protection?standard=mbranch-protection?pac-ret+leaf+bti > +MULTILIB_MATCHES    += > mbranch-protection?standard=mbranch-protection?bti+pac-ret > +MULTILIB_MATCHES    += > mbranch-protection?standard=mbranch-protection?bti+pac-ret+leaf > + > > The documentation mentions -mbranch-protection=standard+leaf, so you're > missing a mapping for that. > > > OK with that change. > > R. Oh, and please add some tests to gcc/testsuite/gcc.target/arm/multilib.exp R.