public inbox for
 help / color / mirror / Atom feed
From: Thomas Preudhomme <>
To: Mike Stump <>
Cc: Andrew Pinski <>,
	Rainer Orth <>,
	"" <>
Subject: Re: [PATCH, GCC/testsuite] Fix dump-noaddr dumpbase
Date: Tue, 05 Dec 2017 20:56:00 -0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Mike,

Thanks, I've tested after the two commits and it works both in tree and out of 
tree. It'll simplify comparing in tree results Vs out of tree for us, thanks a lot!

Would you consider a backport to stable branches if nobody complains after a week?

Best regards,


On 05/12/17 19:27, Mike Stump wrote:
> On Dec 5, 2017, at 11:11 AM, Thomas Preudhomme <> wrote:
>> On 05/12/17 17:54, Andrew Pinski wrote:
>>> On Tue, Dec 5, 2017 at 9:50 AM, Thomas Preudhomme
>>> <> wrote:
>>>> Hi,
>>>> dump-noaddr test FAILS when $tmpdir is not the same as the directory
>>>> where runtest is called from. Note that this does not happen when
>>>> running make check because tmpdir is set to srcdir.
>>>> In that case, file mkdir will create the directory in the current
>>>> directory while GCC is invoked from tmpdir and hence -dumpbase look
>>>> for dump1 and dump2 relative to tmpdir. This patch forces dumpbase to
>>>> be relative to tmpdir which will work in all case.
>>>> ChangeLog entry is as follows:
>>>> *** gcc/testsuite/ChangeLog ***
>>>> 2017-12-05  Thomas Preud'homme  <>
>>>>          * gcc.c-torture/unsorted/dump-noaddr.x (dump_compare): Set dump base
>>>>          relative to tmpdir.
>>>> Testing: Successfully ran unsorted.exp via make check and out of tree
>>>> testing using runtest from <path>/test with tmpdir set in
>>>> <path>/test/site.exp to <path>.
>>>> Is this ok for stage3?
>>> I don't remember where this discussion went last time.
>>> Maybe this time there will be a resolution :).
>> FWIW, I agree with Matt, creating the dump in tmpdir makes more sense. I think his patch can be simplified though because the compiler seems to be invoked from tmpdir so it can at least be omitted from the -dumpbase.
> Sounds reasonable.  I've added that on top of his patch and checked that in.  Let us know if it works or not.

  reply	other threads:[~2017-12-05 20:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05 17:50 Thomas Preudhomme
2017-12-05 17:54 ` Andrew Pinski
2017-12-05 19:11   ` Thomas Preudhomme
2017-12-05 19:27     ` Mike Stump
2017-12-05 20:56       ` Thomas Preudhomme [this message]
2017-12-05 21:26         ` Mike Stump
2018-03-01 16:41           ` Thomas Preudhomme
2019-12-02  4:52       ` Andrew Pinski
2017-12-05 19:25   ` Mike Stump
2022-11-10  3:00 ` Andrew Pinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).