From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id E70C73858D35 for ; Mon, 7 Mar 2022 13:14:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E70C73858D35 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8F34FD6E; Mon, 7 Mar 2022 05:14:42 -0800 (PST) Received: from [10.57.20.251] (unknown [10.57.20.251]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E93173F66F; Mon, 7 Mar 2022 05:14:41 -0800 (PST) Message-ID: Date: Mon, 7 Mar 2022 13:14:40 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] arm: fix option quoting in error messages. Content-Language: en-GB To: =?UTF-8?Q?Martin_Li=c5=a1ka?= , gcc-patches@gcc.gnu.org Cc: Christophe Lyon References: From: Richard Earnshaw In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3495.6 required=5.0 tests=BAYES_00, BODY_8BITS, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Mar 2022 13:14:44 -0000 On 07/03/2022 10:27, Martin Liška wrote: > This fixes option quoting in error messages. > > Ready to be installed? > Thanks, > Martin > >     PR target/104794 > > gcc/ChangeLog: > >     * config/arm/arm.cc (arm_option_override_internal): Fix quoting >     of options in error messages. >     (arm_option_reconfigure_globals): Likewise. > --- >  gcc/config/arm/arm.cc | 6 +++--- >  1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gcc/config/arm/arm.cc b/gcc/config/arm/arm.cc > index c1103d9fad6..4bf1ef0517d 100644 > --- a/gcc/config/arm/arm.cc > +++ b/gcc/config/arm/arm.cc > @@ -3185,8 +3185,8 @@ arm_option_override_internal (struct gcc_options > *opts, >    if (arm_stack_protector_guard == SSP_GLOBAL >        && opts->x_arm_stack_protector_guard_offset_str) >      { > -      error ("incompatible options %'-mstack-protector-guard=global%' and" > -         "%'-mstack-protector-guard-offset=%qs%'", > +      error ("incompatible options %<-mstack-protector-guard=global%> and" > +         "%<-mstack-protector-guard-offset=%s%>", Wasn't the complaint also that there should be a space in the text between the 'and"' and the '"%<' on the subsequent line? R. >           arm_stack_protector_guard_offset_str); >      } > > @@ -3880,7 +3880,7 @@ arm_option_reconfigure_globals (void) >      } > >    if (!TARGET_HARD_TP && arm_stack_protector_guard == SSP_TLSREG) > -    error("%'-mstack-protector-guard=tls%' needs a hardware TLS > register"); > +    error("%<-mstack-protector-guard=tls%> needs a hardware TLS > register"); >  } > >  /* Perform some validation between the desired architecture and the > rest of the