public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jlaw@ventanamicro.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: [committed] RISC-V: Fix minor testsuite problem with zicond
Date: Fri, 25 Aug 2023 16:30:00 -0600	[thread overview]
Message-ID: <fe44ae1c-93a9-9aea-b233-46082269f896@ventanamicro.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

I thought I had already fixed this, but clearly if I did, I didn't 
include it in any upstream commits.

With -Og the optimizers are hindered in various ways and this prevents 
using zicond.  So skip this test with -Og (it was already being skipped 
at -O0).

Pushed to the trunk.

Jeff


[-- Attachment #2: P --]
[-- Type: text/plain, Size: 1239 bytes --]

commit 3cd2b73079bac374ce1c542b9c9e354e00a8713d
Author: Jeff Law <jlaw@ventanamicro.com>
Date:   Fri Aug 25 16:23:06 2023 -0600

    [committed] RISC-V: Fix minor testsuite problem with zicond
    
    I thought I had already fixed this, but clearly if I did, I didn't include it
    in any upstream commits.
    
    With -Og the optimizers are hindered in various ways and this prevents using
    zicond.  So skip this test with -Og (it was already being skipped at -O0).
    
    gcc/testsuite
            * gcc.target/riscv/zicond-primitiveSemantics.c: Disable for -Og.

diff --git a/gcc/testsuite/gcc.target/riscv/zicond-primitiveSemantics.c b/gcc/testsuite/gcc.target/riscv/zicond-primitiveSemantics.c
index 76c5019a992..47d4e4c5683 100644
--- a/gcc/testsuite/gcc.target/riscv/zicond-primitiveSemantics.c
+++ b/gcc/testsuite/gcc.target/riscv/zicond-primitiveSemantics.c
@@ -1,7 +1,7 @@
 /* { dg-do compile } */
 /* { dg-options "-march=rv64gc_zicond -mabi=lp64d" { target { rv64 } } } */
 /* { dg-options "-march=rv32gc_zicond -mabi=ilp32f" { target { rv32 } } } */
-/* { dg-skip-if "" { *-*-* } {"-O0"} } */
+/* { dg-skip-if "" { *-*-* } {"-O0" "-Og"} } */
 
 long primitiveSemantics_00(long a, long b) { return a == 0 ? 0 : b; }
 

                 reply	other threads:[~2023-08-25 22:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe44ae1c-93a9-9aea-b233-46082269f896@ventanamicro.com \
    --to=jlaw@ventanamicro.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).