From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 82389385841C for ; Tue, 9 Apr 2024 02:37:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 82389385841C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 82389385841C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712630269; cv=none; b=qAj5c0ziXhSChFTgpEGHXpLAXbZBQp+Xl46yCIG/xJlsRospuAHRSi+LVxzFq16zKpVY04mivrPab7adVbt6gm+jr4TCeVGn7gI4/gTAvGlYH1s1Awc6Bx4+8DZ0AyugdxxkHfMz2fX/DXcMZ8sUe2LHTeoPEwervdgiNVcE/AI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712630269; c=relaxed/simple; bh=Se3g/dWggjIoxQdDkYGdY3bR5ngY//xKkfqYuGUhLpM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=TEuXrElqs6us7L82khxjw+65S0vpmkJA3mR49PX3ah7Y6Q6mq8GT8TqiQAYkXr4wUX4v5IefLJ6QB12/D1eDhlAoFpleXcR0N9k1bZkggemybU0NTF75nUdn/DhqTXVq0dQWIM4/3Z/gQybMCnCQ7VqNvU/AsmtRJNadAWDBxEQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 4391o3MH029886; Tue, 9 Apr 2024 02:37:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=BmWUKubknvFl4pOgBpj9+uoLnV3C6r1jWr5BJQHSqio=; b=gYeNLpXvjBuZ3QcV/FI9WqD3oPi2X4T42CYjSMbMqU8PNYKPvYXGigOKnUb1LRPmiOL6 g5FBYA0r43CJYxG4sYIYPde7i0JzFmJdhAIu3f/Frl9MXXlbjYH0s2Dm/NixYP8f7sOl PgGsk0b7b7nk7RaHvgyzzcbTZbdi3OYevRpocTnBcwkMJc2dpju8vG/JAY1fzuB2Erc1 YXoJ6scmU2q+aVBax7rxkOSE6upDN/Bd+Mo9pApWP9BlFK+qv9Im88CHUXz5rUTqivTy hFC8FPdmZD2SX9CRerrk1U/XmW64ijHFymZihBYiNtvriKngiAXc3d2676O4yekmebBz Bg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xcv1hr2gs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Apr 2024 02:37:46 +0000 Received: from m0353723.ppops.net (m0353723.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 4392bjcE030307; Tue, 9 Apr 2024 02:37:46 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xcv1hr2gq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Apr 2024 02:37:45 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 4390vl84013550; Tue, 9 Apr 2024 02:37:45 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3xbgqtbw4a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Apr 2024 02:37:45 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4392bfPK49086880 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 9 Apr 2024 02:37:43 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 81E5520043; Tue, 9 Apr 2024 02:37:41 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E078820040; Tue, 9 Apr 2024 02:37:39 +0000 (GMT) Received: from [9.200.61.88] (unknown [9.200.61.88]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 9 Apr 2024 02:37:39 +0000 (GMT) Message-ID: Date: Tue, 9 Apr 2024 10:37:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] rs6000: Replace OPTION_MASK_DIRECT_MOVE with OPTION_MASK_P8_VECTOR [PR101865] Content-Language: en-US To: Peter Bergner Cc: Segher Boessenkool , David Edelsohn , GCC Patches References: <20234c37-d03b-a163-9e60-d63b965a55e0@linux.ibm.com> From: "Kewen.Lin" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: sym6-30DRW1lBNva1fKtRweaEKDkMOOe X-Proofpoint-ORIG-GUID: _16JgHi6f7q_FoFfwYvY6zFny1SLmPgs X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-08_19,2024-04-05_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 clxscore=1015 mlxscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 mlxlogscore=999 adultscore=0 malwarescore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404090014 X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Peter, on 2024/4/8 21:21, Peter Bergner wrote: > On 4/8/24 3:55 AM, Kewen.Lin wrote: >> on 2024/4/6 06:28, Peter Bergner wrote: >>> +mno-direct-move >>> +Target Undocumented WarnRemoved >>> + >>> mdirect-move >>> -Target Undocumented Mask(DIRECT_MOVE) Var(rs6000_isa_flags) WarnRemoved >>> +Target Undocumented WarnRemoved >> >> When reviewing my previous patch to "neuter option -mpower{8,9}-vector", >> Segher mentioned that we don't need to keep such option warning all the >> time and can drop it like in a release later as users should be aware of >> this information then, I agreed and considering that patch disabling >> -m[no-]direct-move was r8-7845-g57f108f5a1e1b2, I think we can just remove >> m[no-]direct-move here? What do you think? > > > I'm fine with that if that is what we want. So something like the following? > > +;; This option existed in the past, but now is always silently ignored. > mdirect-move > -Target Undocumented Mask(DIRECT_MOVE) Var(rs6000_isa_flags) WarnRemoved > +Target Undocumented Ignore I prefer to remove it completely, that is: > -mdirect-move > -Target Undocumented Mask(DIRECT_MOVE) Var(rs6000_isa_flags) WarnRemoved The reason why you still kept it is to keep a historical record here? Segher pointed out to me that this kind of option complete removal should be stage 1 stuff, so let's defer to make it in a separated patch next release (including some other options like mfpgpr you showed below etc.). :) For the original patch, > +mno-direct-move > +Target Undocumented WarnRemoved s/WarnRemoved/Ignore/ to match some other existing practice, there is no warning now if specifying -mno-direct-move and it would be good to keep the same behavior for users. OK for trunk and active branches with this tweaked, thanks! > > > The above seems to silently ignore both -mdirect-move and -mno-direct-move > which I think is what we want. That said, it's not what we've done with > other options, but maybe those just need to be changed too? Yes, I think they need to be changed too (next release). BR, Kewen