From: "Martin Liška" <mliska@suse.cz>
To: David Malcolm <dmalcolm@redhat.com>, gcc-patches@gcc.gnu.org
Cc: Jakub Jelinek <jakub@redhat.com>,
Richard Biener <richard.guenther@gmail.com>
Subject: Re: [PATCH] Come up with json::integer_number and use it in GCOV.
Date: Mon, 26 Aug 2019 13:06:00 -0000 [thread overview]
Message-ID: <fedff3d0-d85f-ce2b-8373-01376a468af0@suse.cz> (raw)
In-Reply-To: <21e87c50-9635-0a28-60b2-53a01661b60f@suse.cz>
PING^1
On 8/13/19 1:51 PM, Martin Liška wrote:
> On 8/2/19 2:40 PM, David Malcolm wrote:
>> Something that occurred to me reading the updated patch: maybe it would
>> make things easier to have utility member functions of json::object to
>> implicitly make the child, e.g.:
>>
>> void
>> json::object::set (const char *key, long v)
>> {
>> set (key, new json::integer_number (v));
>> }
>>
>> so that all those calls can be just:
>>
>> obj->set ("line", exploc.line);
>> obj->set ("column", exploc.column);
>>
>> etc (assuming overloading is unambiguous).
>>
>> But that's probably orthogonal to this patch.
>
> Looks good to me. It's a candidate for a follow up patch.
>
>>
>>
>>> And I changed all occurrences of float_number with integer_number
>>> as you suggested.
>> Thanks.
>>
>>> I'm currently testing the updated patch.
>>> Martin
>> The updated patch looks good to me, but technically I'm not a reviewer
>> for these files.
>
> Sure, I hope @Jakub or @Richi can approve me that?
> Thanks,
> Martin
>
>>
>> Dave
>
next prev parent reply other threads:[~2019-08-26 12:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 8:50 Martin Liška
2019-07-31 13:16 ` David Malcolm
2019-08-02 10:22 ` Martin Liška
2019-08-02 12:40 ` David Malcolm
2019-08-13 12:33 ` Martin Liška
2019-08-26 13:06 ` Martin Liška [this message]
2019-08-30 9:08 ` Martin Liška
2019-09-09 12:38 ` Martin Liška
2019-09-18 8:04 ` Martin Liška
2019-10-01 19:52 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fedff3d0-d85f-ce2b-8373-01376a468af0@suse.cz \
--to=mliska@suse.cz \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).