From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dog.elm.relay.mailchannels.net (dog.elm.relay.mailchannels.net [23.83.212.48]) by sourceware.org (Postfix) with ESMTPS id D43DC3855580 for ; Tue, 7 Feb 2023 20:04:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D43DC3855580 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=tempfail smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 62CA73E2515; Tue, 7 Feb 2023 20:04:00 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 895E53E243E; Tue, 7 Feb 2023 20:03:57 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1675800237; a=rsa-sha256; cv=none; b=ysjzIBrsoZqHyNnig+tHUs0UH7EgMWA52Md7nO52IOWNSgAAbgbK3gQ2t/mZk8uIvnC0MO /IrD0H4cOA7yOj/N+doTIzB8Gw6qXN/8ntk3WyloEhF/JZO1cfvRslPtiVN0XLeHj8niGa Q6Bo7tut+z8sG1ZUddzcN+gY6+VwqOHpOfxdPe/rbB5+h5ZnCLGdrNk64WPfjhL5A4yT0W W0n1jPuMsyOzjO5/WU1oeBMDRbXUtZvCP5CB3hUDwun7icsYyT4450Uu/hRRxTvXUglKiO brGCRg3jmNqpab/zo2wrV7Zfwe4Zauf9ZkxBpjtah8eodIKk2qZXi603nX4vCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1675800237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0ipE8Z1c5a6pHL2XCfImI6RWR3C4Ud4uQJEnudLSG3E=; b=QQt6NJtDK/9xQK8+ITGjo5h8k38IRucqM7YhRpX3JHpovfv8+Oo28JC8QfTC3rqM3C8GEm 23FGRac8V4N+hQ4PL+HI//vTDvPWuaqK9zL4zaP1JinvUe+CckdRla/Drzx9GScIzz515J Y7YW1uPsAPGzsrpChOfqmjVGXMxUXyq3+TQ0qxB872aZWXuRkTetqBiBhBMuHtaNBDhdBl HRRrTX+IU5MfMhb9tN7m3h4mvl7nLdC8xoU/c8E9Awn/ukXvIsAeq886k1fvtEpKsX+jth nHt6bE0dXjOTuz/2/muIwRSLvZr4X4u0i0EXnwvQL78rKrGCducFDwDO/6SjCQ== ARC-Authentication-Results: i=1; rspamd-98dc9695d-jplcr; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Madly-Troubled: 346d98c77e275d96_1675800239639_1694642939 X-MC-Loop-Signature: 1675800239638:3324365655 X-MC-Ingress-Time: 1675800239638 Received: from pdx1-sub0-mail-a306.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.97.74.40 (trex/6.7.1); Tue, 07 Feb 2023 20:03:59 +0000 Received: from [192.168.0.182] (bras-vprn-toroon4834w-lp130-07-174-93-43-36.dsl.bell.ca [174.93.43.36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a306.dreamhost.com (Postfix) with ESMTPSA id 4PBDbc4qxJz83; Tue, 7 Feb 2023 12:03:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1675800236; bh=QF4e7/sejKil3WN6xc7RStvtx+Ha3QFdkJZzAy6CFBo=; h=Date:Subject:From:To:Cc:Content-Type:Content-Transfer-Encoding; b=niwdIN7LHzlDqlvIgXV53K8wumz2d2ylU2caEUtMaMfJHzBT2y5RhnHGmWY04/zbC vllCyj0BttG1CouSEcnb3p35ekDfRbFzHENz70QbMT6HzcT+DZdpuzqnmUlmn36nx/ FZBZlAZLkZ90pvzwRTjPucuK6oF+aZDHTVc+lNIvc/+dkkXo7A1PoEaNDC8JxlmaGo bTfIHkiTjz9EsZn5coO+JntK1ZaDNrQ98uFzQuUs6e2cCfY9yrVy14E98dfvVrtDBY YOpLCH2nwDDxK0N9xio3a0sLzc+CUjlcF0MdhNoGl7zfT8saFuU0rgyODLijWrzcAp PmLHweBa/TUTw== Message-ID: Date: Tue, 7 Feb 2023 15:03:55 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] tree-optimization/108522 Use component_ref_field_offset Content-Language: en-US From: Siddhesh Poyarekar To: gcc-patches@gcc.gnu.org Cc: jakub@redhat.com References: <20230126033210.1926726-1-siddhesh@gotplt.org> In-Reply-To: <20230126033210.1926726-1-siddhesh@gotplt.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3031.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,TXREP,T_SPF_TEMPERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-01-25 22:32, Siddhesh Poyarekar wrote: > Instead of using TREE_OPERAND (expr, 2) directly, use > component_ref_field_offset instead, which does scaling for us. The > function also substitutes PLACEHOLDER_EXPRs, which is probably what we > want anyway but I'm not sure if it's relevant for tree-object-size. > > gcc/ChangeLog: > > PR tree-optimization/108522 > * tree-object-size.cc (compute_object_offset): Make EXPR > argument non-const. Call component_ref_field_offset. > > gcc/testsuite/ChangeLog: > > PR tree-optimization/108522 > * gcc.dg/builtin-dynamic-object-size-0.c (DEFSTRUCT): New > macro. > (test_dynarray_struct_member_b, test_dynarray_struct_member_c, > test_dynarray_struct_member_d, > test_dynarray_struct_member_subobj_b, > test_dynarray_struct_member_subobj_c, > test_dynarray_struct_member_subobj_d): New tests. > (main): Call them. > > Signed-off-by: Siddhesh Poyarekar ... and now pushed (this and the earlier commit) to gcc-12 branch. Sid