From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by sourceware.org (Postfix) with ESMTPS id 472C5385C408 for ; Thu, 28 Oct 2021 14:53:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 472C5385C408 Received: by mail-pj1-x102f.google.com with SMTP id na16-20020a17090b4c1000b0019f5bb661f9so4967204pjb.0 for ; Thu, 28 Oct 2021 07:53:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=/r+kHjuA3P4gYzpndvyOaZlTQj53AVcauTYvuFKqr5w=; b=dwLExH2Xdqg6/B6KJ8OyE0GdhlRESjwUynF9lurJIr9xKVyIhiUfxYKaSZS3ZQiq91 +t2twAQxzYCFNWA6LbQ8741pfT+3ars46ACFo9BAw2AuB9RGUjvUJeVKXvhgFRWvo0a6 jyq45P756ajiG0Pkpcihz92BvTXE+sdiJP+Gu3uo4/pQ6tWxzFld23wnCY/71aBEezZ1 5KS2dJNjV2Yg7GiX0QmISpV0esQFki/vcKtjM9qaWM9v1ihRiAx6Ua0eqeoMME7/n3R8 eKiMruL4CzUWbvABMiHnCxNcFR7SZYCKAhqG+cYmon9Dx5Ou6x4T9YuDNaI6AOppiMON CHpw== X-Gm-Message-State: AOAM5337YYF0WXLt4Ag0aUvO2E4Pe10R8F0e9LChdNmVMsys+RvoS7ZV fC6Og1Y+VmN1jwFNKcdDX5NswhKIG+4= X-Google-Smtp-Source: ABdhPJzUkpX3e/OstJipGnle9juypVQ5XSkHB5eD/KZ5tgplXo+Uco49swctyWcw8kBxpwrSek+klw== X-Received: by 2002:a17:902:9a04:b0:13a:1ae3:add2 with SMTP id v4-20020a1709029a0400b0013a1ae3add2mr4223944plp.28.1635432791182; Thu, 28 Oct 2021 07:53:11 -0700 (PDT) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id t1sm3618811pfe.51.2021.10.28.07.53.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Oct 2021 07:53:10 -0700 (PDT) Subject: Re: [PATCH] assert_streq: add newlines to failure message To: David Malcolm , gcc-patches@gcc.gnu.org References: <20211026212746.671762-1-dmalcolm@redhat.com> From: Jeff Law Message-ID: Date: Thu, 28 Oct 2021 08:53:10 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211026212746.671762-1-dmalcolm@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Oct 2021 14:53:13 -0000 On 10/26/2021 3:27 PM, David Malcolm via Gcc-patches wrote: > Adding newlines so that the two strings line up makes string equality > failures considerably easier to read. > > Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. > OK for trunk? > > gcc/ChangeLog: > * selftest.c (assert_streq): Add newlines when emitting non-equal > non-NULL strings. > > Signed-off-by: David Malcolm OK jeff