From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by sourceware.org (Postfix) with ESMTPS id 2A1BE3858D20 for ; Fri, 21 Apr 2023 20:39:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2A1BE3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x102f.google.com with SMTP id 98e67ed59e1d1-2471214cdd3so1784093a91.1 for ; Fri, 21 Apr 2023 13:39:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682109542; x=1684701542; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vstesYBaQAAt28OwycT+kGUl63vrjfoyVyK5KE6FvYY=; b=PFaGxdtBx0hMy+1oeK74Z74LWP3WZUgTDXNVGfDarPdMEu70Abe8B8XIly1TilR6dH NdMHSb7V45baJAgLT16kFgX4o5/qyUjXa4XmoOtAjJi4ZhW/WjgaEJJ2NB1Haq7edK/N ahCEJ+FrBKdcelD/PxCvEAwJ0GR13HMtL5pTHYItF751OprTAugH6ttyyKUCMLscbdSQ khCyp4Icq0x+3ZcvnRoEAmQ+uEjyMk7Sa0mWebDVFvWMjrdmWa9uJMSKjs9uKhgt+fut A7NcQ7GY6PC4bzNzpRqMW64z4piwUqJeVDHonWSXnUqEAGcww4XbdwjtzDh/OkvLdHSl lM4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682109542; x=1684701542; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vstesYBaQAAt28OwycT+kGUl63vrjfoyVyK5KE6FvYY=; b=VZyFnIx23UeH8ZJeePW2oGIJiHbzNsM17/lSQKiXEfryhCbQoxv2/kvDgdSgCjAUTv V03SUuctWG287cgdnt1aU8aVZGri7AiPHy7fIoGKhLR3GhvgNIOSMjnWi7oAjlQgPhvF rbipEkODx03/yluxVUm7sM1SX1Jwy7nLUVgw6dWDL5lXooj0MoqB9rXfas3zn6/DN+AI 6jwq8d3IahaJty5zoWETcxOVOrehBIvo/WJfyNo1itI7ixNyQDPVVmXlmEOdYGOV04eD e3Qs0nyqlHp5fN116Q2uiqIa8VbXd3Ar4K+JAu3D5qMVAP0EjcQpKPMn3PiCavrLjl7w /DdQ== X-Gm-Message-State: AAQBX9dYdjjV3kOTRKqfXZavjxg0WqTq2xLNCDdo5cgHjoEFn18Vn+fa 2nE153zSmVmcgtXw8hm0bOM= X-Google-Smtp-Source: AKy350bmYKsxYDepbE+b+DNcJybTh9DaLRdr9j5ui5ncsDjBv3b+/fLNDBJlqRei9GcKX8K/PzU0uA== X-Received: by 2002:a17:90b:1b4a:b0:24b:5eb7:f404 with SMTP id nv10-20020a17090b1b4a00b0024b5eb7f404mr4614220pjb.41.1682109541954; Fri, 21 Apr 2023 13:39:01 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::99f? ([2601:681:8600:13d0::99f]) by smtp.gmail.com with ESMTPSA id bj19-20020a17090b089300b002465a7fc0cfsm4797885pjb.44.2023.04.21.13.39.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Apr 2023 13:39:01 -0700 (PDT) Message-ID: Date: Fri, 21 Apr 2023 14:38:59 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] riscv: thead: Add sign/zero extension support for th.ext and th.extu Content-Language: en-US To: Christoph Muellner , gcc-patches@gcc.gnu.org, Kito Cheng , Jim Wilson , Palmer Dabbelt , Andrew Waterman , Philipp Tomsich , Cooper Qu , Lifang Xia , Yunhai Shang , Zhiwei Liu References: <20230315122448.3394353-1-christoph.muellner@vrull.eu> From: Jeff Law In-Reply-To: <20230315122448.3394353-1-christoph.muellner@vrull.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_MANYTO,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/15/23 06:24, Christoph Muellner wrote: > From: Christoph Müllner > > The current support of the bitfield-extraction instructions > th.ext and th.extu (XTheadBb extension) only covers sign_extract > and zero_extract. This patch add support for sign_extend and > zero_extend to avoid any shifts for sign or zero extensions. > > gcc/ChangeLog: > > * config/riscv/riscv.md: > * config/riscv/thead.md (*extend2_th_ext): > (*zero_extendsidi2_th_extu): > (*zero_extendhi2_th_extu): > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/xtheadbb-ext-1.c: New test. > * gcc.target/riscv/xtheadbb-extu-1.c: New test. OK. Though the main part of the ChangeLog needs some content ;-) jeff