public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Lulu Cheng <chenglulu@loongson.cn>
To: Xi Ruoyao <xry111@xry111.site>, gcc-patches@gcc.gnu.org
Cc: mark@klomp.org, i@xen0n.name, xuchenghua@loongson.cn
Subject: Re:[pushed] [PATCH v1] LoongArch: Set default alignment for functions jumps and loops [PR112919].
Date: Mon, 8 Apr 2024 09:04:53 +0800	[thread overview]
Message-ID: <ff4a1a14-5ce5-26dc-5620-1897b53f99b7@loongson.cn> (raw)
In-Reply-To: <682a8b56bd89b58acf3b7ab6a7e61d671535ea7e.camel@xry111.site>


在 2024/4/6 下午5:53, Xi Ruoyao 写道:
> On Tue, 2024-04-02 at 15:03 +0800, Lulu Cheng wrote:
>> +/* Alignment for functions loops and jumps for best performance.  For new
>> +   uarchs the value should be measured via benchmarking.  See the documentation
>> +   for -falign-functions -falign-loops and -falign-jumps in invoke.texi for the
>                             ^             ^
>
> Better have two commas here.
>
> Otherwise it should be OK.
>
>> +   format.  */
Modify the annotation information and pushed to r14-9824.


      reply	other threads:[~2024-04-08  1:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-02  7:03 Lulu Cheng
2024-04-06  9:53 ` Xi Ruoyao
2024-04-08  1:04   ` Lulu Cheng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff4a1a14-5ce5-26dc-5620-1897b53f99b7@loongson.cn \
    --to=chenglulu@loongson.cn \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=i@xen0n.name \
    --cc=mark@klomp.org \
    --cc=xry111@xry111.site \
    --cc=xuchenghua@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).