From: Sandra Loosemore <sandra@codesourcery.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: [PATCH testsuite, arm] cache fp16 hw effective-target tests
Date: Fri, 13 Sep 2019 16:31:00 -0000 [thread overview]
Message-ID: <ff812301-7e4b-cd68-efb0-bf94dd1f5955@codesourcery.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 706 bytes --]
In some bare-metal environments, the tests for fp16 runtime support fail
in a way that causes a timeout rather than immediate failure. (E.g.,
the runtime might provide a do-nothing exception handler that just sits
in a tight loop and never returns.) This patch changes the
effective-target tests for fp16 hardware support to cache the result of
the test so that we don't have to do this more than once. I think it
was probably just an oversight that it wasn't done this way originally,
since the target is hardly likely to sprout fp16 instruction support
midway through the test run anyway. ;-) Anyway, test results are the
same with this patch, they just run faster. OK to commit?
-Sandra
[-- Attachment #2: fp16-hw.log --]
[-- Type: text/x-log, Size: 235 bytes --]
2019-09-13 Sandra Loosemore <sandra@codesourcery.com>
gcc/testsuite/
* lib/target-supports.exp
(check_effective_target_arm_neon_fp16_hw)
(check_effective_target_arm_fp16_hw): Use check_runtime
instead of check_runtime_nocache.
[-- Attachment #3: fp16-hw.patch --]
[-- Type: text/x-patch, Size: 696 bytes --]
Index: gcc/testsuite/lib/target-supports.exp
===================================================================
--- gcc/testsuite/lib/target-supports.exp (revision 275699)
+++ gcc/testsuite/lib/target-supports.exp (working copy)
@@ -3909,7 +3909,7 @@ proc check_effective_target_arm_neon_fp1
return 0
}
global et_arm_neon_fp16_flags
- check_runtime_nocache arm_neon_fp16_hw {
+ check_runtime arm_neon_fp16_hw {
int
main (int argc, char **argv)
{
@@ -4162,7 +4162,7 @@ proc check_effective_target_arm_fp16_hw
return 0
}
global et_arm_fp16_flags
- check_runtime_nocache arm_fp16_hw {
+ check_runtime arm_fp16_hw {
int
main (int argc, char **argv)
{
next reply other threads:[~2019-09-13 16:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 16:31 Sandra Loosemore [this message]
2019-09-15 15:33 ` Ramana Radhakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff812301-7e4b-cd68-efb0-bf94dd1f5955@codesourcery.com \
--to=sandra@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).