From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-289293-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 22497 invoked by alias); 12 Apr 2011 15:01:05 -0000
Received: (qmail 22488 invoked by uid 22791); 12 Apr 2011 15:01:04 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from mail-wy0-f175.google.com (HELO mail-wy0-f175.google.com) (74.125.82.175)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Apr 2011 15:01:00 +0000
Received: by wye20 with SMTP id 20so6824994wye.20        for <gcc-patches@gcc.gnu.org>; Tue, 12 Apr 2011 08:00:58 -0700 (PDT)
Received: by 10.216.179.137 with SMTP id h9mr1228289wem.4.1302620458796;        Tue, 12 Apr 2011 08:00:58 -0700 (PDT)
Received: from richards-thinkpad (gbibp9ph1--blueice2n1.emea.ibm.com [195.212.29.75])        by mx.google.com with ESMTPS id d54sm3229230wej.34.2011.04.12.08.00.56        (version=TLSv1/SSLv3 cipher=OTHER);        Tue, 12 Apr 2011 08:00:57 -0700 (PDT)
From: Richard Sandiford <richard.sandiford@linaro.org>
To: "H.J. Lu" <hjl.tools@gmail.com>
Mail-Followup-To: "H.J. Lu" <hjl.tools@gmail.com>,gcc-patches@gcc.gnu.org,  patches@linaro.org, richard.sandiford@linaro.org
Cc: gcc-patches@gcc.gnu.org,  patches@linaro.org
Subject: Re: Recording predicate information in all rtl gen* programs
References: <g439lnhcvq.fsf@linaro.org>	<BANLkTinqHoNBe7BrxQ9VCk0qikm+aW0+-g@mail.gmail.com>
Date: Tue, 12 Apr 2011 15:01:00 -0000
In-Reply-To: <BANLkTinqHoNBe7BrxQ9VCk0qikm+aW0+-g@mail.gmail.com> (H. J. Lu's	message of "Tue, 12 Apr 2011 07:07:09 -0700")
Message-ID: <g462qjecpk.fsf@linaro.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2011-04/txt/msg00897.txt.bz2

"H.J. Lu" <hjl.tools@gmail.com> writes:
> I think your patch caused:
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48573

Sorry, this didn't show up on pure x86_64.  It was caused by the
optabs.c patch rather than this one.  I've reverted it for now.

One fix would be:

  /* If the operand is a memory, try forcing the address into a register.  */
  if (MEM_P (op->value)
      && GET_RTX_CLASS (GET_CODE (XEXP (op->value, 0))) != RTX_AUTOINC
      && insn_data[(int) icode].operand[opno].allows_mem)

I think all other addresses really can be forced into registers.

Richard