From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25048 invoked by alias); 26 Sep 2011 09:29:56 -0000 Received: (qmail 20134 invoked by uid 22791); 26 Sep 2011 09:19:01 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-wy0-f175.google.com (HELO mail-wy0-f175.google.com) (74.125.82.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Sep 2011 09:18:47 +0000 Received: by wyh5 with SMTP id 5so6144984wyh.20 for ; Mon, 26 Sep 2011 02:18:45 -0700 (PDT) Received: by 10.216.133.153 with SMTP id q25mr161484wei.99.1317028725828; Mon, 26 Sep 2011 02:18:45 -0700 (PDT) Received: from richards-thinkpad.stglab.manchester.uk.ibm.com (gbibp9ph1--blueice2n1.emea.ibm.com. [195.212.29.75]) by mx.google.com with ESMTPS id p13sm30031477wbh.13.2011.09.26.02.18.44 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 26 Sep 2011 02:18:44 -0700 (PDT) From: Richard Sandiford To: Jakub Jelinek Mail-Followup-To: Jakub Jelinek ,Richard Guenther , Eric Botcazou , gcc-patches@gcc.gnu.org, richard.sandiford@linaro.org Cc: Richard Guenther , Eric Botcazou , gcc-patches@gcc.gnu.org Subject: Re: Patch ping References: <20110926083144.GE2687@tyan-ft48-01.lab.bos.redhat.com> Date: Mon, 26 Sep 2011 10:08:00 -0000 In-Reply-To: <20110926083144.GE2687@tyan-ft48-01.lab.bos.redhat.com> (Jakub Jelinek's message of "Mon, 26 Sep 2011 10:31:44 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-09/txt/msg01569.txt.bz2 Jakub Jelinek writes: > optimize all ones vectors in simplify-rtx.c (and i386 expansion): > http://gcc.gnu.org/ml/gcc-patches/2011-09/msg01364.html I wonder whether we should have a CONSTM1_RTX(MODE). It seems inconsistent to have vector 0s and 1s, but only have integer -1s. As far as simplify-rtx.c goes, I think all_ones_cst should cover the existing CONST_INT_P case too. CONST_INTs have to be represented as sign-extended, and "trueop1" should still have mode "mode", so something's wrong if the current code matches things that aren't constm1_rtx. The simplify-rtx.c change looks good otherwise. Richard