From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31836 invoked by alias); 22 Mar 2012 10:25:08 -0000 Received: (qmail 31801 invoked by uid 22791); 22 Mar 2012 10:25:07 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-wi0-f173.google.com (HELO mail-wi0-f173.google.com) (209.85.212.173) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Mar 2012 10:24:48 +0000 Received: by wibhq7 with SMTP id hq7so409690wib.8 for ; Thu, 22 Mar 2012 03:24:47 -0700 (PDT) Received: by 10.180.104.230 with SMTP id gh6mr3738967wib.22.1332411887060; Thu, 22 Mar 2012 03:24:47 -0700 (PDT) Received: from richards-thinkpad.stglab.manchester.uk.ibm.com (gbibp9ph1--blueice2n1.emea.ibm.com. [195.212.29.75]) by mx.google.com with ESMTPS id e6sm4132390wix.8.2012.03.22.03.24.46 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 22 Mar 2012 03:24:46 -0700 (PDT) From: Richard Sandiford To: Mike Stump Mail-Followup-To: Mike Stump ,gcc-patches Patches , rdsandiford@googlemail.com Cc: gcc-patches Patches Subject: Re: remove wrong code in immed_double_const References: <5FF5A724-3FE1-4E97-8124-542A0B8259FE@comcast.net> <87obrvd6fh.fsf@talisman.home> <87haxmgqoo.fsf@talisman.home> <7C6A7462-C1D3-4765-83FF-3B3C726D92E5@comcast.net> <8762e09sgc.fsf@talisman.home> <0A5CBD0C-FC94-4637-B230-1A83372DE91A@comcast.net> Date: Thu, 22 Mar 2012 10:25:00 -0000 In-Reply-To: (Richard Sandiford's message of "Thu, 22 Mar 2012 10:16:14 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-03/txt/msg01488.txt.bz2 Richard Sandiford writes: > Should be: > > if (add_double_with_sign (l1, h1, l2, h2, &lv, &hv, false)) > /* Sorry, we have no way to represent overflows this > wide. To fix, add constant support wider than > CONST_DOUBLE. */ > gcc_assert (GET_MODE_BITSIZE (mode) > 2 * HOST_BITS_PER_WIDE_INT) Er, I did of course mean: gcc_assert (GET_MODE_BITSIZE (mode) <= 2 * HOST_BITS_PER_WIDE_INT) :-) Richard