From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11516 invoked by alias); 12 Apr 2011 14:39:21 -0000 Received: (qmail 11506 invoked by uid 22791); 12 Apr 2011 14:39:21 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-ww0-f41.google.com (HELO mail-ww0-f41.google.com) (74.125.82.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Apr 2011 14:39:17 +0000 Received: by wwi18 with SMTP id 18so3895095wwi.2 for ; Tue, 12 Apr 2011 07:39:16 -0700 (PDT) Received: by 10.216.241.197 with SMTP id g47mr210640wer.110.1302619156290; Tue, 12 Apr 2011 07:39:16 -0700 (PDT) Received: from richards-thinkpad (gbibp9ph1--blueice2n1.emea.ibm.com [195.212.29.75]) by mx.google.com with ESMTPS id f30sm3224418wef.7.2011.04.12.07.39.15 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 12 Apr 2011 07:39:15 -0700 (PDT) From: Richard Sandiford To: Richard Guenther Mail-Followup-To: Richard Guenther ,gcc-patches@gcc.gnu.org, patches@linaro.org, richard.sandiford@linaro.org Cc: gcc-patches@gcc.gnu.org, patches@linaro.org Subject: Re: [2/9] Reindent parts of vectorizable_load and vectorizable_store References: Date: Tue, 12 Apr 2011 14:39:00 -0000 In-Reply-To: (Richard Guenther's message of "Tue, 12 Apr 2011 15:33:05 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg00893.txt.bz2 Richard Guenther writes: > On Tue, Apr 12, 2011 at 3:28 PM, Richard Sandiford > wrote: >> This patch just reindents part of vectorizable_load and vectorizable_sto= re >> so that the main diff is easier to read. =C2=A0It also CSEs the element = type, >> which seemed better than breaking the long lines. >> >> I've included both the real diff and a -b version. >> >> Tested on x86_64-linux-gnu and arm-linux-gnueabi. =C2=A0OK to install? > > CSEing element type is ok, but please don't install patches (separately) > that introduce if (1)s. I suppose this patch is to make followups smalle= r? Yeah, patch 5 was pretty unreadable otherwise. Richard