From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9096 invoked by alias); 26 Sep 2011 07:51:24 -0000 Received: (qmail 9078 invoked by uid 22791); 26 Sep 2011 07:51:22 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-ww0-f41.google.com (HELO mail-ww0-f41.google.com) (74.125.82.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Sep 2011 07:50:55 +0000 Received: by wwf10 with SMTP id 10so9869096wwf.2 for ; Mon, 26 Sep 2011 00:50:54 -0700 (PDT) Received: by 10.227.5.138 with SMTP id 10mr5425812wbv.35.1317023454411; Mon, 26 Sep 2011 00:50:54 -0700 (PDT) Received: from richards-thinkpad.stglab.manchester.uk.ibm.com (gbibp9ph1--blueice2n1.emea.ibm.com. [195.212.29.75]) by mx.google.com with ESMTPS id gd6sm29740967wbb.1.2011.09.26.00.50.52 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 26 Sep 2011 00:50:53 -0700 (PDT) From: Richard Sandiford To: Dinar Temirbulatov Mail-Followup-To: Dinar Temirbulatov ,gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com Cc: gcc-patches@gcc.gnu.org Subject: Re: MIPS Fix PR18141 References: Date: Mon, 26 Sep 2011 09:04:00 -0000 In-Reply-To: (Dinar Temirbulatov's message of "Fri, 23 Sep 2011 21:14:45 +0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-09/txt/msg01561.txt.bz2 Dinar Temirbulatov writes: > I found typo in the patch instead of checking *set_after != 0 it was > set_after != 0, here is corrected version of patch. I retested the > patch without typo on mipsel-unknown-linux-gnu with no new > regressions. But my point was that *set_after should always be nonnull if *delayed_reg is. So we shouldn't need that check anyway. The patch looks OK otherwise apart from formatting (the formatting should be the same as in the version I suggested before: else if (*delayed_reg != 0 && reg_referenced_p (*delayed_reg, pattern) && !(recog_memoized (insn) == CODE_FOR_load_highdf && recog_memoized (*set_after) == CODE_FOR_load_lowdf)) ) but it needs a copyright assignment. Richard