From: Richard Sandiford <richard.sandiford@linaro.org>
To: Richard Guenther <richard.guenther@gmail.com>
Cc: gcc-patches@gcc.gnu.org, patches@linaro.org
Subject: Re: [5/9] Main target-independent support for direct interleaving
Date: Mon, 18 Apr 2011 11:57:00 -0000 [thread overview]
Message-ID: <g4bp03ajjw.fsf@linaro.org> (raw)
In-Reply-To: <BANLkTi=Q07DdYYiP_oWMbHtVud4z_xr9Bw@mail.gmail.com> (Richard Guenther's message of "Mon, 18 Apr 2011 13:09:46 +0200")
Richard Guenther <richard.guenther@gmail.com> writes:
> On Tue, Apr 12, 2011 at 3:59 PM, Richard Sandiford
> <richard.sandiford@linaro.org> wrote:
>> This patch adds vec_load_lanes and vec_store_lanes optabs for instructions
>> like NEON's vldN and vstN. The optabs are defined this way because the
>> vectors must be allocated to a block of consecutive registers.
>>
>> Tested on x86_64-linux-gnu and arm-linux-gnueabi. OK to install?
>>
>> Richard
>>
>>
>> gcc/
>> * doc/md.texi (vec_load_lanes, vec_store_lanes): Document.
>> * optabs.h (COI_vec_load_lanes, COI_vec_store_lanes): New
>> convert_optab_index values.
>> (vec_load_lanes_optab, vec_store_lanes_optab): New convert optabs.
>> * genopinit.c (optabs): Initialize the new optabs.
>> * internal-fn.def (LOAD_LANES, STORE_LANES): New internal functions.
>> * internal-fn.c (get_multi_vector_move, expand_LOAD_LANES)
>> (expand_STORE_LANES): New functions.
>> * tree.h (build_simple_array_type): Declare.
>> * tree.c (build_simple_array_type): New function.
>> * tree-vectorizer.h (vect_model_store_cost): Add a bool argument.
>> (vect_model_load_cost): Likewise.
>> (vect_store_lanes_supported, vect_load_lanes_supported)
>> (vect_record_strided_load_vectors): Declare.
>> * tree-vect-data-refs.c (vect_lanes_optab_supported_p)
>> (vect_store_lanes_supported, vect_load_lanes_supported): New functions.
>> (vect_transform_strided_load): Split out statement recording into...
>> (vect_record_strided_load_vectors): ...this new function.
>> * tree-vect-stmts.c (create_vector_array, read_vector_array)
>> (write_vector_array, create_array_ref): New functions.
>> (vect_model_store_cost): Add store_lanes_p argument.
>> (vect_model_load_cost): Add load_lanes_p argument.
>> (vectorizable_store): Try to use store-lanes functions for
>> interleaved stores.
>> (vectorizable_load): Likewise load-lanes and loads.
>> * tree-vect-slp.c (vect_get_and_check_slp_defs)
>> (vect_build_slp_tree):
>>
>> Index: gcc/doc/md.texi
>> ===================================================================
>> --- gcc/doc/md.texi 2011-04-12 12:16:46.000000000 +0100
>> +++ gcc/doc/md.texi 2011-04-12 14:48:28.000000000 +0100
>> @@ -3846,6 +3846,48 @@ into consecutive memory locations. Oper
>> consecutive memory locations, operand 1 is the first register, and
>> operand 2 is a constant: the number of consecutive registers.
>>
>> +@cindex @code{vec_load_lanes@var{m}@var{n}} instruction pattern
>> +@item @samp{vec_load_lanes@var{m}@var{n}}
>> +Perform an interleaved load of several vectors from memory operand 1
>> +into register operand 0. Both operands have mode @var{m}. The register
>> +operand is viewed as holding consecutive vectors of mode @var{n},
>> +while the memory operand is a flat array that contains the same number
>> +of elements. The operation is equivalent to:
>> +
>> +@smallexample
>> +int c = GET_MODE_SIZE (@var{m}) / GET_MODE_SIZE (@var{n});
>> +for (j = 0; j < GET_MODE_NUNITS (@var{n}); j++)
>> + for (i = 0; i < c; i++)
>> + operand0[i][j] = operand1[j * c + i];
>> +@end smallexample
>> +
>> +For example, @samp{vec_load_lanestiv4hi} loads 8 16-bit values
>> +from memory into a register of mode @samp{TI}@. The register
>> +contains two consecutive vectors of mode @samp{V4HI}@.
>
> So vec_load_lanestiv2qi would load ... ? c == 8 here. Intuitively
> such operation would have adjacent blocks of siv2qi memory. But
> maybe you want to constrain the mode size to GET_MODE_SIZE (@var{n})
> * GET_MODE_NUNITS (@var{n})? In which case the mode m is
> redundant? You could specify that we load NUNITS adjacent vectors into
> an integer mode of appropriate size.
Like you say, vec_load_lanestiv2qi would load 16 QImode elements into
8 consecutive V2QI registers. The first element from register vector I
would come from operand1[I] and the second element would come from
operand1[I + 8]. That's meant to be a valid combination.
We specifically want to allow:
GET_MODE_SIZE (@var{m})
!= GET_MODE_SIZE (@var{n}) * GET_MODE_NUNITS (@var{n})
The vec_load_lanestiv4hi example in the docs is one case of this:
GET_MODE_SIZE (@var{m}) = 16
GET_MODE_SIZE (@var{n}) = 8
GET_MODE_NUNITS (@var{n}) = 4
That example maps directly to ARM's vld2.32. We also want cases
where @var{m} is three times the size of @var{n} (vld3.WW) and
cases where @var{m} is four times the size of @var{n} (vld4.WW)
>> +/* Return a representation of ELT_TYPE[NELTS], using indices of type
>> + sizetype. */
>> +
>> +tree
>> +build_simple_array_type (tree elt_type, unsigned HOST_WIDE_INT nelts)
>
> build_array_type_nelts
OK.
Richard
next prev parent reply other threads:[~2011-04-18 11:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 13:21 [0/9] Direct support for loads and stores of interleaved vectors Richard Sandiford
2011-04-12 13:25 ` [1/9] Generalise vect_create_data_ref_ptr Richard Sandiford
2011-04-12 13:30 ` Richard Guenther
2011-04-12 13:28 ` [2/9] Reindent parts of vectorizable_load and vectorizable_store Richard Sandiford
2011-04-12 13:33 ` Richard Guenther
2011-04-12 14:39 ` Richard Sandiford
2011-04-12 13:40 ` [3/9] STMT_VINFO_RELATED_STMT handling in vectorizable_store Richard Sandiford
2011-04-17 10:25 ` Ira Rosen
2011-04-12 13:44 ` [4/9] Move power-of-two checks for interleaving Richard Sandiford
2011-04-12 13:57 ` Richard Guenther
2011-04-12 13:59 ` [5/9] Main target-independent support for direct interleaving Richard Sandiford
2011-04-17 14:26 ` Ira Rosen
2011-04-18 11:54 ` Richard Guenther
2011-04-18 11:57 ` Richard Sandiford [this message]
2011-04-18 12:54 ` Richard Guenther
2011-04-18 12:58 ` Richard Sandiford
2011-04-18 13:22 ` Richard Guenther
2011-04-12 14:01 ` [6/9] NEON vec_load_lanes and vec_store_lanes patterns Richard Sandiford
2011-04-15 13:20 ` Richard Earnshaw
2011-04-12 14:14 ` [7/9] Testsuite: remove vect_{extract_even_odd,strided}_wide Richard Sandiford
2011-04-15 12:43 ` Richard Guenther
2011-04-12 14:19 ` [8/9] Testsuite: split tests for strided accesses Richard Sandiford
2011-04-15 12:44 ` Richard Guenther
2011-04-12 14:29 ` [9/9] Testsuite: Replace vect_strided with vect_stridedN Richard Sandiford
2011-04-15 12:44 ` Richard Guenther
2011-04-12 14:34 ` [10/9] Add tests for stride-3 accesses Richard Sandiford
2011-04-15 12:45 ` Richard Guenther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=g4bp03ajjw.fsf@linaro.org \
--to=richard.sandiford@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=patches@linaro.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).