From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11470 invoked by alias); 21 Sep 2011 12:59:46 -0000 Received: (qmail 11462 invoked by uid 22791); 21 Sep 2011 12:59:45 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-ey0-f175.google.com (HELO mail-ey0-f175.google.com) (209.85.215.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Sep 2011 12:59:27 +0000 Received: by eya25 with SMTP id 25so957028eya.20 for ; Wed, 21 Sep 2011 05:59:26 -0700 (PDT) Received: by 10.213.34.7 with SMTP id j7mr298161ebd.136.1316609965857; Wed, 21 Sep 2011 05:59:25 -0700 (PDT) Received: from richards-thinkpad.stglab.manchester.uk.ibm.com (gbibp9ph1--blueice3n2.emea.ibm.com. [195.212.29.84]) by mx.google.com with ESMTPS id v60sm14601807eev.12.2011.09.21.05.59.24 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 21 Sep 2011 05:59:24 -0700 (PDT) From: Richard Sandiford To: Dinar Temirbulatov Mail-Followup-To: Dinar Temirbulatov ,gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com Cc: gcc-patches@gcc.gnu.org Subject: Re: MIPS Fix PR18141 References: Date: Wed, 21 Sep 2011 13:30:00 -0000 In-Reply-To: (Dinar Temirbulatov's message of "Wed, 21 Sep 2011 16:45:10 +0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-09/txt/msg01242.txt.bz2 Dinar Temirbulatov writes: > @@ -14696,7 +14696,11 @@ mips_avoid_hazard (rtx after, rtx insn, > clobber hi and lo. */ > if (*hilo_delay < 2 && reg_set_p (lo_reg, pattern)) > nops = 2 - *hilo_delay; > - else if (*delayed_reg != 0 && reg_referenced_p (*delayed_reg, pattern)) > + else if ((*delayed_reg != 0 && reg_referenced_p (*delayed_reg, pattern)) > + && !((GET_MODE (*delayed_reg) == DFmode && set_after != 0 > + && (set = single_set (insn)) != NULL_RTX && GET_MODE (SET_DEST(set)) == DFmode > + && XINT((XEXP (pattern, 1)), 1) == UNSPEC_LOAD_HIGH > + && XINT((XEXP (*set_after, 1)), 1) == UNSPEC_LOAD_LOW))) This isn't safe because the patterns might not be UNSPECs (so XINT (...) would be meaningless). It's better to check the insn code instead. Something like: else if (*delayed_reg != 0 && reg_referenced_p (*delayed_reg, pattern) && !(recog_memoized (insn) == CODE_FOR_load_highdf && recog_memoized (*set_after) == CODE_FOR_load_lowdf)) (untested). Note that *set_after should always be nonnull if *delayed_reg is. Looks good otherwise. Richard