public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Sandiford <richard.sandiford@linaro.org>
To: Richard Guenther <richard.guenther@gmail.com>
Cc: "H.J. Lu" <hjl.tools@gmail.com>,
	 "H.J. Lu" <hongjiu.lu@intel.com>,
	 gcc-patches@gcc.gnu.org
Subject: Re: RFC: PATCH: Remove 26 element limit in vector
Date: Thu, 31 Mar 2011 09:58:00 -0000	[thread overview]
Message-ID: <g4tyejmxwx.fsf@linaro.org> (raw)
In-Reply-To: <AANLkTin8nfN2vJjE3Vc+-FOcHkiDTHyuL2feFnwPi+9g@mail.gmail.com>	(Richard Guenther's message of "Thu, 31 Mar 2011 10:41:07 +0200")

Richard Guenther <richard.guenther@gmail.com> writes:
> On Wed, Mar 30, 2011 at 8:09 PM, H.J. Lu <hongjiu.lu@intel.com> wrote:
>> On Wed, Mar 30, 2011 at 08:02:38AM -0700, H.J. Lu wrote:
>>> Hi,
>>>
>>> Currently, we limit XVECEXP to 26 elements in machine description
>>> since we use letters 'a' to 'z' to encode them.  I don't see any
>>> reason why we can't go beyond 'z'.  This patch removes this restriction.
>>> Any comments?
>>>
>>
>> That was wrong.  The problem is in vector elements.  This patch passes
>> bootstrap.  Any comments?
>
> Do you really need it?

ISTR at least two separate projects have hit the limit.  This solution
seems very hackish though (as well as being ASCII-specific).  A better
fix might be to replace "char" with a proper type, such as a union and
discriminator.

Richard

  reply	other threads:[~2011-03-31  9:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-30 15:05 RFC: PATCH: Remove 26 element limit in XVECEXP H.J. Lu
2011-03-30 18:55 ` RFC: PATCH: Remove 26 element limit in vector H.J. Lu
2011-03-31  8:47   ` Richard Guenther
2011-03-31  9:58     ` Richard Sandiford [this message]
2011-03-31 10:20     ` Mike Stump
2011-03-31 12:14       ` Kenneth Zadeck
2011-04-05  1:05         ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=g4tyejmxwx.fsf@linaro.org \
    --to=richard.sandiford@linaro.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hjl.tools@gmail.com \
    --cc=hongjiu.lu@intel.com \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).