From: Andrea Corallo <andrea.corallo@arm.com>
To: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Richard Earnshaw <Richard.Earnshaw@arm.com>, nd <nd@arm.com>
Subject: Re: [PATCH 4/x] arm: Add vst1_bf16 + vst1q_bf16 intrinsics
Date: Tue, 03 Nov 2020 12:00:50 +0100 [thread overview]
Message-ID: <gkr5z6mln6l.fsf@arm.com> (raw)
In-Reply-To: <DB7PR08MB30020F982102F2F7EAA1E54993110@DB7PR08MB3002.eurprd08.prod.outlook.com> (Kyrylo Tkachov's message of "Tue, 3 Nov 2020 10:31:24 +0000")
Kyrylo Tkachov <Kyrylo.Tkachov@arm.com> writes:
[...]
> I see this patch also has the hunk:
> diff --git a/gcc/config/arm/arm-builtins.c b/gcc/config/arm/arm-builtins.c
> index 33e8015b140..6dc5df93216 100644
> --- a/gcc/config/arm/arm-builtins.c
> +++ b/gcc/config/arm/arm-builtins.c
> @@ -946,6 +946,9 @@ typedef struct {
> #define VAR13(T, N, A, B, C, D, E, F, G, H, I, J, K, L, M) \
> VAR12 (T, N, A, B, C, D, E, F, G, H, I, J, K, L) \
> VAR1 (T, N, M)
> +#define VAR14(T, N, A, B, C, D, E, F, G, H, I, J, K, L, M, O) \
> + VAR13 (T, N, A, B, C, D, E, F, G, H, I, J, K, L, M) \
> + VAR1 (T, N, O)
>
> /* The builtin data can be found in arm_neon_builtins.def, arm_vfp_builtins.def
> and arm_acle_builtins.def. The entries in arm_neon_builtins.def require
>
> That is a duplicate from a previous patch in the series and doesn't appear in the ChangeLog here.
> I think it's in here by mistake?
> Otherwise ok.
> Thanks,
> Kyrill
Hi Kyrill,
thanks for reviewing this.
Unless I'm wrong I see this hunk present in 3/x but not in 4/x.
Andrea
next prev parent reply other threads:[~2020-11-03 11:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 9:01 Andrea Corallo
2020-11-03 10:31 ` Kyrylo Tkachov
2020-11-03 11:00 ` Andrea Corallo [this message]
2020-11-03 11:14 ` Kyrylo Tkachov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gkr5z6mln6l.fsf@arm.com \
--to=andrea.corallo@arm.com \
--cc=Kyrylo.Tkachov@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).