From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2071.outbound.protection.outlook.com [40.107.21.71]) by sourceware.org (Postfix) with ESMTPS id 6DCD2385780D for ; Fri, 27 Nov 2020 10:32:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6DCD2385780D Received: from DU2PR04CA0059.eurprd04.prod.outlook.com (2603:10a6:10:234::34) by VI1PR0801MB1661.eurprd08.prod.outlook.com (2603:10a6:800:56::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.23; Fri, 27 Nov 2020 10:32:00 +0000 Received: from DB5EUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:234:cafe::28) by DU2PR04CA0059.outlook.office365.com (2603:10a6:10:234::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.22 via Frontend Transport; Fri, 27 Nov 2020 10:32:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT015.mail.protection.outlook.com (10.152.20.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.26 via Frontend Transport; Fri, 27 Nov 2020 10:31:59 +0000 Received: ("Tessian outbound 39167997cde8:v71"); Fri, 27 Nov 2020 10:31:59 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 5534c8d1aee1cd75 X-CR-MTA-TID: 64aa7808 Received: from 7c65a417388a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 12B2DE1B-0C9A-45F0-907B-0AC772D53E4D.1; Fri, 27 Nov 2020 10:31:54 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7c65a417388a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 27 Nov 2020 10:31:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FC/Z2v4LnToBA9i8s6vTkRv42/BMGJnH+qQIcnS8mA8PrGFb+VKra42V4QSxFLYn0hNS69bsBv6bfJKfhHP1dCQwEvUXSQnKiRUqU8ulb8W6XoZEAkbMJqKsgXM5LPZA2nHZVRjLFZ9Tfx6Di/Wj+eigQGLgGzK1TxCcLf2o92u883RAPTz1IEoojbttAvasQLr5firB9WSmyN1T9HCU//DmvByBpoVT9ZRAXmYHB36XZvB8sn9Do/uZ7dKzwCK1c329jxtk8fFwp0wCY+Q49kJZuG/0u2kK6ShDUMsvJP7QHw9tUwZrnEb2qdrt61PcYWRltGp4wKFZ8CDyEBTM9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MXQev21zREm7xcby9bctY+kqSXTl/774BgwIjlCKPp8=; b=A9WHNWB5YKlixpzXW/aFeFGZNi3yqtdaijVV1zNYyo4axbeZneSj7R4QMNuPB+MNlAuCiy/x+lePzDL3olpRp0wxhnogjCopldhqKrxmIiujIpRBiYApgwbl1AZkCNg8PjRCLB7NAT6WoS1fZQo1jT6jEcpKDXgOngOBsM0lwwMXZPsTSCit8OCkGaYLQmwxP6yeIbdGefPaLpUxBU/Ytcx88ewv91vWVLyoYmoEZzUKPxLXQB+D1sOF63ffwKM6j0YiEQo3YcdEEEZ9/fW8fNct6k1WNDEvr8MWUgJs0vsjyhYWNxRGqL8Mn5R2mCNXxwfSHsIr56M+lXkp8WfE+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AM6PR08MB4900.eurprd08.prod.outlook.com (2603:10a6:20b:cc::10) by AS8PR08MB6279.eurprd08.prod.outlook.com (2603:10a6:20b:294::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.20; Fri, 27 Nov 2020 10:31:53 +0000 Received: from AM6PR08MB4900.eurprd08.prod.outlook.com ([fe80::48cc:50a9:4261:4260]) by AM6PR08MB4900.eurprd08.prod.outlook.com ([fe80::48cc:50a9:4261:4260%7]) with mapi id 15.20.3589.029; Fri, 27 Nov 2020 10:31:53 +0000 From: Andrea Corallo To: Andrea Corallo via Gcc-patches Cc: "Richard Earnshaw (lists)" , nd Subject: Re: [PATCH] arm: [testsuite] fix lob tests for -mfloat-abi=hard References: <5f8151ec-ed6c-6beb-e06b-8d9587811be2@arm.com> Date: Fri, 27 Nov 2020 11:31:52 +0100 In-Reply-To: (Andrea Corallo via Gcc-patches's message of "Thu, 26 Nov 2020 17:48:16 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-Originating-IP: [217.140.106.37] X-ClientProxiedBy: LO4P123CA0067.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::18) To AM6PR08MB4900.eurprd08.prod.outlook.com (2603:10a6:20b:cc::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from e124257 (217.140.106.37) by LO4P123CA0067.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.20 via Frontend Transport; Fri, 27 Nov 2020 10:31:52 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: fecd833b-0d63-489d-dcc8-08d892bfac4a X-MS-TrafficTypeDiagnostic: AS8PR08MB6279:|VI1PR0801MB1661: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ucuoGllvsgTYNYblepU0pqGL7SxRxGHOyaSVZh/WX6ye5Cf5g117ob6i9KhAFRmaBS4tApqpNd//6JDce37ck2L1HK9peldDX75ytAXtVqndTWsDHBFMfd8ZNgCwnXFGn1uI77ggA+7FdWR0AMbl4FeWhCMkZXzm59zHTUL25qc8FOA5/IWuaxWovStEJ2LQ1eb16VVqUuUV07FnQxldEcUkYFSWPte8VBuGWJygy2Oq7ZC8bqmfvGie3uxYBNTSj71n0L+FrVW+IEAw8zsFZTyls5w0FRa4qxPJ2gU+t9dvRwBh1m0/jtUBFMzvZR8GaueKUIZxy1czUZzTzasvaxRKMTVzIyBDjrM9YtBrQ+sHQ4WIbT5x8Is06YVayKHf7b1aEW3lJAHJUW8SYJkTWQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR08MB4900.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(376002)(136003)(396003)(346002)(366004)(66476007)(66946007)(2906002)(66556008)(478600001)(36756003)(6496006)(26005)(52116002)(6916009)(186003)(966005)(53546011)(4326008)(5660300002)(6486002)(86362001)(2616005)(956004)(316002)(83380400001)(44832011)(8676002)(16526019)(54906003)(8936002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?79Tl8Zml2ptcQh//E/LMgTImXk30WuWMfqrAoG8Rvr/CdjizCmsUkX2uyxYZ?= =?us-ascii?Q?Mp/Wd0tMIXKKxucva4bmBtO+UGZIDMC0sJJh+ivoxP1WoY5aDEPmqqBpVYjs?= =?us-ascii?Q?3dQyYargEJio6xvzjUJKIJKEooBD6lSiVWrFshb3/zZXvpybfz8jFnFH6np2?= =?us-ascii?Q?L0h7G/xpyyRXXCbmxJtJHMh/0C9tKnT0fqaQghdrDpe41Av6WqpSooUyKO7A?= =?us-ascii?Q?LKovA0BFY7Ew4pkUebIH1/q8SueVW02fG0JUlBF8I4YmvSN5ToLzWeCo0WIm?= =?us-ascii?Q?elNl4IsU2ERcN70Sq+knJZkeGtvtJY01JTdxl1ehubfbBO2PnEyJ49ZuNHBe?= =?us-ascii?Q?TSlWpg2lEs2hsYJ6i4Pit3UE07gr5IN0IBIRXUxxIbNDDnFGLdGCwVaMFStL?= =?us-ascii?Q?7QPOQ4XsJPXAQOqxmO5c7M4WH3r11U0l91RZ2iz6/t0OVogGpVLTb0xGmJWB?= =?us-ascii?Q?tsSbXN+9kUTPLwAYMKrBcwi5dcBYxVgjDRlGxZxoKbSo4tXW9jLxltyMfaG1?= =?us-ascii?Q?Lt01YY3/WW8Q4YEcIWUd6aXY2rhUxC0kX6LsUFr6jzq+MB14QNlajYg2qMdI?= =?us-ascii?Q?7Tun9S5hoZ0h5yhl6T48ei4uhJKXvYLb7F3O4pbCb7WMQJGSi/A+T3wBwR+k?= =?us-ascii?Q?yfwCVOqvSHs2mpsSalWA7rzz5qgfCQnfxArvuIl6bvBDExh3x63+Ate20mFg?= =?us-ascii?Q?bTi9aXMH4f0tU0TTvnOaEKOoRP8K3ntNuC+Fp1y1p8GkHBPGc8GVG8mHPz6D?= =?us-ascii?Q?sP8bepe6gesrmptywyfgnjCtCwodwNS/e5g3kbiEVHKM+Dk65zzD0pBA32kN?= =?us-ascii?Q?usSV3IaehgNRpZlnjPC61V96w+4Y3w9m8DbceZEN3hxrsKp5QkFvn4HHiucm?= =?us-ascii?Q?0Mdhm9vG01CaJQigqEefHjWB0HwLytDo3RiKFjXeZLiKTEZhHV9CTnyCkVkL?= =?us-ascii?Q?/816pBtqTIqvRwGmJ4Qh/OvexaEA+rKQnOtWbc+ogoenrGUtDGWXLp1It1pF?= =?us-ascii?Q?8jW+?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6279 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: e3b4f6a7-1f3a-49fc-7845-08d892bfa817 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oO8IbkfcSBW26OaSZ7po4xXZ3OtmGcFOmp//x8l6p9pRSO6jEKLCt7OUcLB/VCJFBtWUGe9ig7dyyICLbnjWalG3hr6lBvK69/T7NhsUy8wga0iuAv4+NtJ5udI3NePFPPXpBZFkKC457LUxDPYwupyDKpEaZ9tbBvOuXhyhAP2bny3RBwyGtG4HFUBr9dMUZeB3Ky8YA7p3WvelLw6XKkSXgq4VH1kK0PVs1xeRHtqGw4bNGYK/wEFMt06n5jNl1f80giH8ExmstCMJe4yG1WXQfB+eFOjJCuHzdVeKZ0zkJg5lxETJ+c0Czhit7SWUPdx0rndWWlu+P6vRx657kScwhIg14jNmUPP9Z7pRcmbxMLSpDfY9Fx/s0kYu7s9CsxWYzbyHi/UeneSvY+ytFrkqHMiYnnglekuo3Jf/KzZs5bdJEpv6n5u2iPR1k1CUBzf5OfaL0yyQkayVM7zCXeR07N3Du9+arkqds6Ycn0I= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(136003)(376002)(346002)(39860400002)(396003)(46966005)(70586007)(82740400003)(54906003)(26005)(70206006)(4326008)(2906002)(81166007)(356005)(186003)(16526019)(53546011)(966005)(47076004)(336012)(8676002)(8936002)(316002)(6916009)(82310400003)(6496006)(44832011)(2616005)(6486002)(956004)(86362001)(83380400001)(478600001)(5660300002)(36756003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2020 10:31:59.9841 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fecd833b-0d63-489d-dcc8-08d892bfac4a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1661 X-Spam-Status: No, score=-14.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, KAM_SHORT, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2020 10:32:05 -0000 Andrea Corallo via Gcc-patches writes: > "Richard Earnshaw (lists)" writes: > >> On 26/11/2020 13:53, Andrea Corallo via Gcc-patches wrote: >>> Hi all, >>> >>> I'd like to submit the following simple patch to clean some Low Loop >>> Overhead test failing on hard float configurations. >>> >>> lob2.c and lob5.c are failing with: "'-mfloat-abi=hard': selected >>> processor lacks an FPU". >>> >>> lob3.c and lob5.c got "-mfloat-abi=soft and -mfloat-abi=hard may not >>> be used together". >>> >>> Okay for trunk? >>> >>> Thanks >>> Andrea >>> >>> >> >> I think it would be better to try to do this with suitable >> require-effective-target rules (or something similar). Forcing options >> should generally be a last resort and in particular using -mfpu should >> really be avoided as we're trying to move away from that. >> >> diff --git a/gcc/testsuite/gcc.target/arm/lob4.c >> b/gcc/testsuite/gcc.target/arm/lob4.c >> ... >> -/* { dg-skip-if "avoid conflicting multilib options" { *-*-* } { >> "-marm" "-mcpu=*" } } */ >> +/* { dg-skip-if "avoid conflicting multilib options" { *-*-* } { >> "-marm" "-mcpu=*" "-mfloat-abi=hard" } } */ >> /* { dg-options "-march=armv8.1-m.main -mthumb -O3 --save-temps >> -mfloat-abi=soft" } */ >> /* { dg-require-effective-target arm_softfloat } */ >> >> Why is the effective target arm_softfloat not solving this particular >> conflict? > > Good point, > > I see is because we are defining __SOFTFP__ when compiling with > '-march=armv8.1-m.main+mve -mfloat-abi=hard'. > > This sounds like a bug to me, correct? Hi Richard, diving into it further I've been explained by a knowledgeable colleague that '__SOFTFP__' indicates the use of emulated FP operations but says nothing about the ABI, indeed this last is what we want to check here to avoid the conflict. OTOH our selector 'arm_softfloat' IIUC is claimed to select the ABI [1] "ARM target uses the soft-float ABI with no floating-point instructions used whatsoever (as selected with -mfloat-abi=soft). " but is looking at '__SOFTFP__'. What should be the right fix then? Should we leave the skip "-mfloat-abi=hard" into the patch and update the doc of the selector? Thanks Andrea [1] https://gcc.gnu.org/onlinedocs/gccint/Effective-Target-Keywords.html