From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101905 invoked by alias); 5 Oct 2019 09:07:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 101639 invoked by uid 89); 5 Oct 2019 09:07:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=H*f:sk:29ab608, H*f:sk:gkrlfu6, H*f:sk:b73a46c, Bests X-HELO: EUR02-AM5-obe.outbound.protection.outlook.com Received: from mail-eopbgr00080.outbound.protection.outlook.com (HELO EUR02-AM5-obe.outbound.protection.outlook.com) (40.107.0.80) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 05 Oct 2019 09:07:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=36zSL0HLg1VG/rlLQpbbX+dGGjgSvxfn8Fu7B3uEmzQ=; b=jsj99VyWJ7yYHueNVsbFhKjP1Oohq2+abtD0t/Pq4AWVxBdVv2gZdJIq+z2xOxkbxwgC6fo3UtBR6svQBOqa0Z6A4dRMrs79ulrAUbOPzC5BV0P9DPs6ukOtEtwS1H4D4tXwnc+anoNMm+MRuHjopJ83QU8TeX+dKC2vF2aVhPU= Received: from VI1PR08CA0157.eurprd08.prod.outlook.com (2603:10a6:800:d1::11) by AM6PR08MB5255.eurprd08.prod.outlook.com (2603:10a6:20b:ef::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.20; Sat, 5 Oct 2019 09:06:58 +0000 Received: from AM5EUR03FT023.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::208) by VI1PR08CA0157.outlook.office365.com (2603:10a6:800:d1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2327.23 via Frontend Transport; Sat, 5 Oct 2019 09:06:58 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=none action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT023.mail.protection.outlook.com (10.152.16.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2305.15 via Frontend Transport; Sat, 5 Oct 2019 09:06:57 +0000 Received: ("Tessian outbound 927f2cdd66cc:v33"); Sat, 05 Oct 2019 09:06:54 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 51af1b8e7e0ef52c X-CR-MTA-TID: 64aa7808 Received: from b93c334f8aa7.2 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.14.55]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id FD0675BB-99AE-4C33-8EF9-8A008BB71DA5.1; Sat, 05 Oct 2019 09:06:49 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b93c334f8aa7.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sat, 05 Oct 2019 09:06:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UyAl61D8blblNr2z6XoURNinBPbsoetT7teeedm8jfv/DT3r2TOjx0/wrce1zar/lOrmjRsl4N3CE85ZNNTv8eXZveMoMC57mP+kgq1wdKCv5HWmf09x9DC3Ioh9PGZbzyHHyyeRQQWa9EJxIzwpMNTQ2c4WV24iTIMxQALCqDkM9WDvfh1s8c/49CCy/jHI7HCK4J+f1CB5xEpgl65iY29ZDGWFhGNxQnunXreQUvk1eSNztkMuA9SjutIaJqfbFjukj+I8AM3NONJokHn7u+hteP4KCJgbw3CBYRSRpFjj6cIK1h70m6QNySkAcuKa7aJetaP88PilAHmZ0IaxQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=36zSL0HLg1VG/rlLQpbbX+dGGjgSvxfn8Fu7B3uEmzQ=; b=iZ2AY29jkUlB7j9gEptpVGooqSxZmeuNMk55BiBJFs679hPUqGulrXj7jcAmohkmvzTqA7iFQb/Pf+UAlQfYtp5RWxZzY5BEzp32ssReVwA0IjYHO3N2dfhbpYCCys7s/3X6ff2IQN/vEfj1vlxdP5IXlUICcV8LCfAQdBuEgIIkeSegJCYhHKAsDF6FejJM3ROIstvwdr69wrqYVxhV8bNJHNtoYmKZ4qNO7apzB/VV8GwS4jClbydPZqkixMBUpf075B9YSmYh1YFPPW2wKzsNDGnEX2cixc33tiuIL5K/BfEiwE1sqeghR4h840hIadCUnBcixmMmtZhHeOMx4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=36zSL0HLg1VG/rlLQpbbX+dGGjgSvxfn8Fu7B3uEmzQ=; b=jsj99VyWJ7yYHueNVsbFhKjP1Oohq2+abtD0t/Pq4AWVxBdVv2gZdJIq+z2xOxkbxwgC6fo3UtBR6svQBOqa0Z6A4dRMrs79ulrAUbOPzC5BV0P9DPs6ukOtEtwS1H4D4tXwnc+anoNMm+MRuHjopJ83QU8TeX+dKC2vF2aVhPU= Received: from VE1PR08MB5070.eurprd08.prod.outlook.com (20.179.31.87) by VE1PR08MB5261.eurprd08.prod.outlook.com (20.179.31.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.17; Sat, 5 Oct 2019 09:06:48 +0000 Received: from VE1PR08MB5070.eurprd08.prod.outlook.com ([fe80::a4a2:8364:f02c:a63]) by VE1PR08MB5070.eurprd08.prod.outlook.com ([fe80::a4a2:8364:f02c:a63%6]) with mapi id 15.20.2305.023; Sat, 5 Oct 2019 09:06:47 +0000 From: Andrea Corallo To: Jeff Law CC: Andrea Corallo , Martin Jambor , "gcc-patches@gcc.gnu.org" , "jit@gcc.gnu.org" , nd , Jan Hubicka , Jan Hubicka Subject: Re: [PATCH] IPA-CP release transformation summary (PR jit/91928) Date: Sat, 05 Oct 2019 09:07:00 -0000 Message-ID: References: <29ab6082-a8d7-7471-ff99-3472a28eb84e@redhat.com> In-Reply-To: Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Andrea.Corallo@arm.com; x-ms-exchange-transport-forked: True x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(136003)(366004)(346002)(376002)(396003)(39860400002)(54534003)(53754006)(199004)(189003)(316002)(305945005)(54906003)(81166006)(256004)(66066001)(25786009)(446003)(11346002)(99286004)(71190400001)(2906002)(6486002)(8676002)(86362001)(6246003)(76176011)(14454004)(5660300002)(6506007)(66946007)(386003)(6436002)(66446008)(64756008)(66556008)(66476007)(36756003)(44832011)(71200400001)(476003)(102836004)(2616005)(52116002)(229853002)(186003)(486006)(3846002)(6116002)(26005)(4326008)(6916009)(14444005)(53546011)(8936002)(7736002)(6512007)(478600001)(81156014);DIR:OUT;SFP:1101;SCL:1;SRVR:VE1PR08MB5261;H:VE1PR08MB5070.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: wCimHXzngJ86psaJe0fRii0iZf0H+5d8J8wg/iYgjMY+EKUURA0Nbls9W3ljrE1ZShFLyWZ4MwkwpzAaz0bJJO1/GQRjSza6fAf2X++6CcMnvKXKdPxUSjfW2FXlkhkwWUR+uZ8qasqVBAWqqWDK9EMOgXlNj54TnPHu/46qIJnCmmQmwAnYbBVgTKC//pzIcIJNxwjX1cybvRaasmuBxzb/T8lzDZ1sdAAx9Yy/qcCPX0Kix8rtjYYfDBR6zW3FJu4/n0lA3kaQcAEYqQpsRYlhOoyoQ4X4dEzh1iLZC0Au6M+z1QVEEnqOkT2eQ6LsXXz8Xg1Dos3gJRd3AnfZAtuNyIUkpYKP42zeyRw69tFRUq+Cvotv2r0zoxeC5nrvyU/wYW6otxuzKJg42+81MOdumiN6gnJpGCMxzSvBbWM= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Andrea.Corallo@arm.com; Return-Path: Andrea.Corallo@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: b386d9b8-72a0-49ef-1f31-08d7497359ec X-SW-Source: 2019-10/txt/msg00411.txt.bz2 Jeff Law writes: > On 10/3/19 6:47 AM, Andrea Corallo wrote: >> >> Jeff Law writes: >> >>> On 10/1/19 4:11 AM, Andrea Corallo wrote: >>>> Martin Jambor writes: >>>> >>>>> Hi, >>>>> >>>>> On Mon, Sep 30 2019, Andrea Corallo wrote: >>>>>> Hi all, >>>>>> I'd like to submit this patch. >>>>>> It release the ipa cp transformation summary after functions being e= xpanded. >>>>>> This is to fix the compiler when used with libgccjit on subsequent >>>>>> compilations (every new compilation should have a clean transformati= on >>>>>> summary). >>>>> if this is a general problem then I think we should instead add anoth= er >>>>> hook to class ipa_opt_pass_d to free transformation summary, call it = for >>>>> all IPA passes at the appropriate time and implement it for IPA-CP. T= hat >>>>> way it will work for all IPA passes which might have a transformation >>>>> summary. >>>>> >>>>> Martin >>>>> >>>>> >>>>>> Bootstrap on arm64 and X86-64. >>>>>> >>>>>> Bests >>>>>> Andrea >>>>>> >>>>>> gcc/ChangeLog >>>>>> 2019-??-?? Andrea Corallo >>>>>> >>>>>> * cgraphunit.c (expand_all_functions): Release ipcp_transformation_= sum >>>>>> when finished. >>>>>> * ipa-prop.c (ipcp_free_transformation_sum): New function. >>>>>> * ipa-prop.h (ipcp_free_transformation_sum): Add declaration. >>>> Hi, >>>> actually looking around in order to implement the suggestions I realiz= ed >>>> that already some code was put in place in toplev::finalize calling >>>> then ipa_cp_c_finalize exactly for this purpose. >>>> >>>> I've updated the patch accordingly. >>>> >>>> Bootstraped on aarch64. >>>> >>>> Is it okay for trunk? >>>> >>>> Bests >>>> Andrea >>>> >>>> gcc/ChangeLog >>>> 2019-??-?? Andrea Corallo >>>> >>>> * ipa-cp.c (ipa_cp_c_finalize): Release ipcp_transformation_sum. >>>> * ipa-prop.c (ipcp_free_transformation_sum): New function. >>>> * ipa-prop.h (ipcp_free_transformation_sum): Add declaration. >>> OK for the trunk. >>> >>> jeff >> >> Applied as r276507. >> >> The same patch applies cleanly onto gcc-9-branch, I think would be good = to >> back port it cause libgccjit is not very usable without. >> Should we back port it? > It's a bit out of the scope of what we usually backport, but I think > this is a reasonable exception. So, yea, if you want, go ahead. > > Thanks > jeff Thanks, committed as r276625. Bests Andrea