From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30084.outbound.protection.outlook.com [40.107.3.84]) by sourceware.org (Postfix) with ESMTPS id D8E213857001 for ; Mon, 8 Aug 2022 09:33:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D8E213857001 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Qd/hElLRicS0YrJyKM6X7VzEmtpIAvIbVHkhHi4E5Yk11QriAjr0FIsV+xfjIznVkAcLZ3OfXlzyq/UrXXxL0nRAL00jEh6bz8CHLm8AgM/xXIYP1s3eJgpZiun2a2640yNEcBwKMyvXFR7TlWERvZurDwwSywWPx6ZwTLQRwAAFcuL0P7bUlRB5awXltd0t9lb8zYFEd8tKXc9l79Sgs/z5hlK72VX/3wX6u+WTxRzBdDCKYboqY6SG99GqK4xnlYygfAyJQDy+Iw/yWb2UN4i6RP5Y3+l6Y6q/W0YufgrKuiYlQzwzvasHUFZffDlcfo6np7KPXgE2SGEp9AmvUA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rYAtpbz6n3+JEhd9g6rTfy4b9UdjzapxJ5L3hwtEuDg=; b=gDUgqtOAsOWfbSg2MjGuwqFTWQI25xbUdL83UtThR+e9liGQrNvpKhcK5HPD9YPA9LbcJmlUEef3zjczTXLJu/f4Pt8SxvAZ7TZdXFit3drOGuW4yIbfuJNBNzy7gRQuoxf9g0rL8w4JHc/S1xZHlhV90TADprdRAQI0T1Z2vC4gqpJShAihTaZENGatmBfJlB9xsFxvtavAwaOgNAojzCQv+Vfp/+euW8AwMxypjd/QfYl4PsVZmy+qltlW9d10M504WrgdqSW/eIrapPAkv4sB3OtUBtCNLUKZKD3VSk2ptttZlqF2U8dZiurkzaXjZLwPtYr6Ymw0z/rqlN9ceA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from DB8PR03CA0023.eurprd03.prod.outlook.com (2603:10a6:10:be::36) by AS8PR08MB5975.eurprd08.prod.outlook.com (2603:10a6:20b:297::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Mon, 8 Aug 2022 09:33:53 +0000 Received: from DBAEUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:be:cafe::e5) by DB8PR03CA0023.outlook.office365.com (2603:10a6:10:be::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.20 via Frontend Transport; Mon, 8 Aug 2022 09:33:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT047.mail.protection.outlook.com (100.127.143.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.16 via Frontend Transport; Mon, 8 Aug 2022 09:33:53 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Mon, 08 Aug 2022 09:33:53 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 7c174eab55d2944a X-CR-MTA-TID: 64aa7808 Received: from 900939f4b126.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 001AF32D-D027-4918-8B82-7C52A7F2ACBA.1; Mon, 08 Aug 2022 09:33:46 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 900939f4b126.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 08 Aug 2022 09:33:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fb8rq9+M8urjpdajD1yO3fI/5libn6fzvPZMERWGWv1Xc0olCNjHk1KGddD+AjySTNWPZ3Q3h7PaNGrnCDAnttBnuR9uCpDsZf2l1ArXXeCTf2e7Svkq9mn5kjPOWn0lxfI+UUbLDZd7tezJ3EgJKnK2fHBa6aqGp+o3zVg8VFfkzBo5T67yIB3v7rJ0dRQU6I/ODqdZFNMwNj8CvE774fw4heEK0d1nhwsB4vH1ufGK/ZrkhN+nDRB6yjSkd6gupAfsNAG+t8Hw3p1lCzsPHrCj/IbqTP2A/6H0fKxhaZx5rCiQjQDjJ8tiEDxZMGigN+5YEVYcE0k2i1NtQgis7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rYAtpbz6n3+JEhd9g6rTfy4b9UdjzapxJ5L3hwtEuDg=; b=ErLHd81fZSqnOD3GY6yXllTYgJKz+dG9RKaSoHumYo0XGm6lJUmQCt/nfG5vGeK+32fVL4UNwN1rgqiGg+Q76+l7h8DHWuXIUDn7JBqqe8W8TQXPPSDofB83hO6IG2rpkc4qQ4Lrq8pLiTh6eBj+25mTopbMeg5WiVThflZFTLSMT1J2qbfU+1ZW5T6oGM0KG0MoP8DmzN9NOUvAWuIIbVYhWckBvfYPslsPSJ3OsGorlCiwn/sQQqtgNi43XYmt630i2ql7ezEwfCMhf6BIHn5UXnON+VatU+het/Fiya/pOSa05ndu+dxRK++o9AQYcsdkXk+o7PR0RBjFqoMx4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none Received: from AS8PR04CA0069.eurprd04.prod.outlook.com (2603:10a6:20b:313::14) by VI1PR0802MB2493.eurprd08.prod.outlook.com (2603:10a6:800:b3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Mon, 8 Aug 2022 09:33:44 +0000 Received: from AM5EUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:313:cafe::5) by AS8PR04CA0069.outlook.office365.com (2603:10a6:20b:313::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.20 via Frontend Transport; Mon, 8 Aug 2022 09:33:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT028.mail.protection.outlook.com (10.152.16.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5504.16 via Frontend Transport; Mon, 8 Aug 2022 09:33:43 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2507.9; Mon, 8 Aug 2022 09:33:42 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.9; Mon, 8 Aug 2022 09:33:42 +0000 Received: from e124257 (10.34.105.24) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9 via Frontend Transport; Mon, 8 Aug 2022 09:33:41 +0000 From: Andrea Corallo To: Richard Earnshaw CC: Andrea Corallo via Gcc-patches , "Richard Earnshaw" , nd Subject: Re: [PATCH 10/12 V2] arm: Implement cortex-M return signing address codegen References: Date: Mon, 8 Aug 2022 11:33:41 +0200 In-Reply-To: (Richard Earnshaw's message of "Fri, 1 Jul 2022 16:43:47 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 301b2887-0ea1-4f5f-0b54-08da79211bd7 X-MS-TrafficTypeDiagnostic: VI1PR0802MB2493:EE_|DBAEUR03FT047:EE_|AS8PR08MB5975:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: KGUeCJ0WWz33gNGnNjvSyIzcp+yLk9p5Ph3tbF46bxn3k4p/nzykoNZDoLwmcvN+TcXGvlsVFEGKNtxiuABkyrHIzodLr5NeHs9sXOJYBDu9xh6qtrQdoDCW/BQRgNqba+IzEZICmLqr0VKyQ72aUqifBqkUMBFusiVv6s4MBtMviOzMUayC67elNW88+Zx5QKz1u+wc2lxzzn6zxdDgNkvfD8ys28hA56hDUpMOna/lpz0D7GS6PXze4g5nYzihrlSjQA8/1tenAHprvG2Hf2dkBuBaow7rmRGXpwnLWKGyNNsVat61uCUmTvV56MHCCXevBiOSqF1VJ11T0MDCTiPfYtCdoxKrjZc9SmJrSurUlLPk85yIy/Y4eKAM9zVs3VUyodeoTiLmIitybRoC5ujYMwZNx92XupCmoKZJJZ95IDclDMDnDk5GHow+KAF3WxfleBxEBzOQ1QTN+WKxOBuReykdAlBJS5NGJupbddJ2vuGwIJwRBI3Q5FIpQLVUy62OTZRlOoQ8CRmIK5ei7qXoJAdiGb5bOXHR5+lpazSdxoaPSE/SsYB2XPWeOhc5EgQ0c9IneGQIEUMA0//LnpalwlYNBv6McEKiPSOnvMWVAuBjlh2g1z7/e4++ghkmoOLEhivAXj9/r5EidtmyRTBThwyLiFhWpQX8zMC+5tN+nc8Tu7UB6ZRo7ZrZ9fVKHnCSuqlFnbvz7iY/mi/foiRc8SHcvzfzDJaCr5GZJj9dMyFWMdQzdaJ3m6nNt2L0qDIylvfdMBMwAkzT+squ2KxBDfZN0sfbDa0fHZleTg+SK0I/pgxPi9/ZfLvfRH9cPe+l0EPdD/1TQjKp3ojzrQ== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230016)(4636009)(346002)(39850400004)(396003)(136003)(376002)(46966006)(40470700004)(36840700001)(4744005)(356005)(41300700001)(81166007)(44832011)(2906002)(82740400003)(336012)(36860700001)(47076005)(426003)(40480700001)(186003)(26005)(2616005)(82310400005)(83380400001)(316002)(54906003)(36756003)(4326008)(8676002)(70206006)(70586007)(40460700003)(86362001)(6862004)(5660300002)(478600001)(8936002)(36900700001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2493 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f105e5ac-3b20-45e3-7d9e-08da792115f8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zvNjulMa3wzuaE3u8qEGQigf+ofapJQmSVklqB7/C8WzLbnKJyhBeTzpNVSFBw4EknkxHavkCJgcba2yx+d9Oatd8BiE+clPaA/cRQIpwAD8EhqRQjj9QJlNwK4WSYLGX4izX9fggmpvneKGXJrbqIdaOCB0slly1Er9TNxPxM7bmkSaNWAuB620Pq9fXuLCZsNwNbsLV2Rd0xbcz6WG5qY1tqH0xZiFkquiLgFSh44JYexDojmstK/eNGheFV3j5udcMMsmpVTid2A5nTiV+nC2TloR5e7P9qrSC9Qmda0wL80GuIa5QiykgnPzSIkHSG1YA2b71s0BQS7JG7UjGrfK40xAPbusbhWAQPXNwfARB0bH2VONdCEovtS37R9DHheli5EaF5AYdGKNf6wJEu1APInXbfativEoXVg4priyoO00iut3yEjaTmcxYfvBllBIe4/WSE8ImNz60yFrjkGnsP+s51+ZkKaUaQXoHgkTwYQnXgCjsJsWvUMvwYLAwgwl0+ZigcYjlZmoTLNtf6s/bftShEJk1jbTNfhTXdQXEKD4g/z0IQsmZxavpJBcc2Ott2wf0J2tgEogL6odtrQnDZRZUBx/dF3tflhWQ3RMZXW9Vuvu1UtXUQoTBQiAtWfDjTTtPrTMrbgQ2LV6xWB6Nkd05a1GiZO062p9JxwoQbcngSfKIn2ZMCskr4tSSH2HNqhNzFumrPv2xJhtTDo82FAm8XFaE8Bm6pWW1qKf7RZDxk+0+HK1piOkMnSbf1ZGluja527OWgDoZanFjg+HJZmUFxECtBZcWfwJUz8bO5EMsOmdCk5cqHgKWDqQ X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(346002)(136003)(376002)(396003)(39860400002)(36840700001)(40470700004)(46966006)(54906003)(316002)(478600001)(41300700001)(2906002)(40460700003)(82310400005)(40480700001)(70586007)(70206006)(4326008)(8676002)(5660300002)(4744005)(44832011)(8936002)(6862004)(82740400003)(36860700001)(81166007)(36756003)(86362001)(47076005)(2616005)(186003)(426003)(336012)(26005)(83380400001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2022 09:33:53.4306 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 301b2887-0ea1-4f5f-0b54-08da79211bd7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5975 X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, KAM_DMARC_NONE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Aug 2022 09:34:00 -0000 Richard Earnshaw writes: [...] > +(define_insn "pac_nop" > + [(set (reg:SI IP_REGNUM) > + (unspec:SI [(reg:SI SP_REGNUM) (reg:SI LR_REGNUM)] > + UNSPEC_PAC_NOP))] > + "TARGET_THUMB2" > + "pac\t%|ip, %|lr, %|sp" > + [(set_attr "length" "2")]) > > This pattern is missing a type. Which type do you think is missing? > The length is also incorrect as the > instruction is 32-bits (4 bytes). Ack. > Similarly for the other > instructions below. Also, you need to mark them as incompatible with > conditional execution (they're constrained-unpredictable in IT > blocks). I guess this would translate in setting it with '(set_attr "predicable" "no")' But isn't this already the default? Thanks Andrea