From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30052.outbound.protection.outlook.com [40.107.3.52]) by sourceware.org (Postfix) with ESMTPS id E9F3F38708DA for ; Thu, 24 Sep 2020 15:20:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E9F3F38708DA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Andrea.Corallo@arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gLwH02jW0rb7ltRRtnTVR13P/auoeDKDC2h1rn4ava0=; b=ksYItepLwwh2NeBdejEe2Tf+c/phfqzBsKlhgGOge5GJawb7sqp3PjrHXGm2qhxwZ6xOQk7MfYSbWNOZxDU2GDPp6JBOERqmx4oVAATOVZO/eZjJCOTqymzVkPn9OAVvVXg/fjjy0krHMfWHRPgDewfJkeqWkL7vHIsY0CHoIOE= Received: from AM6P194CA0037.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::14) by VI1PR08MB3952.eurprd08.prod.outlook.com (2603:10a6:803:de::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.21; Thu, 24 Sep 2020 15:20:55 +0000 Received: from AM5EUR03FT020.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:84:cafe::f2) by AM6P194CA0037.outlook.office365.com (2603:10a6:209:84::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.20 via Frontend Transport; Thu, 24 Sep 2020 15:20:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT020.mail.protection.outlook.com (10.152.16.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.21 via Frontend Transport; Thu, 24 Sep 2020 15:20:54 +0000 Received: ("Tessian outbound 7a6fb63c1e64:v64"); Thu, 24 Sep 2020 15:20:54 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 5c5769b456a83b2f X-CR-MTA-TID: 64aa7808 Received: from c19b35298587.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 95E8FB69-A4D7-45A4-B5E7-2D17CD76F6AA.1; Thu, 24 Sep 2020 15:20:27 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c19b35298587.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 24 Sep 2020 15:20:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I6ibMdtp3sGa4svMy3hnFQNEY9zmVmVfT+qjPJlXtbP5ZegobR2gnEx6nEqjGAcF5gr9k/zCFcKtCg0S64U5kw+pLelu7wvrtCaiGhJYefO9Fncj/y/D07PJpgYa706V0ywBWs8f5oivsqhVocAmvaROtcHGHgvHr4msbaPIvix7pkz1IAgFMb9DWI8xxfor99s7IQhhMBzMq//JdEq2GuYe3889pWFm/OT02CG9mHsACycoaeIkXJ/Wdyo7vHev30q8OTStNyjgbHI3n5ZZAycM9psiv7mGZpyI70IXkYbuy3FBr+g8FvkSVT76aK7N5ElvXBgEOqkaenRYt7KOmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gLwH02jW0rb7ltRRtnTVR13P/auoeDKDC2h1rn4ava0=; b=k/4wCbUxw4+n7fuHGiaSlEHbyaHiRdoGOQsurLEUPvzoSe9Z6GcwpzNP83bw1V1QBxBS8BKyDM+PvaERvqxTL/zspMUzLF89/hFAoiAxbSnnh4POASQDtrTB0zzAhsrsIUv/KsYkd3nRNGTm/FI4g0zbVPMmal2v3lP3eU8HxH2lYxJGsr0BENFBMPczWP/omDYN6l02r4szBrCMVkDdg1MGkJQmeJ65t78ZTpO+hYOrWP2JftL2lF9QXrlAACEXaWkoCUvcLUmgIhSAL5gHwzgMmToJS+Efqo1v5ZHNlY7YcewXnSn/o1Ih9YGV/aW/MECNI2/gFh+VLouy/KdPIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gLwH02jW0rb7ltRRtnTVR13P/auoeDKDC2h1rn4ava0=; b=ksYItepLwwh2NeBdejEe2Tf+c/phfqzBsKlhgGOge5GJawb7sqp3PjrHXGm2qhxwZ6xOQk7MfYSbWNOZxDU2GDPp6JBOERqmx4oVAATOVZO/eZjJCOTqymzVkPn9OAVvVXg/fjjy0krHMfWHRPgDewfJkeqWkL7vHIsY0CHoIOE= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AM6PR08MB4900.eurprd08.prod.outlook.com (2603:10a6:20b:cc::10) by AM6PR08MB4263.eurprd08.prod.outlook.com (2603:10a6:20b:b7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.22; Thu, 24 Sep 2020 15:20:24 +0000 Received: from AM6PR08MB4900.eurprd08.prod.outlook.com ([fe80::b96e:941c:e829:3903]) by AM6PR08MB4900.eurprd08.prod.outlook.com ([fe80::b96e:941c:e829:3903%3]) with mapi id 15.20.3391.027; Thu, 24 Sep 2020 15:20:23 +0000 From: Andrea Corallo To: gcc-patches@gcc.gnu.org Cc: nd@arm.com, richard.earnshaw@arm.com, richard.sandiford@arm.com Subject: Re: [PATCH] aarch64: Do not alter force_reg returned rtx expanding pauth builtins References: Date: Thu, 24 Sep 2020 17:20:22 +0200 In-Reply-To: (Richard Sandiford's message of "Wed, 23 Sep 2020 11:33:41 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: LO3P123CA0009.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::14) To AM6PR08MB4900.eurprd08.prod.outlook.com (2603:10a6:20b:cc::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from e124257 (217.140.106.37) by LO3P123CA0009.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.22 via Frontend Transport; Thu, 24 Sep 2020 15:20:23 +0000 X-Originating-IP: [217.140.106.37] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b7ef52df-c3d5-4435-1db8-08d8609d6e3e X-MS-TrafficTypeDiagnostic: AM6PR08MB4263:|VI1PR08MB3952: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: iW8nNPJLvE6AWWc1H2itSCflNqzsQUJo3kUddW7Hv86R7ITm74q8nE2+0ObvGn9xN7EG6hcGgaWEm7oo2mzaQYf1dC5Ql6Ik6yVCh2GZwzkIgIEf3A5tur1IyoJ6V4OaQa+4mvQY0WtfKMW+QgkQrJPRQ4Ctx2WyOi6kGCbPhjR4nmd/Q41aBfAFqLqqrK0HjgHNLA38XON4GQnahTRVKo+1w6HKlv9pouX+msTC/KxuTOK1blHGG0bCwREh2OK8RI0K3BExwnWRRN0IBS8DzAtsp4aZxVX8Tb1XwJqp32EAnalNPFBmSBGRKFRAx8Yuw4zYY2lXTo2LGiEhc8uYrA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR08MB4900.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(39860400002)(136003)(346002)(376002)(396003)(4326008)(44832011)(16526019)(52116002)(66556008)(316002)(186003)(53546011)(66476007)(83380400001)(6496006)(86362001)(478600001)(2616005)(6486002)(2906002)(36756003)(956004)(66946007)(8676002)(26005)(5660300002)(6916009)(8936002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: C7L4Efyc5RjfRSgDOk3QkK6Z3JluE2iIkQzDOC9BuUkrP8QyJRQ6n7krY0jdZbk9rkjOCTe0w0KX/waRM57ZC6lawXpoWklzSIMrYqiEpUfsAFwtnov+9y/tN0i0WL6kSl1FF9jGMHl7tH+sv7OiQ0fbMi47P3YBg1UGJLJjo8p3OKFoukhXb8IZFtJg1lfLtaRk2VVOWHM9R3p0fIL/lPfvEx2MAyA/lWA7r5Qqfx0E5u3JO6HrZtgYFCMkjBIImxWQRn6uBvo5xb13dpgl7SJm+cEwHecNxqnWN6aLjYNRdbG4S7J9/KbzYEDH2QiXRY4jFjFFQ8rq/FKRAEEj5DcCZV/teqkOgmhobGZbxGNuO3t8w6wXu7TcY31viI9ezBe/ml7rT+ybJBZjNHr7wX2CJqkTOca4eZyNZO8wLF966hNUuhXqLIqiDq5ppV5FSjsV0fHWJxHFH+VKUTabOv/AXIwh6pVg7N4IN/1j3enLWIIenGE/93RpFPoegSZT3LxfZmJ3WRe9SaByNyZrFvqY+wUn4b05tEmkgvgMcq54TWSZ+gNZxUsWMb/8zFnsBZeR5/84gDtTgzFMbdj5QBeWY8gLQTVtWYqMO192Zv0H46IufX+6u03h/JwV+8iJiOoDTDYU5zJxnkO2UpQ9PA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4263 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 4be15b13-0cee-4a7e-f798-08d8609d5ba6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ycnOCRH782yHVefSujqmwa+SuaekpgsMoZ0G7qDlBO/Jw1VDN9U8qdWk+gAaeSJCAk+wzrAYoN881O8PyCzoo8Rp9c/aMJzcTUspSJ3390aQH2HGRuQc7Lt4PID4ug1rFhKsf9afjl52LdZN53wY+6uXMlhWfsK2kZ3TapW3LL43X7/Cp5AXt6C5yPQikAPPB1cNFYR4CYnTVy210s0h4tVeGsyKh9Nsku0zjxyfNad9BndeKfWomrhBa72lh1wyqP8b++kfv2tcBF20JybZRuTKD/W9lJXRx732pftai/GG4mkUjcFUejHHoSsKrdcJho4TUpTGzbjCsNTTfXS7gzQ0zS+3IZ+7uLPG60y4RkFqMxhmtnK8EPEoYY6QWwqjPz7MTaxQJsjlwJL3wuBTMw== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(39860400002)(346002)(376002)(136003)(396003)(46966005)(82310400003)(356005)(47076004)(82740400003)(36756003)(16526019)(8936002)(83380400001)(81166007)(86362001)(6916009)(44832011)(186003)(2906002)(2616005)(6486002)(316002)(6496006)(36906005)(478600001)(70586007)(70206006)(26005)(4326008)(336012)(5660300002)(956004)(8676002)(53546011); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2020 15:20:54.7802 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b7ef52df-c3d5-4435-1db8-08d8609d6e3e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3952 X-Spam-Status: No, score=-13.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Sep 2020 15:20:58 -0000 Hi Richard, thanks for reviewing Richard Sandiford writes: > Andrea Corallo writes: >> Hi all, >> >> having a look for force_reg returned rtx later on modified I've found >> this other case in `aarch64_general_expand_builtin` while expanding >> pointer authentication builtins. >> >> Regtested and bootsraped on aarch64-linux-gnu. >> >> Okay for trunk? >> >> Andrea >> >> From 8869ee04e3788fdec86aa7e5a13e2eb477091d0e Mon Sep 17 00:00:00 2001 >> From: Andrea Corallo >> Date: Mon, 21 Sep 2020 13:52:45 +0100 >> Subject: [PATCH] aarch64: Do not alter force_reg returned rtx expanding pauth >> builtins >> >> 2020-09-21 Andrea Corallo >> >> * config/aarch64/aarch64-builtins.c >> (aarch64_general_expand_builtin): Do not alter value on a >> force_reg returned rtx. >> --- >> gcc/config/aarch64/aarch64-builtins.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/gcc/config/aarch64/aarch64-builtins.c b/gcc/config/aarch64/aarch64-builtins.c >> index b787719cf5e..a77718ccfac 100644 >> --- a/gcc/config/aarch64/aarch64-builtins.c >> +++ b/gcc/config/aarch64/aarch64-builtins.c >> @@ -2079,10 +2079,10 @@ aarch64_general_expand_builtin (unsigned int fcode, tree exp, rtx target, >> arg0 = CALL_EXPR_ARG (exp, 0); >> op0 = force_reg (Pmode, expand_normal (arg0)); >> >> - if (!target) >> + if (!(target >> + && REG_P (target) >> + && GET_MODE (target) == Pmode)) >> target = gen_reg_rtx (Pmode); >> - else >> - target = force_reg (Pmode, target); >> >> emit_move_insn (target, op0); > > Do we actually use the result of this move? It looked like we always > use op0 rather than target (good) and overwrite target with a later move. > > If so, I think we should delete the move Good point agree. > and convert the later code to use expand_insn. I'm not sure I understand the suggestion right, xpaclri&friends patterns are written with hardcoded in/out regs, is the suggestion to just use like 'expand_insn (CODE_FOR_xpaclri, 0, NULL)' in place of GEN_FCN+emit_insn? Thanks! Andrea