From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2043.outbound.protection.outlook.com [40.107.22.43]) by sourceware.org (Postfix) with ESMTPS id 3A46F3858D39 for ; Wed, 8 Feb 2023 14:37:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A46F3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PYTn1crMQWqUIWETFqYxe+CggSSTsiDAJZJP1pNAwuE=; b=nrHX7nakXuT6QmaVF7DlOMSPIBBJKlFxvT7wxoKTMoXev8OHCOKigyDf8OvnUg3R9pv6d2wI9kWiCg84391Kk9Q+xI9FEsZ8j2v6zLc49hjcoxb+g5yPoWVW8jAMY3UNqgRFoYlOUtyF+3+Zh6nfbDlGwE/QAFIS9X7DZy5ocFE= Received: from DU2PR04CA0176.eurprd04.prod.outlook.com (2603:10a6:10:2b0::31) by AM9PR08MB6081.eurprd08.prod.outlook.com (2603:10a6:20b:2dd::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Wed, 8 Feb 2023 14:37:02 +0000 Received: from DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b0:cafe::88) by DU2PR04CA0176.outlook.office365.com (2603:10a6:10:2b0::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17 via Frontend Transport; Wed, 8 Feb 2023 14:37:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT025.mail.protection.outlook.com (100.127.142.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17 via Frontend Transport; Wed, 8 Feb 2023 14:37:01 +0000 Received: ("Tessian outbound 8038f0863a52:v132"); Wed, 08 Feb 2023 14:37:01 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 23c645ae9c26dab4 X-CR-MTA-TID: 64aa7808 Received: from 610a4042896d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7EB3852F-8557-4BBB-AAD3-01951A4818D4.1; Wed, 08 Feb 2023 14:36:54 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 610a4042896d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 08 Feb 2023 14:36:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DZOwGxhnuwxZU3PSfEmfdhiaiUOWNM20dayahEFhygASv0yyyBG2lo2Fs/mGiEVWJMCa109vlMbQHFoLdTrN9zWzkHvgJ7KtPDoGn5Ir/q2ZV5lh+UuRNNbxWjhsvAThcUAFYgCBwiyYC/igCd7YijUhkmnvF/rQ5Ls0+ed7XMIWmsOnc1zdE4NHGl94ZHKcaGS4D1YJA0spIu6yDOhiCC5aRHUFvtlYYNnZbLX4oapqJ86PAlb8GtJXKfM8+bn6lhrZYcpbPQro3y0bcuv3WRMWL9Q7dpFpCzb7CRqehWMnfxSQjn7VKgtqV0q9tJbz4bj4cLYJYarFYZVhY8MIxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PYTn1crMQWqUIWETFqYxe+CggSSTsiDAJZJP1pNAwuE=; b=UM3ZOqGNqLQMLK0bTzN0etdeLKfsv/79TncZ49hS7FThsRT4L1aM4Ff9uMZTRyyHlQl61ZE0gJT263T+EiDj87G4BcFKtHEuzeDrqMuPaPLkz1abz4XXhwSBU3OT4KaMnG9tTtS1ce1gMAxaDb4I7MRgZEY3RF/1GyvQulWVg2yZ/oxaDK7660/3pzdhHM6MDTS57ZOfpwUaCPmyuTpCbsOwuyUf/r0Nlkzxt0wn21AfpUkNSahSkQF2WNMLKQbnPC5nFQdn0AoPhX/AdS6/6zH8euO3MTYsi22KdtHRR+n4hJI0SgNoLkeCz8n/uyKTSTsUVtbNhg87xdfsdb6J/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PYTn1crMQWqUIWETFqYxe+CggSSTsiDAJZJP1pNAwuE=; b=nrHX7nakXuT6QmaVF7DlOMSPIBBJKlFxvT7wxoKTMoXev8OHCOKigyDf8OvnUg3R9pv6d2wI9kWiCg84391Kk9Q+xI9FEsZ8j2v6zLc49hjcoxb+g5yPoWVW8jAMY3UNqgRFoYlOUtyF+3+Zh6nfbDlGwE/QAFIS9X7DZy5ocFE= Received: from AM6PR10CA0064.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::41) by DU0PR08MB9800.eurprd08.prod.outlook.com (2603:10a6:10:443::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.27; Wed, 8 Feb 2023 14:36:53 +0000 Received: from AM7EUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:80:cafe::d4) by AM6PR10CA0064.outlook.office365.com (2603:10a6:209:80::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17 via Frontend Transport; Wed, 8 Feb 2023 14:36:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT028.mail.protection.outlook.com (100.127.140.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.18 via Frontend Transport; Wed, 8 Feb 2023 14:36:52 +0000 Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 8 Feb 2023 14:36:51 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 8 Feb 2023 14:36:51 +0000 Received: from e124257 (10.34.105.24) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 8 Feb 2023 14:36:50 +0000 From: Andrea Corallo To: Andrea Corallo via Gcc-patches CC: , , Subject: Re: [PATCH] aarch64: Fix return_address_sign_ab_exception.C regression References: <20230206144752.3829182-1-andrea.corallo@arm.com> Date: Wed, 8 Feb 2023 15:36:50 +0100 In-Reply-To: (Richard Sandiford's message of "Mon, 06 Feb 2023 15:06:32 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT028:EE_|DU0PR08MB9800:EE_|DBAEUR03FT025:EE_|AM9PR08MB6081:EE_ X-MS-Office365-Filtering-Correlation-Id: f5616250-2fb7-4a21-1e63-08db09e1f110 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Uejmwal0AunHy+4YUmDBd/tJw176H/mJQw2QAWGzPbDbefhN1gvB7pGDPRNByApZXrDjqxnMO/PCmC8JrL9c/jxcQPNuLffEeAM1yaSMf/VxHrv+3WMDGqhe2awoNRDEgumoihRdicu1u5UidIJDGZu0tA0Gf4AJT2qWTmvjRlxW0boogffTh1c8bI9IWSNDiKXKIMT0wfJvlIpJaW03zYsZdunXpxB3PgXBFbN6sw3QiBNiTkuFGTuka3/Y2BYCV47KKUSYN8RdAdZYkHV0gmzvKzX3j9Gq6mGVqlFFMhVo/K2VXFB+VxP8ySZl3ByQtdfxNc6f39M9CwpRr/EyW/VvSKCWrwJrcY+fh3jmUTxEhFpaplBVlzrphFp4cjxL0GrmeNSNwM4SLGYJ8ciyvNswuiX0nDVbOOrTLdMLTGcg2m1LzbPplruJ9rSJICMP650f3GSjrbBQxAuv6n8FIVciGcxB/hq60DwiNIJb0svjGOfEZKi+VW3tKI5uhPDCYotT5OwU8pV7csvxaNzTPJfqADXyHFM3rP4/ocBUjR7xUm2yEZYsubXINKRHWS7/QStOyu9MfgEpoHD76ht1zS5dMKtfF5qloAOQ2VDnlJhjvrOvgXK9oWk9XuacSDlcRBf2aV+/XO1XaYJtjyXEqlfgHsmWHbHRmvWVkp5QhKt2+WdUCIzuz2yy5dJTp+5OueNhF3pHsNUqCq9nBuTrjgWo0AJ57oisFzRut7bBr1o= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(136003)(39860400002)(376002)(346002)(396003)(451199018)(36840700001)(40470700004)(46966006)(2906002)(6916009)(82310400005)(44832011)(36756003)(47076005)(5660300002)(8936002)(41300700001)(426003)(336012)(40460700003)(70206006)(36860700001)(70586007)(2616005)(4326008)(316002)(86362001)(186003)(356005)(81166007)(54906003)(8676002)(26005)(478600001)(82740400003)(40480700001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9800 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bd437ed5-9314-48b5-fea3-08db09e1eb4b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CJmO49HTM3MqCtNwT6kb9QJPi3rMEBlIYzMdy6E/gcu4Tvj8VM6nS3Pm2C38XV3ERTMnggPAsR3gImwNEVuXkI7M7rgXpc3eoOXkFdHOWYsZI3iTLAbttQpViquBZWCs5I/gW133SuRuFfaNqfSqv9FAuzngCfnaUI/QLZR6b8pD6FkLTp9qZChsD+uVrDufPyuhf2AO2Q8BpVJXClXR2n1qEg540dxJxRm3wRoCa+G3kbXBssykC821j634mA8naGY+hqaq2oIfT2zYza/eTjuWdERsCWRtVGaak7sp3wY99fhaZFRDtUXfi5Uz+7CSJVAWRcsT1b/zXEwAPRRO3NJ9XPgEJR+duIJhEpqYp+Ty/ptUZHA+gsSnY747d/aICKvvS2GN83HHDEe54ZlZ0FyNI1VW7jfLm8VB9seIBfsq2WnOHiRR/IWeXVEkQ9VStJt/EKpWwReDGgUvkoLNEAcCnFZxZXORdU0OLmmvGQQDiaUvD5BmPdCG/hoeS41D+KU88OZ5vIPUYEBOzKp/d9WWazwWQsA9rW878vpjPPJzGulLRtGMMVLi5PBmLYuNFD0ANkvmneyskGNNimencWXCCk2gltlVEbZd6GLFV2iHI4Zzue6G7JGRYU/lew6qhR9SRt7adjAJkCrBLq/JLh4bPEyP4b5gDgOoU8U/fBfis0kufeFobfXhab5tGBEhLwZvlYSxsrufRAiwIeAMhQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(396003)(136003)(346002)(376002)(39860400002)(451199018)(40470700004)(46966006)(36840700001)(81166007)(82740400003)(36860700001)(86362001)(2906002)(36756003)(44832011)(41300700001)(82310400005)(8936002)(5660300002)(40480700001)(40460700003)(186003)(26005)(4326008)(47076005)(426003)(2616005)(336012)(70586007)(316002)(54906003)(70206006)(8676002)(6916009)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 14:37:01.9714 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f5616250-2fb7-4a21-1e63-08db09e1f110 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6081 X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Richard Sandiford writes: > Andrea Corallo via Gcc-patches writes: >> Hi all, >> >> this is to fix the regression of >> g++.target/aarch64/return_address_sign_ab_exception.C that I >> introduced with d8dadbc9a5199bf7bac1ab7376b0f84f45e94350. >> >> 'aarch_ra_sign_key' for aarch64 ended up being non defined in the opt >> file and the function attribute "branch-protection=pac-ret+leaf+b-key" >> stopped working as expected. >> >> This patch moves the definition of 'aarch_ra_sign_key' to the opt >> files for both Arm back-ends. >> >> Regards >> >> Andera Corallo >> >> gcc/ChangeLog: >> >> * config/aarch64/aarch64-protos.h (aarch_ra_sign_key): Remove >> declaration. >> * config/aarch64/aarch64.cc (aarch_ra_sign_key): Remove >> definition. >> * config/aarch64/aarch64.opt (aarch64_ra_sign_key): Rename >> to 'aarch_ra_sign_key'. >> * config/arm/aarch-common.cc (aarch_ra_sign_key): Remove >> declaration. >> * config/arm/arm-protos.h (aarch_ra_sign_key): Likewise. >> * config/arm/arm.cc (enum aarch_key_type): Remove definition. >> * config/arm/arm.opt: Define. > > OK, thanks. > > Richard Thanks for reviewing, in as b1d26458839. Best Regards Andrea