From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20077.outbound.protection.outlook.com [40.107.2.77]) by sourceware.org (Postfix) with ESMTPS id 829403857021 for ; Mon, 21 Sep 2020 12:13:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 829403857021 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Andrea.Corallo@arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5usTqvI3rqT0AVEMe/nqgsf/oEsj0iNSXPSC40VvAlo=; b=vVbJwOTG7VJDTljBZ9PUqdVqayhMja95YlMJJo6PSoRbFqapACu+F7UUwAM4nm9oWtvA5C8Kjhp8dAFTxXv1CYdmL4c677so5NUvpGBJk5jtLjZwRqPloytA1t4drAFFCgJlseMbLvA4TsliRcdSZSORLnMbtb2Q+k38H5ZT69Y= Received: from AM6P192CA0022.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::35) by DBAPR08MB5621.eurprd08.prod.outlook.com (2603:10a6:10:1a3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Mon, 21 Sep 2020 12:13:45 +0000 Received: from AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:83:cafe::32) by AM6P192CA0022.outlook.office365.com (2603:10a6:209:83::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11 via Frontend Transport; Mon, 21 Sep 2020 12:13:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT033.mail.protection.outlook.com (10.152.16.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.15 via Frontend Transport; Mon, 21 Sep 2020 12:13:45 +0000 Received: ("Tessian outbound 7161e0c2a082:v64"); Mon, 21 Sep 2020 12:13:45 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 817d5fd46e6215d7 X-CR-MTA-TID: 64aa7808 Received: from 67176272dcea.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5973111C-769B-47D1-89B9-8B203758389F.1; Mon, 21 Sep 2020 12:13:39 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 67176272dcea.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 21 Sep 2020 12:13:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N0aoajVb1RBTqtSWyvRgDnu49a/lLYH1JG/luezSOnPBUADUpFWUrndFg9ZYzi7vaIqUPTebDJ3LgKz4oaIe6x9i/qFkTWzD/lljjIItG6JVzPRiwiXaQ51wlDwyVFWp7yIOyUuIItwd3L/lKPTo0IuSSDVz8GR2J0XtjUHfmr7RgLcnQIyBtcOuf1mVrDDiVOhrGCAG9Unbunvi4MeuNG06GBnkyX1f2ySOrqojzbiGMniBOx14E80mgMJZR8NXnRPcl++uWI2RNTZAz1R+QoWRUO3ZjxWYH9+f53AS7qxkRKpo+7/fJUzAFmgHTFkPasHMmwY/3UtNr9GnXFqabA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5usTqvI3rqT0AVEMe/nqgsf/oEsj0iNSXPSC40VvAlo=; b=jYBIJScdBXr02Lwx2eKRs6lL0wHSAaHESXKwr1g+wuzCTO6RFOdjZ93fmwqu9WHIhp5UBqaWSOuKBwLuLbQphtpC4+OgKUrYDCOlk3i9guM6406c/VTBMx/qlSOcfAbL8LVIb6i0fchrlqUO596e8cwgGukk/tp/KTQT1V9FYLDKzDVAI9pNAHxjjzUvRRAeeSn2Jp59GNbpx6K66OkPmGx74O3UDe7c4M9jnS9Mv2Pz8goaaxp5jiOn8f0lTO2CUnsggM85xDchfREl9/Jbr+WpO4NinOOPyTu6HBFRQB96AA0UwjH0gAEow1jP7pJSLhWjkxaNzQfXhlQ6b9fDoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5usTqvI3rqT0AVEMe/nqgsf/oEsj0iNSXPSC40VvAlo=; b=vVbJwOTG7VJDTljBZ9PUqdVqayhMja95YlMJJo6PSoRbFqapACu+F7UUwAM4nm9oWtvA5C8Kjhp8dAFTxXv1CYdmL4c677so5NUvpGBJk5jtLjZwRqPloytA1t4drAFFCgJlseMbLvA4TsliRcdSZSORLnMbtb2Q+k38H5ZT69Y= Authentication-Results-Original: gcc.gnu.org; dkim=none (message not signed) header.d=none;gcc.gnu.org; dmarc=none action=none header.from=arm.com; Received: from AM6PR08MB4900.eurprd08.prod.outlook.com (2603:10a6:20b:cc::10) by AM6PR08MB3494.eurprd08.prod.outlook.com (2603:10a6:20b:42::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.19; Mon, 21 Sep 2020 12:13:37 +0000 Received: from AM6PR08MB4900.eurprd08.prod.outlook.com ([fe80::b96e:941c:e829:3903]) by AM6PR08MB4900.eurprd08.prod.outlook.com ([fe80::b96e:941c:e829:3903%3]) with mapi id 15.20.3391.024; Mon, 21 Sep 2020 12:13:37 +0000 From: Andrea Corallo To: Kyrylo Tkachov Cc: Richard Sandiford , Richard Earnshaw , nd , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH] aarch64: Do not alter value on a force_reg returned rtx expanding __jcvt References: Date: Mon, 21 Sep 2020 14:13:35 +0200 In-Reply-To: (Kyrylo Tkachov's message of "Mon, 21 Sep 2020 13:00:32 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: LO3P265CA0003.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:bb::8) To AM6PR08MB4900.eurprd08.prod.outlook.com (2603:10a6:20b:cc::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from e124257 (217.140.106.37) by LO3P265CA0003.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:bb::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.13 via Frontend Transport; Mon, 21 Sep 2020 12:13:36 +0000 X-Originating-IP: [217.140.106.37] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b3b81197-6309-414c-545f-08d85e27c996 X-MS-TrafficTypeDiagnostic: AM6PR08MB3494:|DBAPR08MB5621: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: fqInBH/pmBP5hqeTAn0F1QWHvf3tWknslsizKoh0CZsfmsql21UWTnKabAvS/XDfI/n8/s47otmOkiZ3g7jcZY2wyHj+dx+JNc4T0niB4mu0heS4M0DdH6L3qL/6Wipc/W61eIr4kxJc8gZ8ya//ttZRQIGRoHDcuTSEEazpxNtVu6rjVL2h3ihFKBCFytGwY+h28iTGh9tZyMWtkG2TMrMsXHJZd5HbdK01kkbVGr3An7M0UzEpki3JCcpgJP3aiqmjhfJZ0T8O1dKX/ko2tp/wA6+u9oCUV1k9t9UHmUlE4/z1PQJWu+JX4kiKzxZQP4Hjz/lkz5k3ukcjEkPHeA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR08MB4900.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(39860400002)(346002)(396003)(136003)(4326008)(26005)(8676002)(83380400001)(6862004)(54906003)(956004)(316002)(2616005)(86362001)(37006003)(44832011)(66556008)(66946007)(66476007)(186003)(5660300002)(36756003)(52116002)(6496006)(6636002)(53546011)(6486002)(16526019)(478600001)(2906002)(8936002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: CqFF8mX/nD8pfvRls9RyE8rqathB08UGyUXDA6YkPAlrU7wZ5i+AMMbglBSG6uUOJ+Ep7TxajvkpD+7NfyY1nH0t3iUrVxLKDAXScRJKPuhgeIOQRUd7gXq5yVabjs+iKkRfS8NE98OHgLv5BfNUxzAhe6ugOXrQeOjeM/iNUb2j++7Ec9vdPEKCNwAlzM/X6GhjEJnwepDWM01wcQ2sDt1EbIldrSGhMQ919+aFqUHMqrfFWOfav/9y3/IrFOmTmqudHIZjPFmwQzp9QgO1qZiFHAJQ5+jQ74o7Gh8nkMH5Y10EGZagUcu7hBG8JgedEn6IMUcDNMV78iX8I6EK81Flli/+uZlv/3HHSsUOvQtrxgsDbEerC5f4yg1tw1eoB9PK6NF8hQYzS1kWhmcv5YPzCH5juN7YsjsTj3+168xAj9uSoWpOsAVh0t0hfVNubLnq8M2FC9a0lS/ZLWtQYhwuVo28FLvU4S6+ZtDDBHcuqr1rfNbxY86LSUiuCrGnTN1hLPXlK5q7XYTD7I0qwG8yHPLKZo6xbhSshZXJ8qO0UVrxeCIDNbnZlLrMqAM4oO0dtx9cQY/Lu3lYHeEpEsby2PoWcn4War3+YRn38Tq+84SIWdAe+x24+wuGUVD5SwhhaXKUoczeo6TMcVhbgA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3494 Original-Authentication-Results: gcc.gnu.org; dkim=none (message not signed) header.d=none;gcc.gnu.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 1bdc0abd-0f7f-41a6-ed46-08d85e27c4b9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EwxW0lA/pOvpew4pSM8BkH8ziNTsI+GKglcV7j1lVnC5KXGGTw9OC5R5nlvGvgCDX+5NOZk5JYSQT/A7sddZ+t3reiDmSBOjZCVgxhTXRQHV9+EuXdjVS6/DXAIJK0CuCG0Wa5OV0vkoIwq9yGScFEhf+xxWbT1NySF7eRi/Iar8vgHfP/VADwuv+Icw7Am+jQ/F1Dndhhc0cptGQSDuwUl+x6p03CakOzubYT4Rb4POn7GFeBLjVaZpt3gOQ5JMK6av5TnVKXJLp7dxgoZH84gR6BXFG/7As07mClsEgGoOsYdjP0Yw/tK/kCuAd/KZ/N/dXFsOA7uxFABc6URGN9MjH/JMqSjvLsMy4QgiutYAYfwBXfn02TWU0Jn40MJ0xLMqwbFBVeRk9TBqHfU2aQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(346002)(396003)(376002)(39860400002)(136003)(46966005)(70206006)(16526019)(36906005)(70586007)(54906003)(336012)(316002)(6486002)(37006003)(6862004)(478600001)(26005)(2616005)(6636002)(186003)(36756003)(4326008)(44832011)(956004)(8936002)(5660300002)(81166007)(47076004)(82740400003)(6496006)(82310400003)(8676002)(86362001)(2906002)(356005)(83380400001)(53546011); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2020 12:13:45.1113 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b3b81197-6309-414c-545f-08d85e27c996 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5621 X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Sep 2020 12:13:49 -0000 Kyrylo Tkachov writes: > Hi Andrea, > >> -----Original Message----- >> From: Gcc-patches On Behalf Of >> Richard Sandiford >> Sent: 21 September 2020 11:58 >> To: Andrea Corallo >> Cc: Richard Earnshaw ; nd ; >> gcc-patches@gcc.gnu.org >> Subject: Re: [PATCH] aarch64: Do not alter value on a force_reg returned rtx >> expanding __jcvt >> >> Andrea Corallo writes: >> > Hi all, >> > >> > From the `force_reg` description comment I see the returned register >> > should not be modified, thus IIUC should not be used as a GEN_FCN >> > target. >> > >> > Assuming my interpretation is correct this fix this case inside >> > `aarch64_general_expand_builtin` while expanding expanding the >> > `__jcvt` intrinsic. If is not the case please discard. >> >> Good catch. > > Can you please also backport it to the appropriate branches as well after some time on trunk. > Thanks, > Kyrill Ciao Kyrill, Sure happy to do that. For now into trunk as 2c62952f816. Thanks Andrea