From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60083.outbound.protection.outlook.com [40.107.6.83]) by sourceware.org (Postfix) with ESMTPS id DD3FC3858D35 for ; Fri, 10 Dec 2021 09:39:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DD3FC3858D35 Received: from AS8PR04CA0148.eurprd04.prod.outlook.com (2603:10a6:20b:127::33) by AS8PR08MB6453.eurprd08.prod.outlook.com (2603:10a6:20b:31b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Fri, 10 Dec 2021 09:39:31 +0000 Received: from VE1EUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:127:cafe::21) by AS8PR04CA0148.outlook.office365.com (2603:10a6:20b:127::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.19 via Frontend Transport; Fri, 10 Dec 2021 09:39:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT053.mail.protection.outlook.com (10.152.19.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12 via Frontend Transport; Fri, 10 Dec 2021 09:39:31 +0000 Received: ("Tessian outbound 1cd1a01725a6:v110"); Fri, 10 Dec 2021 09:39:30 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 395cc05fcbb5fb7f X-CR-MTA-TID: 64aa7808 Received: from 132f1d3d7ca0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FF1CD851-A7A2-4069-A3DD-0CD944CA3B95.1; Fri, 10 Dec 2021 09:39:17 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 132f1d3d7ca0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 10 Dec 2021 09:39:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YntSPoOp/aqtStAhjig/MWyrdFjkcr4MgM9XNdxhivtjy7QxVYykP3fyczHvyfqDf9RE/WWLRc1WRM5wGYS2NkkApZY64VcVClwtsislqfi2QYfYGhD6giTHJKzkOZdOqp1S2qu8OnC82IiK04NgD7ENk0Qbk4OLhqPj7OtzXcu7o16XQeubcSh4F/5ZYMuq2YggFRo0WGPxd7w5EydoU/j6jtOUMoErkYGG6s04FCfopvdo3WEKpIDmie2rLsSJNWBcDLars4O3HgelYOT/gTqBSD2bBVsjUGcBpa0nVMzXPD/NfQnq4belB1SkqOAOqxgObx3KbQkxhMbtXQ34GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XB4iRT0E+7DV4lT9mzQ6p5S3J7Zna2o9yGVWEEtOd5g=; b=CvU1R/+/tk55dYhW6QMohlYkdSDQQ7wfc1NFez4vqB5mizBTBuDU28OH5teVo/3fgsZ34DB1/UV6lrYRzFgxjg9S329s+WH/qt0lAjO4xC+fbAh37KhIRRvxx0AYF3no8hRk5MHisO0d6tP5HPVzlomwu6RZH3U+xno56KxY3VGKhGKLttJQ+u6zvz+RdH2GSNCMKHhLjGsh8sIz70iBudP7DU99/i9HMQxxOfJLCqAv/qayYf5xEjSI+UO7gh3bsCKUksTaRjkTrLojw4iSKSXAABFtmt8pud+MOOdXyCgXNa8ML3vNHs4P4HuDpe2hAtpn4n4CfL3ux9BRtZ6H2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none Received: from DB7PR05CA0022.eurprd05.prod.outlook.com (2603:10a6:10:36::35) by AS8PR08MB7308.eurprd08.prod.outlook.com (2603:10a6:20b:443::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20; Fri, 10 Dec 2021 09:39:12 +0000 Received: from DB5EUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:36:cafe::fe) by DB7PR05CA0022.outlook.office365.com (2603:10a6:10:36::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.13 via Frontend Transport; Fri, 10 Dec 2021 09:39:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT057.mail.protection.outlook.com (10.152.20.235) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4778.12 via Frontend Transport; Fri, 10 Dec 2021 09:39:11 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 10 Dec 2021 09:39:09 +0000 Received: from e124257 (10.34.101.64) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 10 Dec 2021 09:39:08 +0000 From: Andrea Corallo To: Richard Earnshaw via Gcc-patches CC: Tejas Belagod , Richard Earnshaw , Richard Earnshaw Subject: Re: [Patch 8/8, Arm, GCC] Introduce multilibs for PACBTI target feature. [Was RE: [Patch 7/7, Arm, GCC] Introduce multilibs for PACBTI target feature.] References: <93f632b6-4eb9-f709-1f02-fddb7c3a03a8@foss.arm.com> Date: Fri, 10 Dec 2021 10:39:08 +0100 In-Reply-To: <93f632b6-4eb9-f709-1f02-fddb7c3a03a8@foss.arm.com> (Richard Earnshaw via Gcc-patches's message of "Tue, 7 Dec 2021 14:56:44 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: df09bc9d-1fc6-4b7c-bd85-08d9bbc0f7b0 X-MS-TrafficTypeDiagnostic: AS8PR08MB7308:EE_|VE1EUR03FT053:EE_|AS8PR08MB6453:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3Ys4qL7D0dKUFXVcOpt5fAXisNAv2HipBp3KvpO9a4GIGUMQC6txiGB9Yib20MjhtTyeCMxhxvT+1S3rUVYpzy5VvDjca5cntPZCopVI6kDHu9fmoaTUIs6w5x3svShEXkOo2mFIAm53iKZFpt7gAznjR1DGJlXV8pzrm0icmFGB0EBl1eLJaf8Ie4nJcGSv2leVz/0/YZ5dYsrzk+bok9MADmbPWfbdvdDuxVz8ZtUVoN6B3R/4/oc68JrUEzttOhRylHbE+ZVUn0ft+EXKh2XaKAEO46PhHcRP8Y8M1wW13OspvyZ3aHQKgOXECKz3b95jNNnckHe/ETTB8wUiPZXJg3/+6kqYV2Xs+B/CeiG3eDfkQgviTbyaqFzWP9OGlHE1poqKNF1vkjrTxO+PrCShjIxZ8soTafi3A/mttXbdWK0l5e4+SS0M/v7xN2M99vNPOR0b4IEQVE/4zNWu9fmCCdeRoFwCAMvcMyVhBQ9A09NrdpZF2wsKwKRxIMlchHx8ghlRyIvxJoA/4WeaqUmw8mPt+5+T5+mui0oJ41S9KUA+GcfXX4QmBCFTJ42ZvXavGtHi1ueBZGZ/soZK7oijFklOe6CQFwfEFFqmeZ51syaP3Q1F4Ump18JpoZcpcf9vf4xmPVw7lSqDqbDAPj6oVkzs8ePBqUpGoxLxkZvQ+SiTlYnSGfiSFYrN4h+VEo7rzxqoea1G8mWaoX6EalvE0w8flDRe9RU3zi8WeaG6x+dpv4M9zzCt7n5fct3A5gqdRL55HTXfGV+KdkHxchw+pXDUXZuFuQbSL9/VomM= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(40470700001)(36860700001)(47076005)(426003)(336012)(26005)(2906002)(36756003)(316002)(2616005)(70206006)(70586007)(40460700001)(53546011)(186003)(508600001)(82310400004)(54906003)(5660300002)(83380400001)(6916009)(86362001)(356005)(8936002)(4326008)(8676002)(81166007)(44832011)(36900700001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7308 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: cb620535-0c7c-4671-229f-08d9bbc0ec1e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3YQV82Pe5SiYqgrrZUnb0fKxfenotu1XqFLTzqP3ecLIyvuSyyn2rQiKL8Tttt2rx+gVcAx7FqndR7RvhQONYVLUNYvp6aS2mahPjlFKSBirgQymDbV1MxPkuFg3Z55wcdz6I4MU/JmZOQjMFRiNOSQTcxlO14OCvTYExek9QP07aRynCQ1LUWyshAVAZNR/GrUASXp61qs8DYfsU6B1QZoOjuq1IMa2ECpXxyxHWsA0bpgV0+z2M/eveirtJZf96KHLVNpnd54QXInB93iUtqGAjS2LZHorX+DZDaxOZ+O87VbwOpx4IEEr/PG9WaA1xreV6o2AP1bIg1xysbGDEJ3ahG8CEQx+xZo8kqgCd9uHAZc5hZajF/YVRgt17w1gWe+rl8Turpl5vgD8UZHRG+zcCNdA0HbOgQdbZD+AIlray2PiANvspQvzkb0cry25/HsRkgkpoivjWJSx5ek+T9g2XpWENV2Gl53gHTMH8jt7J6xeK6OtyKhRISnHtsRqux9CeI0M5t9BUKbPGYGzujM6QLFVjQakJoP9K2tJPQ68kF2FRgGFiFcjrhJHUOKmA1/3dbLSP6WB3iOSPF+4Wzg98prLGVazvrAHRqmssLqtRM1eXFyw0ngmIy/y9HR3DyQPvKc9swR/NFVtFtKMQXEaBxZTmOCFel3Y9EivnOh9jDltrefIFOblv8PnyDCg5wY67Bth3TwvaQ4OnQQM13CWzjDtFnPy9nfXkzgHS1FYCXDMlTMj6RkhupZjfUiDO0OnEodigpM8GPnReSv1RA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(40470700001)(336012)(44832011)(8936002)(70586007)(6916009)(70206006)(186003)(83380400001)(2906002)(53546011)(316002)(82310400004)(81166007)(426003)(36756003)(36860700001)(8676002)(26005)(508600001)(2616005)(4326008)(40460700001)(86362001)(47076005)(54906003)(5660300002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 09:39:31.2212 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: df09bc9d-1fc6-4b7c-bd85-08d9bbc0f7b0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6453 X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Dec 2021 09:39:45 -0000 Richard Earnshaw via Gcc-patches writes: > On 28/10/2021 12:43, Tejas Belagod via Gcc-patches wrote: >> >>> -----Original Message----- >>> From: Gcc-patches >> bounces+belagod=gcc.gnu.org@gcc.gnu.org> On Behalf Of Tejas Belagod via >>> Gcc-patches >>> Sent: Friday, October 8, 2021 1:19 PM >>> To: gcc-patches@gcc.gnu.org >>> Subject: [Patch 7/7, Arm, GCC] Introduce multilibs for PACBTI target feature. >>> >>> Hi, >>> >>> This patch adds a multilib for pacbti target feature. >>> >>> Tested on arm-none-eabi. OK for trunk? >>> >>> 2021-10-04 Tejas Belagod >>> >>> gcc/ChangeLog: >>> >>> * config/arm/t-rmprofile: Add multilib rules for +pacbti. >> This patch adds a multilib for pacbti target feature. >> 2021-10-04 Tejas Belagod >> gcc/ChangeLog: >> * config/arm/t-rmprofile: Add multilib rules for +pacbti. >> Tested the following configurations, OK for trunk? >> -mthumb/-march=armv8.1-m.main+pacbti/-mfloat-abi=soft >> -marm/-march=armv7-a/-mfpu=vfpv3-d16/-mfloat-abi=softfp >> mcmodel=small and tiny >> aarch64-none-linux-gnu native test and bootstrap >> Thanks, >> Tejas. >> Hi Richard, > I can't decide whether this is too much, or too little. But it > doesn't feel right as it is. > > Ideally we don't want yet another multilib. It would be better to > have one of the existing multilib variants made pac/bti safe. > > And secondly, what about the hand-written assembler files in libgcc? > Don't they need updating to be PAC/BTI safe? I agree with you, this patch is missing at least bti landing pads in the hand-written assembler files in libgcc. > Also, does this even do what you intend it to do? It adds the PAC/BTI > architectural feature, but it doesn't actually enable PAC/BTI in the > generated code. Good point, I'll fix this too in the upcoming respin. Thanks for reviewing. BR Andrea