From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60081.outbound.protection.outlook.com [40.107.6.81]) by sourceware.org (Postfix) with ESMTPS id 1BA473844011 for ; Wed, 19 Aug 2020 09:13:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1BA473844011 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Andrea.Corallo@arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ct0c3BugRYXQAN8g+zQxk5z3YDvCtsYmW8EDv0Ie9uA=; b=NIE1o3pAt/mB3KPPJ+03defuw49g6mcajU5fZASog0rLsEiP8T9yvFURXdWHiwqLpAtKpM4ica1iFFrfyDrjkhh/7utcSK7kq3odfZVCiP1j+IKRoysZMzbpCLgg49qz6FdInZcOc35WvJkM9RoYicHyHpmTV+g7IZUIoXLZPQw= Received: from AM5PR0301CA0004.eurprd03.prod.outlook.com (2603:10a6:206:14::17) by DB8PR08MB5018.eurprd08.prod.outlook.com (2603:10a6:10:e2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.23; Wed, 19 Aug 2020 09:13:54 +0000 Received: from AM5EUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:14:cafe::98) by AM5PR0301CA0004.outlook.office365.com (2603:10a6:206:14::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.24 via Frontend Transport; Wed, 19 Aug 2020 09:13:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT041.mail.protection.outlook.com (10.152.17.186) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.24 via Frontend Transport; Wed, 19 Aug 2020 09:13:54 +0000 Received: ("Tessian outbound e8cdb8c6f386:v64"); Wed, 19 Aug 2020 09:13:54 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 02f89ec79e0b5cba X-CR-MTA-TID: 64aa7808 Received: from bbaec793da58.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 96BAFD1D-E21A-4570-AC5D-5214354C5606.1; Wed, 19 Aug 2020 09:13:46 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bbaec793da58.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 19 Aug 2020 09:13:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QB7acr0y0J3rqT1oBECwd/VBUoxVwjEsdRD5OK6mEzqUS0faZRw1WV4SiwqFS6i5S/TwSsnn9ToAisaPbHZTg7yOjsl+jEt9q9GRQd4qGO3oMAnT6ZEV0I4o618UARI1kMoHngrjCUJtdbzxhR74ucYvhSjpIkO4cZQw52dlPCyUetQ4U4fL/f9gXf/A/XxLGL8IWnArlS+zYJmKq4uORjtuplgdT5uEPosSnJ4j6GUDsyuLKuLmsU+qDVaItt8gZMYJorQojfUuRfXoaJcjtgnCLSychlqEB6ljk+cgmDTTRurhl6JsXyhGJhHEZGX6JrlFto26FnFc6dy/ITUIlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ct0c3BugRYXQAN8g+zQxk5z3YDvCtsYmW8EDv0Ie9uA=; b=eRJ2JpF6FDiBlTW1Ps8fsPPJkq/PGr8elC/+/QwaGxJgMVOF+xClvqxIbi4WeQkKb+ADxzhp8+bbndA9kSfkkLlGXe9KmnEFqK3pveB32kv06Fd1gSKtS0d779DSbFAMgu5s2f5slD7qutXbF6w8ZasA4JXJm/cRAzAASK3gVmyLPkLrFvGbXTtA4GZiC2j7QDoX6v0oetNf9XD/J6mhQmS6PBQmayJqlTEYbJBYWkDXr+HrKo+tkiVuf+4Fx9FDh5WqSt1cdpysWNYGo8WShUVV2gJ45b/CI4ofEDuoMEDG6m8OqYA7oO57psEdXa2p97vMkN/o28WqoFVX13CVmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ct0c3BugRYXQAN8g+zQxk5z3YDvCtsYmW8EDv0Ie9uA=; b=NIE1o3pAt/mB3KPPJ+03defuw49g6mcajU5fZASog0rLsEiP8T9yvFURXdWHiwqLpAtKpM4ica1iFFrfyDrjkhh/7utcSK7kq3odfZVCiP1j+IKRoysZMzbpCLgg49qz6FdInZcOc35WvJkM9RoYicHyHpmTV+g7IZUIoXLZPQw= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AM6PR08MB4900.eurprd08.prod.outlook.com (2603:10a6:20b:cc::10) by AM5PR0801MB1890.eurprd08.prod.outlook.com (2603:10a6:203:50::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.18; Wed, 19 Aug 2020 09:13:44 +0000 Received: from AM6PR08MB4900.eurprd08.prod.outlook.com ([fe80::d070:f136:4090:9ed3]) by AM6PR08MB4900.eurprd08.prod.outlook.com ([fe80::d070:f136:4090:9ed3%5]) with mapi id 15.20.3305.025; Wed, 19 Aug 2020 09:13:44 +0000 From: Andrea Corallo To: Segher Boessenkool Cc: gcc-patches@gcc.gnu.org, nd@arm.com, Richard Earnshaw Subject: Re: [PATCH 1/2] Add new RTX instruction class FILLER_INSN References: <20200724211834.GS32057@gate.crashing.org> Date: Wed, 19 Aug 2020 11:13:40 +0200 In-Reply-To: <20200724211834.GS32057@gate.crashing.org> (Segher Boessenkool's message of "Fri, 24 Jul 2020 16:18:34 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: LNXP123CA0017.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:d2::29) To AM6PR08MB4900.eurprd08.prod.outlook.com (2603:10a6:20b:cc::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from e124257 (217.140.106.37) by LNXP123CA0017.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:d2::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.25 via Frontend Transport; Wed, 19 Aug 2020 09:13:43 +0000 X-Originating-IP: [217.140.106.37] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 35f0e9d1-fa33-4882-a8f9-08d8442031f8 X-MS-TrafficTypeDiagnostic: AM5PR0801MB1890:|DB8PR08MB5018: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WkmU9bf5n2zrsoCfzGdwMcHCUiHILgcO4ir7yVCrx04m/q65mP6Qtgo1e44fbND4bsTChvcVAXxrlzPhasw5h1Gua3QqocVD7cuSy8dkKXRzhGEzpDHQDepa58FoDm9Wyf1esBCUHSIeJfZfX2UepmksMXffM7yHu5uNOtwqCFFAYp4KsUbomClbGCVwHfdaVUBi+QgEDhPBUt0GncddmyLts5nnEHgwy+WteH7t0szwjKOszHtck79gLkd4CFoRieGfBq7VxUpLUHVZXictciMYhcXctKMrZP7onpw+NvuN0WrYEj5JmNp++gt3P88o X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR08MB4900.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(346002)(396003)(376002)(366004)(316002)(66476007)(66946007)(83380400001)(66556008)(5660300002)(2616005)(8676002)(956004)(86362001)(6916009)(6496006)(478600001)(4326008)(26005)(44832011)(52116002)(186003)(6486002)(36756003)(16526019)(2906002)(8936002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: HWifXikxP9blQpvrnvUXClucO4YSfKHWgfltpJnMtUeXHZI+pZ52zt/8kMpWNSa/WxaKQeZ7Vo4qsa2+pkDAOgNb1yq9Hc0INhEPuXmX8deNtchg4EyqFxZiElvimcIygn8rOglo8GkGM81iw8VgLhZO1JmqgizIalRT/zVUCDdPV8kSXOCC96nhaxLSBv/9UtE2f7JcnNih//1rY8GkyaTsLUCc8TaM9TTFOexcITwZ0Bbk7vfCkm0JqJFwAWWd8Cw2c4BmXYWfmoL0bRyQa5ZBjmscwlcLo9YeXPrw887er4JK2Lrk63DpVRo720m3DDvV+6gzfhQTmtl3QqHUFXAoiCsDl2f2EGBuPaKt8QApC4vwl4RB+3HWsPDsI3PQGXFsWzqlk4GSYA715K8UTGpsWaO5afbO9DUVzYCgvntudvYMRxnQ5Z+261eTEq3rMZWtwey1aNzcm46x+bZLQSC0wjlgLMM0uATpijFYqzVFVy0q9hHPuf1vBkmKRG5x2ybaQAO74ofYEQK/fsmjWtUE2Ktwv/+Kr70MfDTK2DqVEG/gKP5NfjJUzqXgmtD81Sepu2bek3Z4iXzTE1RzFy2vtplJQyh6rivg0oFNs17fJkPOQiiLhbSZcllyiqEUCROJ8ZmF06c1S+G9NKOlXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1890 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 4ac91696-9e90-4709-eeb7-08d844202c0a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i1YcySdrMFmzekS4XBXwN1+cu0LgJLJTBzdqdlZnb2hjEbcm5BCBf3gP29/AfhaKpTAdcpkJOTiI2yZTfZ9LDeOsp7QR4qqf/WQe3AwUXH+Ei8oBUHK4BEVgkl57TH0jo4/DGVgL2Wr3NgoD/RdYR6RkI9lRWlIkCJwEEGdGsapJ1tnmD/ZHHuVi98EyG3DW95a9AcKJKCYceQ81e7YxbvFH7FBg+JhkaKiQNgGZWYg/KJrVGxt8+SRQAiyLZEJ3K7ukDlQPSQyaxI0GLgFnWTLsbS8Cntjj0q1v9irJAl38p044UDT8A+uWugvRfYbRaARk+WH2SFrmhDbIshOYxASKNeBi9FwGYUEvap2aUpWSSUS63JoED7Ek5dwuUOxInfKa8Y85taEkYLbzy3OzSA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(136003)(376002)(346002)(396003)(39860400002)(46966005)(956004)(5660300002)(478600001)(36756003)(4326008)(2616005)(336012)(44832011)(8936002)(186003)(6862004)(6496006)(82740400003)(81166007)(2906002)(26005)(356005)(82310400002)(47076004)(83380400001)(70206006)(316002)(16526019)(36906005)(70586007)(86362001)(6486002)(8676002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2020 09:13:54.0347 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 35f0e9d1-fa33-4882-a8f9-08d8442031f8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5018 X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Aug 2020 09:13:58 -0000 Segher Boessenkool writes: > Hi Andrea, > > On Wed, Jul 22, 2020 at 12:02:33PM +0200, Andrea Corallo wrote: >> This first patch implements the addition of a new RTX instruction class >> FILLER_INSN, which has been white listed to allow placement of NOPs >> outside of a basic block. This is to allow padding after unconditional >> branches. This is favorable so that any performance gained from >> diluting branches is not paid straight back via excessive eating of >> nops. > >> It was deemed that a new RTX class was less invasive than modifying >> behavior in regards to standard UNSPEC nops. > > So I wonder if this cannot be done with some kind of NOTE, instead? > Hi Segher, I was having a look into reworking this using an insn note as (IIUC) suggested. The idea is appealing but looking into insn-notes.def I've found the following comment: "We are slowly removing the concept of insn-chain notes from the compiler. Adding new codes to this file is STRONGLY DISCOURAGED. If you think you need one, look for other ways to express what you mean, such as register notes or bits in the basic-block structure." Would still be justificated in this case to proceed this way? The other option would be to add the information into the basic-block or into struct rtx_jump_insn. My GCC experience is far from sufficient for having a formed opinion on this, I'd probably bet on struct rtx_jump_insn as the better option. Any thoughts? Thanks! Andrea