public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH arm] remove bogus conditional in PROMOTE_FUNCTION_MODE
@ 2009-04-22 12:46 Paolo Bonzini
  0 siblings, 0 replies; only message in thread
From: Paolo Bonzini @ 2009-04-22 12:46 UTC (permalink / raw)
  To: gcc-patches

The reference to MODE_COMPLEX_INT in PROMOTE_FUNCTION_MODE is bogus.  I
tried adding to an i686-pc-linux-gnu bootstrap an assertion that such a
class is never found; the result is that complex types are passed to
promote_mode, but they never reach PROMOTE_FUNCTION_MODE.

Therefore, I propose this patch for ARM.

Ok for mainline?  Or is this the sign of a wrongly-implemented part of
the ABI?

Paolo

2009-04-22  Paolo Bonzini  <bonzini@gnu.org>

	* config/arm/arm.h (PROMOTE_FUNCTION_MODE): Remove handling
	of MODE_COMPLEX_INT.

Index: config/arm/arm.h
===================================================================
--- config/arm/arm.h    (revision 146555)
+++ config/arm/arm.h    (working copy)
@@ -480,8 +480,7 @@ extern int arm_arch_hwdiv;
     }

 #define PROMOTE_FUNCTION_MODE(MODE, UNSIGNEDP, TYPE)   \
-  if ((GET_MODE_CLASS (MODE) == MODE_INT               \
-       || GET_MODE_CLASS (MODE) == MODE_COMPLEX_INT)    \
+  if (GET_MODE_CLASS (MODE) == MODE_INT                        \
       && GET_MODE_SIZE (MODE) < 4)                      \
     (MODE) = SImode;                                   \

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-04-22 12:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-22 12:46 [PATCH arm] remove bogus conditional in PROMOTE_FUNCTION_MODE Paolo Bonzini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).