From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 7AAA63858D39; Fri, 8 Dec 2023 03:32:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7AAA63858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7AAA63858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702006333; cv=none; b=rpk6/TKYcGBduFXMwM2xfyevs27lJb8m0l6ek16qia7/3OS+fscgtRmK0okeBR40kNU6C7OIP0hGse+4JN5fBNcXwq2CJEEKINKqeyR5oIe4vVo6dAY2OA09ZJsMN8IcA0/pYWf3/nJWc4zHVMdtHwoe4Vp0Q1rOHT67hfkx8sk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702006333; c=relaxed/simple; bh=Htk0XeWUbrhTVifiFXwusFzhc+N3M4TQZ5JSsU1/qv0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=PT1DfYZJebdTs95p4XKkGm0NfKAwmnK/ACu7uj3kpoYAVaxOjo55JfafyJe7gXQ3FYdVdbMBNmeTWSo3JZUFjYne8iIj/YoaCgML37Mb2QCDx7QB/J0O8rNbBVFzbF7QfUv1LnoRyudw1GBvmliJeByFxZFBqx6FOw62UYKyJkc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3B83CS0r018628; Fri, 8 Dec 2023 03:32:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : mime-version; s=pp1; bh=/CTKSUMhFNOlgGcSUzLp+0vg9Y0NJsI0nz4Q+mOUqFo=; b=OEIDvBVppVJ+1wTOq0L9ahT5/n9/SAPjssiLPKtdrMRfYqIqpKd86DF9Xj6DDbHsVIIf dm9c01XkrrNWpRiD/2jIEDxIXTJDy0UdZizUPbqUsHgmQZFQeIisCDyL9dPujShHBjHh Env3BjSvNk5DE6YxEyXxesNah6/O7uTDQFBIemsN+I5Knjyrv3+5WgjJNua5Gc6EbjM8 y5CD1pUxbz3UaJnxDSZ/33g0ZIpoS+cgXO1+S/uKScKXxqRV9H1vEeRncbYOiOHedk/r eOwurVMvr6UEKSt1SaQqY/Q2HASIqBkRXHuai9pDwgt3qpfymxmsZN7DEhWRZTKnvDz8 Ng== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uuu1cgd16-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 08 Dec 2023 03:32:10 +0000 Received: from m0353727.ppops.net (m0353727.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3B83ETRH022533; Fri, 8 Dec 2023 03:32:09 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uuu1cgd11-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 08 Dec 2023 03:32:09 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3B82hL4O015407; Fri, 8 Dec 2023 03:32:08 GMT Received: from smtprelay04.wdc07v.mail.ibm.com ([172.16.1.71]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3utavkqafq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 08 Dec 2023 03:32:08 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay04.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3B83W7fc46203594 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 8 Dec 2023 03:32:07 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3B61458056; Fri, 8 Dec 2023 03:32:07 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0B17D58052; Fri, 8 Dec 2023 03:32:07 +0000 (GMT) Received: from genoa (unknown [9.40.192.157]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTPS; Fri, 8 Dec 2023 03:32:06 +0000 (GMT) From: Jiufu Guo To: "Kewen.Lin" Cc: segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org, bergner@linux.ibm.com, gcc-patches@gcc.gnu.org Subject: Re: [PATCH V3 2/3] Using pli for constant splitting References: <20231206052427.143889-1-guojiufu@linux.ibm.com> <20231206052427.143889-2-guojiufu@linux.ibm.com> <2524720f-e1c0-af13-c572-f9a44f58d6fe@linux.ibm.com> Date: Fri, 08 Dec 2023 11:32:04 +0800 In-Reply-To: <2524720f-e1c0-af13-c572-f9a44f58d6fe@linux.ibm.com> (Kewen Lin's message of "Thu, 7 Dec 2023 14:12:38 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-GUID: NwI3FBFhz9MkpjagnULoDyqTvzPlTtFp X-Proofpoint-ORIG-GUID: DAYKGDi6PqFUqTSZlQBsZHzHe6WyhlZO X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-07_19,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=999 lowpriorityscore=0 suspectscore=0 priorityscore=1501 mlxscore=0 malwarescore=0 bulkscore=0 impostorscore=0 clxscore=1015 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312080028 X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Thanks for your insight and helpful review! "Kewen.Lin" writes: > Hi Jeff, > > on 2023/12/6 13:24, Jiufu Guo wrote: >> Hi, >> >> For constant building e.g. r120=0x66666666, which does not fit 'li or lis', >> 'pli' is used to build this constant via 'emit_move_insn'. >> >> While for a complicated constant, e.g. 0x6666666666666666ULL, when using >> 'rs6000_emit_set_long_const' to split the constant recursively, it fails to >> use 'pli' to build the half part constant: 0x66666666. >> >> 'rs6000_emit_set_long_const' could be updated to use 'pli' to build half >> part of the constant when necessary. For example: 0x6666666666666666ULL, >> "pli 3,1717986918; rldimi 3,3,32,0" can be used. >> >> Compare with previous: >> https://gcc.gnu.org/pipermail/gcc-patches/2023-November/636567.html >> This verion is refreshed and added with a new testcase. >> >> Bootstrap®test pass on ppc64{,le}. >> Is this ok for trunk? >> >> BR, >> Jeff (Jiufu Guo) >> >> gcc/ChangeLog: >> >> * config/rs6000/rs6000.cc (rs6000_emit_set_long_const): Add code to use >> pli for 34bit constant. >> >> gcc/testsuite/ChangeLog: >> >> * gcc.target/powerpc/const_split_pli.c: New test. > > Nit: Now we have: > > gcc/testsuite/gcc.target/powerpc/const-build.c > gcc/testsuite/gcc.target/powerpc/const_anchors.c > gcc/testsuite/gcc.target/powerpc/const-compare.c > > I prefer the name of this new case is like const-build-1.c > (put a detailed comment inside) or const-build-split-pli.c, > to align with the existing. Thanks! > >> >> --- >> gcc/config/rs6000/rs6000.cc | 7 +++++++ >> gcc/testsuite/gcc.target/powerpc/const_split_pli.c | 9 +++++++++ >> 2 files changed, 16 insertions(+) >> create mode 100644 gcc/testsuite/gcc.target/powerpc/const_split_pli.c >> >> diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc >> index dbdc72dce5d..2e074a21a05 100644 >> --- a/gcc/config/rs6000/rs6000.cc >> +++ b/gcc/config/rs6000/rs6000.cc >> @@ -10509,6 +10509,13 @@ rs6000_emit_set_long_const (rtx dest, HOST_WIDE_INT c, int *num_insns) >> GEN_INT (0xffffffff))); >> }; >> >> + if (TARGET_PREFIXED && SIGNED_INTEGER_34BIT_P (c)) >> + { >> + /* li/lis/pli */ >> + count_or_emit_insn (dest, GEN_INT (c)); >> + return; >> + } >> + >> if ((ud4 == 0xffff && ud3 == 0xffff && ud2 == 0xffff && (ud1 & 0x8000)) >> || (ud4 == 0 && ud3 == 0 && ud2 == 0 && !(ud1 & 0x8000))) >> { >> diff --git a/gcc/testsuite/gcc.target/powerpc/const_split_pli.c b/gcc/testsuite/gcc.target/powerpc/const_split_pli.c >> new file mode 100644 >> index 00000000000..626c93084aa >> --- /dev/null >> +++ b/gcc/testsuite/gcc.target/powerpc/const_split_pli.c >> @@ -0,0 +1,9 @@ >> +/* { dg-do compile { target lp64 } } */ >> +/* { dg-options "-O2" } */ > > It needs -mdejagnu-cpu=power10 as well. Yeap, thanks. > >> +/* { dg-require-effective-target power10_ok } */ >> + >> +unsigned long long msk66() { return 0x6666666666666666ULL; } >> + >> +/* { dg-final { scan-assembler-times {\mpli\M} 1 } } */ >> +/* { dg-final { scan-assembler-not {\mli\M} } } */ >> +/* { dg-final { scan-assembler-not {\mlis\M} } } */ > > OK for trunk with the above nits tweaked, thanks! > > BR, > Kewen