From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 1CCE3384CB97; Thu, 16 May 2024 06:59:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1CCE3384CB97 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1CCE3384CB97 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715842775; cv=none; b=E6Nty/AAILGukANzMfM3u8HsHGZh68X9cLOwg50Il5gn7wx7gRtV0IACh66rS3uN9Eow90qy54WA5XWarFMFtFGHary2/eD5toKbS8ivg3WIDQXv+KeaYIRstd3FC7s3cHu6KQDwUCtgIDzZWAcYw/wrmhcwAHYTMutMm4J+hWo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715842775; c=relaxed/simple; bh=VkWdI2eK1Luqw+cKvTU8GX53tOMlbUfFO4yQb0Sn8Ak=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=BzN7tueWv/YC/pTm36FmDlZk/rmGGpqKsTsqeioOeTIpu+CCmzXhhrMDS5xjYiyBBSEpUIXzYMUCI8DGB1gk0A+9w5OVl5nechzDEgs+7LVF1hrr+GQq8/O0eSuwWe/gVvCIJeHOcYHXRslWhbWB/pDo/6IjzxxlNMknW7yxXo0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353722.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 44G6m11M026622; Thu, 16 May 2024 06:59:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : mime-version; s=pp1; bh=1BMuXUjtDYGy6brmLwp6y3bRyiXA3IdE1WptfFdrjsY=; b=AFp5OGAQQV0GhpI4xSqdhVcE5AwsV8E1UdCi2NFHdU1o3XGM377HQtd5AvgdsS5yc0oX oq9L3hIXrQHO64L0r9IXh6tf7z1QW7QvZEJNhcoswyBKEDjCFY/M46FzWoCRvQ/Hm+WA LIosGAhXTuBIkd1yPX4JAuK/I9k62fXo3IeNhsL1jRMziCS4ED1mL9scm/d0nZDhCSCz FhAtjQZVSxDe6zkcx6Z2YrpSEz2Hc+FezDFo5kB2FiJy7Dws1S8UxVEHAj+v+Pz+9L4v F9IF6d28I4PrnvRoxWCeiQwHkS/ZqX/75nnSDPuMhjPVYftT82JvIn00nlol4a5fSj5Z mw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3y5d6f00n5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 May 2024 06:59:33 +0000 Received: from m0353722.ppops.net (m0353722.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 44G6xWW6008585; Thu, 16 May 2024 06:59:32 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3y5d6f00kx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 May 2024 06:59:32 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 44G4B8o2006189; Thu, 16 May 2024 06:56:55 GMT Received: from smtprelay06.dal12v.mail.ibm.com ([172.16.1.8]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3y2mgmrdtq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 May 2024 06:56:55 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 44G6uqxr21299892 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 16 May 2024 06:56:54 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ADDD558065; Thu, 16 May 2024 06:56:52 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 922265805D; Thu, 16 May 2024 06:56:52 +0000 (GMT) Received: from genoa (unknown [9.40.192.157]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTPS; Thu, 16 May 2024 06:56:52 +0000 (GMT) From: Jiufu Guo To: Segher Boessenkool Cc: "Kewen.Lin" , dje.gcc@gmail.com, linkw@gcc.gnu.org, bergner@linux.ibm.com, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] report message for operator %a on unaddressible exp References: <20240513025712.889169-1-guojiufu@linux.ibm.com> <20240514092054.GF19790@gate.crashing.org> <20240514104333.GG19790@gate.crashing.org> Date: Thu, 16 May 2024 14:56:49 +0800 In-Reply-To: (Jiufu Guo's message of "Wed, 15 May 2024 10:34:10 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 4mNjCprKsYeOY9Qrl0yIB36ona3SwWxJ X-Proofpoint-ORIG-GUID: LjDpAxg7UUWm5JaVi-TGh1Aoi0p9FzE9 X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-05-16_03,2024-05-15_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 bulkscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 spamscore=0 mlxlogscore=840 impostorscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2405160048 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Jiufu Guo writes: > Hi, > > Segher Boessenkool writes: > >> On Tue, May 14, 2024 at 05:53:56PM +0800, Jiufu Guo wrote: >>> Thanks so much for your great review! >>> Reference other messages, I'm wondering "invalid %%a value" may be >>> acceptable, or "invalid %%a address expression in TOC" maybe better. >> >> "%%a requires a memory operand"? Maybe even print out the actual >> operand given, too. > > Thanks! I updated the code using: > "%%a requires a memory reference operand", since the actual operand > is treated as the address. I suspect one thing here: if "%%a requires memory" is accurate vs. "%%a requires a memory reference". Reference the words from doc: https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html#Generic-Operand-Modifiers a: Substitute a memory reference, with the actual operand treated as the address. And for below code: '("#%a0" : :"m"(x))' is not accepted. While '("#%a0" : :"r"(&x))' is ok. So, it may be more accurate that: "%%a" as requirement of address of memory. Any comments? Thanks! BR, Jeff(Jiufu) Guo > > BR, > Jeff(Jiufu) Guo > >> >> >> Segher