* [PATCH] missing reuire target has_arch_ppc64 for pr106550.c
@ 2024-05-23 1:11 Jiufu Guo
2024-05-23 3:28 ` Kewen.Lin
0 siblings, 1 reply; 4+ messages in thread
From: Jiufu Guo @ 2024-05-23 1:11 UTC (permalink / raw)
To: gcc-patches; +Cc: segher, dje.gcc, linkw, bergner, guojiufu
Hi,
Case pr106550.c is testing constant building for 64bit
register. So, this case requires target of has_arch_ppc64.
Bootstrap and regtest pass on ppc64{,le}.
Is this ok for trunk?
BR,
Jeff(Jiufu) Guo
---
gcc/testsuite/gcc.target/powerpc/pr106550.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/gcc/testsuite/gcc.target/powerpc/pr106550.c b/gcc/testsuite/gcc.target/powerpc/pr106550.c
index 74e395331ab..146514b3adf 100644
--- a/gcc/testsuite/gcc.target/powerpc/pr106550.c
+++ b/gcc/testsuite/gcc.target/powerpc/pr106550.c
@@ -1,6 +1,7 @@
/* PR target/106550 */
/* { dg-options "-O2 -mdejagnu-cpu=power10" } */
/* { dg-require-effective-target power10_ok } */
+/* { dg-require-effective-target has_arch_ppc64 } */
void
foo (unsigned long long *a)
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] missing reuire target has_arch_ppc64 for pr106550.c
2024-05-23 1:11 [PATCH] missing reuire target has_arch_ppc64 for pr106550.c Jiufu Guo
@ 2024-05-23 3:28 ` Kewen.Lin
2024-05-23 5:14 ` Jiufu Guo
0 siblings, 1 reply; 4+ messages in thread
From: Kewen.Lin @ 2024-05-23 3:28 UTC (permalink / raw)
To: Jiufu Guo; +Cc: segher, dje.gcc, linkw, bergner, gcc-patches
Hi Jeff,
subject typo: s/reuire/require/
on 2024/5/23 09:11, Jiufu Guo wrote:
> Hi,
>
> Case pr106550.c is testing constant building for 64bit
> register. So, this case requires target of has_arch_ppc64.
>
Nit: Maybe add more comments saying it fails with -m32
without having the expected rldimi? So it requires
has_arch_ppc64.
> Bootstrap and regtest pass on ppc64{,le}.
> Is this ok for trunk?
>
Missing a changelog entry here, maybe something like:
gcc/testsuite/ChangeLog:
* gcc.target/powerpc/pr106550.c: Adjust by requiring has_arch_ppc64
effective target.
> BR,
> Jeff(Jiufu) Guo
>
> ---
> gcc/testsuite/gcc.target/powerpc/pr106550.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gcc/testsuite/gcc.target/powerpc/pr106550.c b/gcc/testsuite/gcc.target/powerpc/pr106550.c
> index 74e395331ab..146514b3adf 100644
> --- a/gcc/testsuite/gcc.target/powerpc/pr106550.c
> +++ b/gcc/testsuite/gcc.target/powerpc/pr106550.c
> @@ -1,6 +1,7 @@
> /* PR target/106550 */
> /* { dg-options "-O2 -mdejagnu-cpu=power10" } */
> /* { dg-require-effective-target power10_ok } */
Nit: power10_ok can be dropped.
> +/* { dg-require-effective-target has_arch_ppc64 } */
OK with the nits above tweaked, thanks.
BR,
Kewen
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] missing reuire target has_arch_ppc64 for pr106550.c
2024-05-23 3:28 ` Kewen.Lin
@ 2024-05-23 5:14 ` Jiufu Guo
2024-05-24 1:25 ` Jiufu Guo
0 siblings, 1 reply; 4+ messages in thread
From: Jiufu Guo @ 2024-05-23 5:14 UTC (permalink / raw)
To: Kewen.Lin; +Cc: segher, dje.gcc, linkw, bergner, gcc-patches
Hi,
"Kewen.Lin" <linkw@linux.ibm.com> writes:
> Hi Jeff,
>
> subject typo: s/reuire/require/
Thanks!
>
> on 2024/5/23 09:11, Jiufu Guo wrote:
>> Hi,
>>
>> Case pr106550.c is testing constant building for 64bit
>> register. So, this case requires target of has_arch_ppc64.
>>
>
> Nit: Maybe add more comments saying it fails with -m32
> without having the expected rldimi? So it requires
> has_arch_ppc64.
Thanks for point out this.
>
>> Bootstrap and regtest pass on ppc64{,le}.
>> Is this ok for trunk?
>>
>
> Missing a changelog entry here, maybe something like:
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/powerpc/pr106550.c: Adjust by requiring has_arch_ppc64
> effective target.
Thanks a lot!
>
>> BR,
>> Jeff(Jiufu) Guo
>>
>> ---
>> gcc/testsuite/gcc.target/powerpc/pr106550.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/gcc/testsuite/gcc.target/powerpc/pr106550.c b/gcc/testsuite/gcc.target/powerpc/pr106550.c
>> index 74e395331ab..146514b3adf 100644
>> --- a/gcc/testsuite/gcc.target/powerpc/pr106550.c
>> +++ b/gcc/testsuite/gcc.target/powerpc/pr106550.c
>> @@ -1,6 +1,7 @@
>> /* PR target/106550 */
>> /* { dg-options "-O2 -mdejagnu-cpu=power10" } */
>> /* { dg-require-effective-target power10_ok } */
>
> Nit: power10_ok can be dropped.
Yeap, thanks for catch this!
>
>> +/* { dg-require-effective-target has_arch_ppc64 } */
> OK with the nits above tweaked, thanks.
Thanks again.
BR,
Jeff(Jiufu) Guo
>
> BR,
> Kewen
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] missing reuire target has_arch_ppc64 for pr106550.c
2024-05-23 5:14 ` Jiufu Guo
@ 2024-05-24 1:25 ` Jiufu Guo
0 siblings, 0 replies; 4+ messages in thread
From: Jiufu Guo @ 2024-05-24 1:25 UTC (permalink / raw)
To: Kewen.Lin; +Cc: segher, dje.gcc, linkw, bergner, gcc-patches
Hi,
>>> ---
>>> gcc/testsuite/gcc.target/powerpc/pr106550.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/gcc/testsuite/gcc.target/powerpc/pr106550.c b/gcc/testsuite/gcc.target/powerpc/pr106550.c
>>> index 74e395331ab..146514b3adf 100644
>>> --- a/gcc/testsuite/gcc.target/powerpc/pr106550.c
>>> +++ b/gcc/testsuite/gcc.target/powerpc/pr106550.c
>>> @@ -1,6 +1,7 @@
>>> /* PR target/106550 */
>>> /* { dg-options "-O2 -mdejagnu-cpu=power10" } */
>>> /* { dg-require-effective-target power10_ok } */
>>
>> Nit: power10_ok can be dropped.
> Yeap, thanks for catch this!
>
>>
>>> +/* { dg-require-effective-target has_arch_ppc64 } */
>> OK with the nits above tweaked, thanks.
Thanks, pushed as r15-790.
BR,
Jeff(Jiufu) Guo
>
> Thanks again.
>
> BR,
> Jeff(Jiufu) Guo
>
>>
>> BR,
>> Kewen
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-24 1:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-23 1:11 [PATCH] missing reuire target has_arch_ppc64 for pr106550.c Jiufu Guo
2024-05-23 3:28 ` Kewen.Lin
2024-05-23 5:14 ` Jiufu Guo
2024-05-24 1:25 ` Jiufu Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).