From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id BC46D3858D20; Wed, 17 Apr 2024 01:52:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BC46D3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BC46D3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713318740; cv=none; b=g2VDxpRdkDUHDuccxJJ+3MutQ19xcU4JQkkyjkS4IQfbnR0mN5h8+vqGWaYwNwVGfLB8ULdHnI1d9reuall0xo7pvnFCxlBTKOFa409voLVqGdN9SksDs8X29bO4XZaW6jeKkiIzGKmW0UvZEqk+Oqdz1aCFJ0NSynIZIPk/PFU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713318740; c=relaxed/simple; bh=VMIqDQUTz0PaJsY+8F4Z4IDUZzKRvY/oO5vKwaGuKaY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ca3eXLu+D/1rcY2zzBdLEY+x7/A38RF3Fp+r8O3UhlCj803Qsgt8ObFFzuPiVt8znuSlr27WKS++0dl6ub0NHaSIW8+bGIjzETuYkMz6IKZXjermnulcMO/Va7hHscgJrVU9bmseSYw8pj9GzXtquZP57PCHc1H8KzGhb4C1lrI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43H1qGo5006063; Wed, 17 Apr 2024 01:52:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : mime-version : content-type; s=pp1; bh=4/8FUhGUYdkF+wHPxvHUhDJpKzkHDYzNWDG+YoUM77A=; b=TIhU/yaOMEpg1ef1P2fYaznk3ugKXYSqM0JNUWIUiSfdmYLYqeQ2sgGpnJ5suShzhtxL +bf9FdlmW0akaRh6y1d17GK8JEJixcWKEHYzJppTII5ubyUkuWfcX7nC0gCiBvBDX9GT zycwNIIYoJZTf/LmJci0AMPUg6CSZVFKyeRAZxKy/IjpAd7GMR+LKxLSxHJ/0jdAkeym Bc/ebgd0VQXetprV6HMZOzaEifi8GutEu7xkKm22CGMR4Iwy20kYX/1l712m7h+wJ+2/ sxcDaLa50m5IvQoiKup3TV0qpOon0Y4LSiQDOJdlVKOc/Y8CBziUmVJNJ2okPnwFUtYD Hw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xj54x8008-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Apr 2024 01:52:16 +0000 Received: from m0353726.ppops.net (m0353726.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 43H1qFsT006047; Wed, 17 Apr 2024 01:52:15 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xj54x8006-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Apr 2024 01:52:15 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 43H1AhRQ027323; Wed, 17 Apr 2024 01:52:14 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([172.16.1.9]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3xg4s01s51-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Apr 2024 01:52:14 +0000 Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 43H1q9RO49873586 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Apr 2024 01:52:11 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8A90858045; Wed, 17 Apr 2024 01:52:09 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 04BDC58062; Wed, 17 Apr 2024 01:52:09 +0000 (GMT) Received: from genoa (unknown [9.40.192.157]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTPS; Wed, 17 Apr 2024 01:52:08 +0000 (GMT) From: Jiufu Guo To: gcc-patches@gcc.gnu.org Cc: segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org, bergner@linux.ibm.com, uweigand@de.ibm.com, krebbel@linux.ibm.com Subject: Re: [PATCH] s390: avoid peeking eof after __vector References: <20240327063614.2444325-1-guojiufu@linux.ibm.com> Date: Wed, 17 Apr 2024 09:52:04 +0800 In-Reply-To: <20240327063614.2444325-1-guojiufu@linux.ibm.com> (Jiufu Guo's message of "Wed, 27 Mar 2024 14:36:14 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-GUID: HbhoAOkF3Pv_alOqjLxqI6DicMulBbu_ X-Proofpoint-ORIG-GUID: fb-kwAySkA9KQAfakR6MRS4c-9ldC8YP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-17_01,2024-04-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 clxscore=1011 spamscore=0 phishscore=0 bulkscore=0 malwarescore=0 adultscore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404170012 X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, I would like to ping this patch. Jeff (Jiufu Guo) Jiufu Guo writes: > Hi, > > Same like PR101168, this patch is need for s390 to > avoid peeking eof after vector keyword. > And similar test case is also ok for s390. > > Is this ok for trunk? > > Jeff (Jiufu Guo) > > PR target/95782 > > gcc/ChangeLog: > > * config/s390/s390-c.cc (s390_macro_to_expand): Avoid empty identifier. > > gcc/testsuite/ChangeLog: > > * g++.target/s390/pr95782.C: New test. > > --- > gcc/config/s390/s390-c.cc | 4 +++- > gcc/testsuite/g++.target/s390/pr95782.C | 5 +++++ > 2 files changed, 8 insertions(+), 1 deletion(-) > create mode 100644 gcc/testsuite/g++.target/s390/pr95782.C > > diff --git a/gcc/config/s390/s390-c.cc b/gcc/config/s390/s390-c.cc > index 8d3d1a467a8..45f164d978b 100644 > --- a/gcc/config/s390/s390-c.cc > +++ b/gcc/config/s390/s390-c.cc > @@ -275,7 +275,9 @@ s390_macro_to_expand (cpp_reader *pfile, const cpp_token *tok) > /* __vector long __bool a; */ > if (ident == C_CPP_HASHNODE (__bool_keyword)) > expand_bool_p = true; > - else > + > + /* If there are more tokens to check. */ > + else if (ident) > { > /* Triggered with: __vector long long __bool a; */ > do > diff --git a/gcc/testsuite/g++.target/s390/pr95782.C b/gcc/testsuite/g++.target/s390/pr95782.C > new file mode 100644 > index 00000000000..daf887fc6fe > --- /dev/null > +++ b/gcc/testsuite/g++.target/s390/pr95782.C > @@ -0,0 +1,5 @@ > +// { dg-do compile } > +// { dg-options "-march=z14 -mzvector" } > + > +using vdbl = __vector double; > +#define BREAK 1