From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 2B3283858D33 for ; Fri, 24 May 2024 01:22:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2B3283858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2B3283858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716513759; cv=none; b=k8USiT0vQSBYdNjwt7+C+PsPsdHDc0gIXB0qgTiriWuJ0S96rqCD8Wv4LUutBtTAsGdnM9bk6aEGkxgy16NjLb5VFOVr3nsDOoSi5uJE2yAp0jVILblaVt/kgG3BFInF8IlB0pgimwPdBwh2qtESKCYBotnT4sFCx4XXOqQyB/s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716513759; c=relaxed/simple; bh=HdQWihB79VsZYaoMO8i1T+fcglmJS/gkzPVVJgi5dGU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=CP2O9IoAr63COuyW0c1zwoB2XqeDGb1+1nQFyDDTw946WAc+JJK7Tn9UvAt0Z6zPZns53V6DlpyYgGt+cwMZhkkLVCviZP6pG9fZjRYgc3qo/ponW3t79y3IcW8yiXEzqjl8o2uVL5NcC+qSMGZi3Q4ifQhLNqbwzky6NWpASdI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 44O1MYsJ013566; Fri, 24 May 2024 01:22:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : mime-version : content-type; s=pp1; bh=J0XeaAmPEBaoi1bOogZd58qgGW+ep3R5hOOpSgM6CVs=; b=sveqPLoRjNRTVyM5SIq6eNCAZtMXoDZaXGePbTgrNx41sZp1xa2H17w5IXn09OPBJXu+ MeFurhhcyUkZ+3yJ/LEO63XVrp5d3Dqick+b6sE+sq/QvTOnpzZSNfAydCj+HGc2tSut i6ygeRTUD+mMFGfiFsMwTaEgdOKd/0+9SQX/1ZMoytOLBlpPNqWR5T/HZcU75x2+zOr6 qYKd4IkS/uLtbwMqRAmk29cWfk7EYia5mr2VBhCkv9fRHy6TcRQraYSvJwLu9S15cJDS TVhjbTELGov+Q8Of4Ffh1G8aTAhNjfBiiNiBBMo4St5ZzATKNF629hfS0j5Te7/kkHhC Kg== Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yah5wr01y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 May 2024 01:22:34 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 44NN4KEc022144; Fri, 24 May 2024 01:22:33 GMT Received: from smtprelay02.dal12v.mail.ibm.com ([172.16.1.4]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3y76nu5t8y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 May 2024 01:22:33 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay02.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 44O1MVpA27984438 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 May 2024 01:22:33 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1934F5805A; Fri, 24 May 2024 01:22:31 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 05CC858056; Fri, 24 May 2024 01:22:31 +0000 (GMT) Received: from genoa (unknown [9.40.192.157]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTPS; Fri, 24 May 2024 01:22:30 +0000 (GMT) From: Jiufu Guo To: Hans-Peter Nilsson Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH V3] report message for operator %a on unaddressible operand References: <20240520052224.2583967-1-guojiufu@linux.ibm.com> Date: Fri, 24 May 2024 09:22:28 +0800 In-Reply-To: (Hans-Peter Nilsson's message of "Thu, 23 May 2024 20:10:20 -0400 (EDT)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-GUID: la2oLK1L89CxYPK9T7UoVQM8tyvcVRNY X-Proofpoint-ORIG-GUID: la2oLK1L89CxYPK9T7UoVQM8tyvcVRNY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16 definitions=2024-05-23_14,2024-05-23_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 spamscore=0 mlxscore=0 impostorscore=0 mlxlogscore=942 adultscore=0 priorityscore=1501 clxscore=1011 phishscore=0 suspectscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2405240008 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Hans-Peter Nilsson writes: > On Mon, 20 May 2024, Jiufu Guo wrote: > >> Hi, >> >> For PR96866, when printing asm code for modifier "%a", an addressable >> operand is required. While the constraint "X" allow any kind of >> operand even which is hard to get the address directly. e.g. extern >> symbol whose address is in TOC. >> An error message would be reported to indicate the invalid asm operand. >> >> Compare with previous version, code comments and message are updated. >> >> Bootstrap®test pass on ppc64{,le}. >> Is this ok for trunk? >> >> BR, >> Jeff(Jiufu Guo) >> >> PR target/96866 >> >> gcc/ChangeLog: >> >> * config/rs6000/rs6000.cc (print_operand_address): >> >> gcc/testsuite/ChangeLog: >> >> * gcc.target/powerpc/pr96866-1.c: New test. >> * gcc.target/powerpc/pr96866-2.c: New test. > > The gcc/ChangeLog entry needs some text after that ":". Oh, Sorry for missing that. Thanks for pointing out this. BR. Jeff(Jiufu) Guo. > > brgds, H-P