From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id E84E6385735F; Tue, 10 May 2022 06:26:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E84E6385735F Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24A6LnQN010116; Tue, 10 May 2022 06:26:53 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3fyjqeg1n4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 May 2022 06:26:53 +0000 Received: from m0098393.ppops.net (m0098393.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 24A6O9cW014703; Tue, 10 May 2022 06:26:53 GMT Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3fyjqeg1mx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 May 2022 06:26:53 +0000 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 24A67cvI010087; Tue, 10 May 2022 06:26:52 GMT Received: from b01cxnp23032.gho.pok.ibm.com (b01cxnp23032.gho.pok.ibm.com [9.57.198.27]) by ppma04dal.us.ibm.com with ESMTP id 3fwgd9ywbs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 May 2022 06:26:52 +0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 24A6QppY19792178 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 May 2022 06:26:51 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 382D611206D; Tue, 10 May 2022 06:26:51 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DD2A7112062; Tue, 10 May 2022 06:26:50 +0000 (GMT) Received: from genoa (unknown [9.40.192.157]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTPS; Tue, 10 May 2022 06:26:50 +0000 (GMT) From: Jiufu Guo To: Segher Boessenkool Cc: gcc-patches@gcc.gnu.org, dje.gcc@gmail.com, linkw@gcc.gnu.org Subject: Re: [PATCH] rs6000: avoid peeking eof after __vector References: <20220509101945.3132344-1-guojiufu@linux.ibm.com> <20220509140122.GM25951@gate.crashing.org> Date: Tue, 10 May 2022 14:26:47 +0800 In-Reply-To: <20220509140122.GM25951@gate.crashing.org> (Segher Boessenkool's message of "Mon, 9 May 2022 09:01:22 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-GUID: J_4jwBQprrLtGA9E8NBsZfQ4UnB64yxM X-Proofpoint-ORIG-GUID: m8K5GpOO_N6hIWkXsmgEWHe6PsxAAAcb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-09_06,2022-05-09_02,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=706 lowpriorityscore=0 suspectscore=0 mlxscore=0 phishscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 impostorscore=0 spamscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205100023 X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 May 2022 06:26:56 -0000 Segher Boessenkool writes: > Hi! > > On Mon, May 09, 2022 at 06:19:45PM +0800, Jiufu Guo wrote: >> There is a rare corner case: where vector is followed only by one >> valid identifer and the ";" which is near the end of the file. >> >> Like the case in PR101168: >> using vdbl = __vector double; >> #define BREAK 1 >> >> For this case, "vector double" is followed by CPP_SEMICOLON and then >> EOF. There is no more tokens need to check for this case. > > One tiny comment/hint: > >> --- /dev/null >> +++ b/gcc/testsuite/g++.target/powerpc/pr101168.C >> @@ -0,0 +1,6 @@ >> +/* { dg-do compile } */ > > This is the default, you can leave it out if you want. > > Okay for trunk with or without it. Thanks! Thanks! Committed as r13-220. BR, Jiufu > > > Segher