From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 5BC553858CD1; Mon, 27 Nov 2023 02:49:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5BC553858CD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5BC553858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701053352; cv=none; b=F7NGgDv11yAyM51jmn5+G6TCb2I/U/QaSOtYKBd89y32CRylg3drhiMLSMhb6zRER8tk55t331gVVrCJgUmsQGWtIYa6a5XWTetVsNvsiHgx+sP7ewQiafxWPxMDU7Cz2zPvu5oifM5Jf6U47QSRkWVGsKLjq6YkT9izgn3chu8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701053352; c=relaxed/simple; bh=/Egr+MYekNblVZ4HbotTo1Ai5xs1EcqOW60495IQ4eI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=phPzycqGSK+KKoB4AZ9av3Z+XqqjLIh6fqxLUqQKBxbmXTHlmtnMqu7ob5iXSYRgIeZsw17LL72AqMWQnpyeAwBPEC+q1+UpgaL+xRCM+CmrSTZtLTzWqlmSL7ljKug3Tbe4KgvQUGQEE5KAvrrbNDXVksfUZwRB0pNycBYYlHU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353722.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AR2AViS016919; Mon, 27 Nov 2023 02:49:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : mime-version; s=pp1; bh=PZwNM6/tj/9/ibon2ntuaFvoaufWTRb5FmGMZs9FxD4=; b=iu232JLsq8/sVtwF1qI4GbyKi6qPKmG1d3l54ZQNNF2IZ2UxVcITEHCh91fwVd9K/D6k zmNYiZ96x5/Req86YaL9EzosZGLM4bOb0ZvG4ckcwIF3VDIBCDlI4l2lQy7m80k3o4xf i9tpch4mZY/ZryILlRwS6DewTmo8NklN8fHNv5w5TQTZAJwebCP3giazDQzM/lxDpPu6 fjlGOUq5+DoLQYkvztEYCzIZ9rNrQSwkKbQXA6XC5wPcbPgnCrqBAzSpXHFdYYWmWvt+ OAXcUTmKPBGNA26oTMvVIfLCbD1j1kdKubYbOhLA9eNVkskIMrL+abQYdbuwIUt5swxa AQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3umgdj2fmq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Nov 2023 02:49:09 +0000 Received: from m0353722.ppops.net (m0353722.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3AR2eb82000830; Mon, 27 Nov 2023 02:49:09 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3umgdj2fmf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Nov 2023 02:49:09 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3AR0Xr0s021947; Mon, 27 Nov 2023 02:49:08 GMT Received: from smtprelay01.wdc07v.mail.ibm.com ([172.16.1.68]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3ukumy62h4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Nov 2023 02:49:08 +0000 Received: from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com [10.39.53.233]) by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3AR2n73i18743998 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Nov 2023 02:49:07 GMT Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A8DFC5804E; Mon, 27 Nov 2023 02:49:07 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4E69858055; Mon, 27 Nov 2023 02:49:07 +0000 (GMT) Received: from genoa (unknown [9.40.192.157]) by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTPS; Mon, 27 Nov 2023 02:49:07 +0000 (GMT) From: Jiufu Guo To: "Kewen.Lin" Cc: segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org, bergner@linux.ibm.com, gcc-patches@gcc.gnu.org Subject: Re: [PATCH V2 2/3] Using pli to split 34bits constant References: <20231115030237.1188073-1-guojiufu@linux.ibm.com> <20231115030237.1188073-2-guojiufu@linux.ibm.com> <9771ca52-70db-b675-9de2-3d452234f068@linux.ibm.com> Date: Mon, 27 Nov 2023 10:49:04 +0800 In-Reply-To: <9771ca52-70db-b675-9de2-3d452234f068@linux.ibm.com> (Kewen Lin's message of "Wed, 22 Nov 2023 17:18:46 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 2BtewyBHmwAmPd0Rlik7ar6XTKTmqIC4 X-Proofpoint-GUID: o8mCeRebAn5F_wVEXUiHJPm7dxn-B0qI X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-26_25,2023-11-22_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxlogscore=999 clxscore=1015 impostorscore=0 suspectscore=0 phishscore=0 priorityscore=1501 malwarescore=0 mlxscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311270019 X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, "Kewen.Lin" writes: > Hi, > > on 2023/11/15 11:02, Jiufu Guo wrote: >> Hi, >> >> For constants with 16bit values, 'li or lis' can be used to generate >> the value. For 34bit constant, 'pli' is ok to generate the value. >> For example: 0x6666666666666666ULL, "pli 3,1717986918; rldimi 3,3,32,0" >> can be used. > > Since now if emit_move_insn with a 34bit constant, it's already adopting > pli. So it's not obvious to the readers why we want this change, I think > you should probably state the reason here explicitly, like in function > rs6000_emit_set_long_const it's possible to recursively call itself without > invoking emit_move_insn, then it can result in sub-optimal constant build ... > And for the testing I prefer to have a dedicated test case for it, like > extracting function msk66 from pr93012.c and checking its generated assembly > has pli but not lis and ori on Power10 and up. I would update the message to make it clear. Thanks so much for your suggestions! BR, Jeff (Jiufu Guo) > > The others look good to me. Thanks! > > BR, > Kewen > >> >> Compare with previous: >> https://gcc.gnu.org/pipermail/gcc-patches/2023-October/634196.html >> This verion updates a testcase to cover this functionality. >> >> Bootstrap®test pass on ppc64{,le}. >> Is this ok for trunk? >> >> BR, >> Jeff (Jiufu Guo) >> >> gcc/ChangeLog: >> >> * config/rs6000/rs6000.cc (rs6000_emit_set_long_const): Add code to use >> pli for 34bit constant. >> >> gcc/testsuite/ChangeLog: >> >> * gcc.target/powerpc/pr93012.c: Update to check pli. >> >> --- >> gcc/config/rs6000/rs6000.cc | 9 +++++++++ >> gcc/testsuite/gcc.target/powerpc/pr93012.c | 1 + >> 2 files changed, 10 insertions(+) >> >> diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc >> index ba40dd6eee4..b277c52687b 100644 >> --- a/gcc/config/rs6000/rs6000.cc >> +++ b/gcc/config/rs6000/rs6000.cc >> @@ -10504,6 +10504,15 @@ rs6000_emit_set_long_const (rtx dest, HOST_WIDE_INT c, int *num_insns) >> return; \ >> } >> >> + if (TARGET_PREFIXED && SIGNED_INTEGER_34BIT_P (c)) >> + { >> + /* li/lis/pli */ >> + ADJUST_INSN_NUM_AND_RET (1); >> + >> + emit_move_insn (dest, GEN_INT (c)); >> + return; >> + } >> + >> if ((ud4 == 0xffff && ud3 == 0xffff && ud2 == 0xffff && (ud1 & 0x8000)) >> || (ud4 == 0 && ud3 == 0 && ud2 == 0 && !(ud1 & 0x8000))) >> { >> diff --git a/gcc/testsuite/gcc.target/powerpc/pr93012.c b/gcc/testsuite/gcc.target/powerpc/pr93012.c >> index 4f764d0576f..a07ff764bbf 100644 >> --- a/gcc/testsuite/gcc.target/powerpc/pr93012.c >> +++ b/gcc/testsuite/gcc.target/powerpc/pr93012.c >> @@ -10,4 +10,5 @@ unsigned long long mskh1() { return 0xffff9234ffff9234ULL; } >> unsigned long long mskl1() { return 0x2bcdffff2bcdffffULL; } >> unsigned long long mskse() { return 0xffff1234ffff1234ULL; } >> >> +/* { dg-final { scan-assembler-times {\mpli\M} 4 { target has_arch_pwr10 }} } */ >> /* { dg-final { scan-assembler-times {\mrldimi\M} 7 } } */