From: Jiufu Guo <guojiufu@linux.ibm.com>
To: gcc-patches@gcc.gnu.org
Cc: segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org,
bergner@linux.ibm.com
Subject: Ping [PATCH] rs6000: mark tieable between INT and FLOAT
Date: Mon, 18 Sep 2023 11:48:26 +0800 [thread overview]
Message-ID: <h48zg1k2lbp.fsf@genoa.aus.stglabs.ibm.com> (raw)
In-Reply-To: <20230828030715.2310469-1-guojiufu@linux.ibm.com> (Jiufu Guo's message of "Mon, 28 Aug 2023 11:07:15 +0800")
Hi,
I would like to have a ping.....
BR,
Jeff (Jiufu Guo)
Jiufu Guo <guojiufu@linux.ibm.com> writes:
> Hi,
>
> For PowerPC, some INT mode and FLOAT modes can be marked as tieable,
> for example: DI<->DF.
> One note SFmode is special, it would only tieable with itself.
>
> I updated previous patch more reasonable:
> https://gcc.gnu.org/pipermail/gcc-patches/2023-January/609504.html
>
> Bootstrap and regtest pass on ppc64{,le}.
> Is this ok for trunk?
>
> BR,
> Jeff (Jiufu)
>
> gcc/ChangeLog:
>
> * config/rs6000/rs6000.cc (rs6000_modes_tieable_p): Mark more tieable
> modes.
>
> gcc/testsuite/ChangeLog:
>
> * g++.target/powerpc/pr102024.C: Updated.
>
> ---
> gcc/config/rs6000/rs6000.cc | 9 +++++++++
> gcc/testsuite/g++.target/powerpc/pr102024.C | 3 ++-
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc
> index 6ac3adcec6b..3cb0186089e 100644
> --- a/gcc/config/rs6000/rs6000.cc
> +++ b/gcc/config/rs6000/rs6000.cc
> @@ -1968,6 +1968,15 @@ rs6000_modes_tieable_p (machine_mode mode1, machine_mode mode2)
> if (ALTIVEC_OR_VSX_VECTOR_MODE (mode2))
> return false;
>
> + /* SFmode format (IEEE DP) in register would not as required,
> + So SFmode is restrict here. */
> + if (GET_MODE_CLASS (mode1) == MODE_FLOAT
> + && GET_MODE_CLASS (mode2) == MODE_INT)
> + return GET_MODE_SIZE (mode1) == UNITS_PER_FP_WORD;
> + if (GET_MODE_CLASS (mode1) == MODE_INT
> + && GET_MODE_CLASS (mode2) == MODE_FLOAT)
> + return GET_MODE_SIZE (mode2) == UNITS_PER_FP_WORD;
> +
> if (SCALAR_FLOAT_MODE_P (mode1))
> return SCALAR_FLOAT_MODE_P (mode2);
> if (SCALAR_FLOAT_MODE_P (mode2))
> diff --git a/gcc/testsuite/g++.target/powerpc/pr102024.C b/gcc/testsuite/g++.target/powerpc/pr102024.C
> index 769585052b5..27d2dc5e80b 100644
> --- a/gcc/testsuite/g++.target/powerpc/pr102024.C
> +++ b/gcc/testsuite/g++.target/powerpc/pr102024.C
> @@ -5,7 +5,8 @@
> // Test that a zero-width bit field in an otherwise homogeneous aggregate
> // generates a psabi warning and passes arguments in GPRs.
>
> -// { dg-final { scan-assembler-times {\mstd\M} 4 } }
> +// { dg-final { scan-assembler-times {\mmtvsrd\M} 4 { target has_arch_pwr8 } } }
> +// { dg-final { scan-assembler-times {\mstd\M} 4 { target { ! has_arch_pwr8 } } } }
>
> struct a_thing
> {
next prev parent reply other threads:[~2023-09-18 3:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 3:07 Jiufu Guo
2023-09-18 3:48 ` Jiufu Guo [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-01-06 12:25 Jiufu Guo
2023-02-21 1:32 ` Jiufu Guo
2023-04-26 2:54 ` Jiufu Guo
2023-05-17 6:46 ` ping^^^ " Jiufu Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=h48zg1k2lbp.fsf@genoa.aus.stglabs.ibm.com \
--to=guojiufu@linux.ibm.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linkw@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).