From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10594 invoked by alias); 19 Apr 2004 10:07:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 10583 invoked from network); 19 Apr 2004 10:07:11 -0000 Received: from unknown (HELO Cantor.suse.de) (195.135.220.2) by sources.redhat.com with SMTP; 19 Apr 2004 10:07:11 -0000 Received: from hermes.suse.de (Hermes.suse.de [195.135.221.8]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by Cantor.suse.de (Postfix) with ESMTP id A08644880F8; Mon, 19 Apr 2004 12:07:10 +0200 (CEST) To: "Paolo Bonzini" Cc: gcc-patches@gcc.gnu.org Subject: Re: Patch ping References: From: Andreas Jaeger Date: Mon, 19 Apr 2004 10:07:00 -0000 In-Reply-To: (Paolo Bonzini's message of "Mon, 19 Apr 2004 11:48:00 +0200") Message-ID: User-Agent: Gnus/5.1006 (Gnus v5.10.6) XEmacs/21.4 (Security Through Obscurity, linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-SW-Source: 2004-04/txt/msg01139.txt.bz2 --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 4679 "Paolo Bonzini" writes: >> Paolo, >> >> on which platform did you bootstrap this? > > i686-pc-linux-gnu, all languages except Ada/treelang. > >> It causes build errors on >> both Linux/x86-64 and Linux/ia64 as reported by Andreas Schwab and >> myself on the main GCC list yesterday. >> >> Please fix the regressions that your patch has caused. > > As I wrote on gcc, I don't think I can be blamed on this. The bugs are n= ot > in the code I touched, but only in the code I enabled. All I can do is > disabling -frename-registers on the affected archs, as per the attached > patch disable-ada-rename-regs.patch. The GCC development rules state that you have to fix the code. Even if it's a latent bug that is only introduced by your changes. > Also, I guess would have been found earlier if the Ada testsuite had test= ed > all optimization levels instead of -O2 only (and it used to be -O0, which > seems really strange to me!). Can you please try the attached > ada-testsuite.patch on a two-three days old gcc, on Linux/x86-64 and/or > Linux/ia64? I'll test the complete patch now, Andreas > Ok to commit both patches? > > Paolo > > > > Index: run_acats > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvs/gcc/gcc/gcc/testsuite/ada/acats/run_acats,v > retrieving revision 1.5 > diff -u -r1.5 run_acats > --- run_acats 8 Jan 2004 15:19:36 -0000 1.5 > +++ run_acats 19 Apr 2004 09:34:16 -0000 > @@ -51,4 +51,8 @@ >=20=20 > chmod +x host_gnatmake >=20=20 > -exec $testdir/run_all.sh "$@" > +gccflags=3D-O0 $testdir/run_all.sh "$@" > +gccflags=3D-O1 $testdir/run_all.sh "$@" > +gccflags=3D-O2 $testdir/run_all.sh "$@" > +gccflags=3D-O3 $testdir/run_all.sh "$@" > +gccflags=3D-Os $testdir/run_all.sh "$@" > Index: run_all.sh > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvs/gcc/gcc/gcc/testsuite/ada/acats/run_all.sh,v > retrieving revision 1.15 > diff -u -r1.15 run_all.sh > --- run_all.sh 17 Apr 2004 17:14:18 -0000 1.15 > +++ run_all.sh 19 Apr 2004 09:34:16 -0000 > @@ -9,8 +9,8 @@ > # gccflags=3D"-O3 -fomit-frame-pointer -funroll-all-loops -finline-funct= ions" > # gnatflags=3D"-gnatN" >=20=20 > -gccflags=3D"-O2" > -gnatflags=3D"-gnatws" > +: ${gccflags=3D"-O2"} > +: ${gnatflags=3D"-gnatws"} >=20=20 > target_run () { > $* > @@ -78,6 +78,9 @@ > display `type gnatmake` > gnatls -v >> $dir/acats.log > display "" > +display gcc options are "${gccflags}" > +display gnatmake options are "${gccflags} ${gnatflags}" > +display "" >=20=20 > display " =3D=3D=3D acats support =3D=3D=3D" > display_noeol "Generating support files..." > @@ -152,6 +155,9 @@ > display " done." > display "" > display " =3D=3D=3D acats tests =3D=3D=3D" > +display "" > +display gcc options are "${gccflags}" > +display gnatmake options are "${gccflags} ${gnatflags}" >=20=20 > if [ $# -eq 0 ]; then > chapters=3D`cd $dir/tests; echo [a-z]*` > > Index: i386/t-linux64 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvs/gcc/gcc/gcc/config/i386/t-linux64,v > retrieving revision 1.5 > diff -u -r1.5 t-linux64 > --- i386/t-linux64 28 Nov 2002 14:47:02 -0000 1.5 > +++ i386/t-linux64 19 Apr 2004 09:43:41 -0000 > @@ -18,3 +18,5 @@ > # because then __FRAME_END__ might not be the last thing in .eh_frame > # section. > CRTSTUFF_T_CFLAGS =3D -fno-omit-frame-pointer -fno-asynchronous-unwind-t= ables > + > +T_ADA_CFLAGS =3D -fno-rename-registers > Index: ia64/t-ia64 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvs/gcc/gcc/gcc/config/ia64/t-ia64,v > retrieving revision 1.21 > diff -u -r1.21 t-ia64 > --- ia64/t-ia64 29 Oct 2003 16:21:36 -0000 1.21 > +++ ia64/t-ia64 19 Apr 2004 09:43:41 -0000 > @@ -49,3 +49,5 @@ >=20=20 > # genattrtab generates very long string literals. > insn-attrtab.o-warn =3D -Wno-error > + > +T_ADA_CFLAGS =3D -fno-rename-registers Andreas --=20 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj SUSE Linux AG, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GPG fingerprint =3D 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 --=-=-= Content-Type: application/pgp-signature Content-length: 188 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQBAg6TOOJpWPMJyoSYRAseiAJ97lZCmA6GMfu9+w7upWLM+kPihjACfWctF 4evNpOHHoKLJba8Znukk880= =I77F -----END PGP SIGNATURE----- --=-=-=--