From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-170089-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 22275 invoked by alias); 15 Mar 2006 10:15:44 -0000
Received: (qmail 22259 invoked by uid 22791); 15 Mar 2006 10:15:42 -0000
X-Spam-Check-By: sourceware.org
Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 15 Mar 2006 10:15:33 +0000
Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) 	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) 	(No client certificate requested) 	by mx2.suse.de (Postfix) with ESMTP id 9A7AC1C649; 	Wed, 15 Mar 2006 11:15:29 +0100 (CET)
From: Andreas Schwab <schwab@suse.de>
To: Uttam Pawar <uttamp@us.ibm.com>
Cc: Roger Sayle <roger@eyesopen.com>, gcc-patches@gcc.gnu.org
Subject: Re: Patch ping
References: <Pine.LNX.4.44.0603111322050.3254-100000@www.eyesopen.com> 	<1142278025.18913.259.camel@linux.site>
X-Yow: PIZZA!!
Date: Wed, 15 Mar 2006 10:15:00 -0000
In-Reply-To: <1142278025.18913.259.camel@linux.site> (Uttam Pawar's message of 	"Mon, 13 Mar 2006 11:27:05 -0800")
Message-ID: <jeacbsqair.fsf@sykes.suse.de>
User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/22.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2006-03/txt/msg00919.txt.bz2

Uttam Pawar <uttamp@us.ibm.com> writes:

> *************** identify_predicable_attribute (void)
> *** 501,506 ****
> --- 507,515 ----
>                          value);
>         errors = 1;
>       }
> +
> +   if (p_false)
> +     free (p_false);
>   }

This is broken.  Checked in this patch as obvious fix to the bootstrap
failure.

Andreas.

2006-03-15  Andreas Schwab  <schwab@suse.de>

	* gensupport.c (identify_predicable_attribute): Don't free p_false
	when it is still in use.

Index: gcc/gensupport.c
===================================================================
--- gcc/gensupport.c	(revision 112080)
+++ gcc/gensupport.c	(working copy)
@@ -510,10 +510,9 @@ identify_predicable_attribute (void)
 			 "unknown value `%s' for `predicable' attribute",
 			 value);
       errors = 1;
+      if (p_false)
+	free (p_false);
     }
-
-  if (p_false)
-    free (p_false);
 }
 
 /* Return the number of alternatives in constraint S.  */

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."