From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2953 invoked by alias); 28 Aug 2007 12:54:39 -0000 Received: (qmail 2807 invoked by uid 22791); 28 Aug 2007 12:54:36 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 28 Aug 2007 12:54:31 +0000 Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 03CF82177D; Tue, 28 Aug 2007 14:54:28 +0200 (CEST) From: Andreas Schwab To: Kazu Hirata Cc: gcc-patches@gcc.gnu.org, law@redhat.com, nathan@codesourcery.com, richard@codesourcery.com Subject: Re: [patch] m68k: Don't use a sibcall from an interrupt handler (Take 2) References: <200708251525.l7PFPsCZ030661@sparrowhawk.codesourcery.com> X-Yow: The fact that 47 PEOPLE are yelling and sweat is cascading down my SPINAL COLUMN is fairly enjoyable!! Date: Tue, 28 Aug 2007 13:26:00 -0000 In-Reply-To: <200708251525.l7PFPsCZ030661@sparrowhawk.codesourcery.com> (Kazu Hirata's message of "Sat\, 25 Aug 2007 08\:25\:54 -0700") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-08/txt/msg01946.txt.bz2 Kazu Hirata writes: > Index: gcc/testsuite/gcc.target/m68k/interrupt-1.c > =================================================================== > --- gcc/testsuite/gcc.target/m68k/interrupt-1.c (revision 0) > +++ gcc/testsuite/gcc.target/m68k/interrupt-1.c (revision 0) > @@ -0,0 +1,24 @@ > +/* { dg-do compile } */ > +/* { dg-options "-O2" } */ > +/* { dg-final { scan-assembler "jra\[ \t\]*interrupt_sibcall" } } */ > +/* { dg-final { scan-assembler "jbsr\[ \t\]*interrupt_call" } } */ > +/* { dg-final { scan-assembler "jra\[ \t\]*normal_sibcall" } } */ That needs to handle the possible variants of m68k_symbolic_call and m68k_symbolic_jump, and targets that use a label prefix. Ok with that change. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."