public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* Say ISO C90, not ISO C89
@ 2002-07-21 14:47 Gabriel Dos Reis
  2002-07-22  5:38 ` Geoff Keating
  0 siblings, 1 reply; 4+ messages in thread
From: Gabriel Dos Reis @ 2002-07-21 14:47 UTC (permalink / raw)
  To: gcc-patches


This patchlet changes the spelling 'ISO C89' to 'ISO C90' in
diagnostic messages -- as there is nothing named 'ISO C89'.  

Bootstrapped and tested on an i686-pc-linux-gnu.

-- Gaby

2002-07-21  Gabriel Dos Reis  <gdr@nerim.net>

	* c-decl.c (build_array_declarator): Say 'ISO C90', not 'ISO C89'.
	(grokdeclarator): Likewise.
	* c-format.c (C_STD_NAME): Likewise.
	* c-lex.c (interpret_integer): Likewise.
	* c-typeck.c (build_array_ref): Likewise.
	* cpplex.c (_cpp_lex_direct): Likewise.
	* toplev.c (documented_lang_options): Likewise.

testsuite/
2002-07-21  Gabriel Dos Reis  <gdr@nerim.net>

	* gcc.dg/c90-arraydecl-1.c: Change C89 too C90.

Index: c-decl.c
===================================================================
RCS file: /cvs/gcc/egcs/gcc/c-decl.c,v
retrieving revision 1.338
diff -p -r1.338 c-decl.c
*** c-decl.c	16 Jul 2002 02:16:31 -0000	1.338
--- c-decl.c	21 Jul 2002 21:32:20 -0000
*************** build_array_declarator (expr, quals, sta
*** 3115,3123 ****
    if (pedantic && !flag_isoc99)
      {
        if (static_p || quals != NULL_TREE)
! 	pedwarn ("ISO C89 does not support `static' or type qualifiers in parameter array declarators");
        if (vla_unspec_p)
! 	pedwarn ("ISO C89 does not support `[*]' array declarators");
      }
    if (vla_unspec_p)
      warning ("GCC does not yet properly implement `[*]' array declarators");
--- 3115,3123 ----
    if (pedantic && !flag_isoc99)
      {
        if (static_p || quals != NULL_TREE)
! 	pedwarn ("ISO C90 does not support `static' or type qualifiers in parameter array declarators");
        if (vla_unspec_p)
! 	pedwarn ("ISO C90 does not support `[*]' array declarators");
      }
    if (vla_unspec_p)
      warning ("GCC does not yet properly implement `[*]' array declarators");
*************** grokdeclarator (declarator, declspecs, d
*** 3909,3915 ****
  		    {
  		      if (pedantic && !flag_isoc99 && ! in_system_header
  			  && warn_long_long)
! 			pedwarn ("ISO C89 does not support `long long'");
  		      longlong = 1;
  		    }
  		}
--- 3909,3915 ----
  		    {
  		      if (pedantic && !flag_isoc99 && ! in_system_header
  			  && warn_long_long)
! 			pedwarn ("ISO C90 does not support `long long'");
  		      longlong = 1;
  		    }
  		}
*************** grokdeclarator (declarator, declspecs, d
*** 4110,4116 ****
    if (specbits & 1 << (int) RID_COMPLEX)
      {
        if (pedantic && !flag_isoc99)
! 	pedwarn ("ISO C89 does not support complex types");
        /* If we just have "complex", it is equivalent to
  	 "complex double", but if any modifiers at all are specified it is
  	 the complex form of TYPE.  E.g, "complex short" is
--- 4110,4116 ----
    if (specbits & 1 << (int) RID_COMPLEX)
      {
        if (pedantic && !flag_isoc99)
! 	pedwarn ("ISO C90 does not support complex types");
        /* If we just have "complex", it is equivalent to
  	 "complex double", but if any modifiers at all are specified it is
  	 the complex form of TYPE.  E.g, "complex short" is
*************** grokdeclarator (declarator, declspecs, d
*** 4388,4397 ****
  		  if (!flag_isoc99 && pedantic)
  		    {
  		      if (TREE_CONSTANT (size))
! 			pedwarn ("ISO C89 forbids array `%s' whose size can't be evaluated",
  				 name);
  		      else
! 			pedwarn ("ISO C89 forbids variable-size array `%s'",
  				 name);
  		    }
  		}
--- 4388,4397 ----
  		  if (!flag_isoc99 && pedantic)
  		    {
  		      if (TREE_CONSTANT (size))
! 			pedwarn ("ISO C90 forbids array `%s' whose size can't be evaluated",
  				 name);
  		      else
! 			pedwarn ("ISO C90 forbids variable-size array `%s'",
  				 name);
  		    }
  		}
*************** grokdeclarator (declarator, declspecs, d
*** 4434,4440 ****
  	  else if (decl_context == FIELD)
  	    {
  	      if (pedantic && !flag_isoc99 && !in_system_header)
! 		pedwarn ("ISO C89 does not support flexible array members");
  
  	      /* ISO C99 Flexible array members are effectively identical
  		 to GCC's zero-length array extension.  */
--- 4434,4440 ----
  	  else if (decl_context == FIELD)
  	    {
  	      if (pedantic && !flag_isoc99 && !in_system_header)
! 		pedwarn ("ISO C90 does not support flexible array members");
  
  	      /* ISO C99 Flexible array members are effectively identical
  		 to GCC's zero-length array extension.  */
Index: c-format.c
===================================================================
RCS file: /cvs/gcc/egcs/gcc/c-format.c,v
retrieving revision 1.25
diff -p -r1.25 c-format.c
*** c-format.c	21 Jul 2002 20:39:34 -0000	1.25
--- c-format.c	21 Jul 2002 21:32:20 -0000
*************** enum format_std_version
*** 356,362 ****
  				 ? "ISO C++"			\
  				 : ((FEATURE_VER) == STD_EXT	\
  				    ? "ISO C"			\
! 				    : "ISO C89"))
  /* Adjust a C standard version, which may be STD_C9L, to account for
     -Wno-long-long.  Returns other standard versions unchanged.  */
  #define ADJ_STD(VER)		((int)((VER) == STD_C9L			      \
--- 356,362 ----
  				 ? "ISO C++"			\
  				 : ((FEATURE_VER) == STD_EXT	\
  				    ? "ISO C"			\
! 				    : "ISO C90"))
  /* Adjust a C standard version, which may be STD_C9L, to account for
     -Wno-long-long.  Returns other standard versions unchanged.  */
  #define ADJ_STD(VER)		((int)((VER) == STD_C9L			      \
Index: c-lex.c
===================================================================
RCS file: /cvs/gcc/egcs/gcc/c-lex.c,v
retrieving revision 1.183
diff -p -r1.183 c-lex.c
*** c-lex.c	27 Jun 2002 05:59:49 -0000	1.183
--- c-lex.c	21 Jul 2002 21:32:21 -0000
*************** interpret_integer (token, flags)
*** 853,862 ****
  		  if (itk_u < itk_unsigned_long)
  		    itk_u = itk_unsigned_long;
  		  itk = itk_u;
! 		  warning ("this decimal constant is unsigned only in ISO C89");
  		}
  	      else if (warn_traditional)
! 		warning ("this decimal constant would be unsigned in ISO C89");
  	    }
  	}
      }
--- 853,862 ----
  		  if (itk_u < itk_unsigned_long)
  		    itk_u = itk_unsigned_long;
  		  itk = itk_u;
! 		  warning ("this decimal constant is unsigned only in ISO C90");
  		}
  	      else if (warn_traditional)
! 		warning ("this decimal constant would be unsigned in ISO C90");
  	    }
  	}
      }
Index: c-typeck.c
===================================================================
RCS file: /cvs/gcc/egcs/gcc/c-typeck.c,v
retrieving revision 1.198
diff -p -r1.198 c-typeck.c
*** c-typeck.c	21 Jul 2002 20:10:50 -0000	1.198
--- c-typeck.c	21 Jul 2002 21:32:24 -0000
*************** build_array_ref (array, index)
*** 1362,1368 ****
  	  if (TREE_CODE (foo) == VAR_DECL && DECL_REGISTER (foo))
  	    pedwarn ("ISO C forbids subscripting `register' array");
  	  else if (! flag_isoc99 && ! lvalue_p (foo))
! 	    pedwarn ("ISO C89 forbids subscripting non-lvalue array");
  	}
  
        type = TYPE_MAIN_VARIANT (TREE_TYPE (TREE_TYPE (array)));
--- 1362,1368 ----
  	  if (TREE_CODE (foo) == VAR_DECL && DECL_REGISTER (foo))
  	    pedwarn ("ISO C forbids subscripting `register' array");
  	  else if (! flag_isoc99 && ! lvalue_p (foo))
! 	    pedwarn ("ISO C90 forbids subscripting non-lvalue array");
  	}
  
        type = TYPE_MAIN_VARIANT (TREE_TYPE (TREE_TYPE (array)));
Index: cpplex.c
===================================================================
RCS file: /cvs/gcc/egcs/gcc/cpplex.c,v
retrieving revision 1.211
diff -p -r1.211 cpplex.c
*** cpplex.c	11 Jun 2002 05:36:14 -0000	1.211
--- cpplex.c	21 Jul 2002 21:32:25 -0000
*************** _cpp_lex_direct (pfile)
*** 1100,1106 ****
  	      && ! buffer->warned_cplusplus_comments)
  	    {
  	      cpp_error (pfile, DL_PEDWARN,
! 			 "C++ style comments are not allowed in ISO C89");
  	      cpp_error (pfile, DL_PEDWARN,
  			 "(this will be reported only once per input file)");
  	      buffer->warned_cplusplus_comments = 1;
--- 1100,1106 ----
  	      && ! buffer->warned_cplusplus_comments)
  	    {
  	      cpp_error (pfile, DL_PEDWARN,
! 			 "C++ style comments are not allowed in ISO C90");
  	      cpp_error (pfile, DL_PEDWARN,
  			 "(this will be reported only once per input file)");
  	      buffer->warned_cplusplus_comments = 1;
Index: toplev.c
===================================================================
RCS file: /cvs/gcc/egcs/gcc/toplev.c,v
retrieving revision 1.658
diff -p -r1.658 toplev.c
*** toplev.c	17 Jul 2002 03:03:40 -0000	1.658
--- toplev.c	21 Jul 2002 21:32:28 -0000
*************** documented_lang_options[] =
*** 1196,1202 ****
       enabled by default.  */
  
    { "-ansi",
!     N_("Compile just for ISO C89") },
    { "-std= ",
      N_("Determine language standard") },
  
--- 1196,1202 ----
       enabled by default.  */
  
    { "-ansi",
!     N_("Compile just for ISO C90") },
    { "-std= ",
      N_("Determine language standard") },
  
Index: testsuite/gcc.dg/c90-arraydecl-1.c
===================================================================
RCS file: /cvs/gcc/egcs/gcc/testsuite/gcc.dg/c90-arraydecl-1.c,v
retrieving revision 1.1
diff -p -r1.1 c90-arraydecl-1.c
*** testsuite/gcc.dg/c90-arraydecl-1.c	25 May 2001 11:12:47 -0000	1.1
--- testsuite/gcc.dg/c90-arraydecl-1.c	21 Jul 2002 21:32:36 -0000
***************
*** 8,31 ****
     it correctly, so gives a warning about this. so we can't yet test here
     that we get just one error and no warnings.  */
  
! void foo0 (int a, int b[*]); /* { dg-error "ISO C89" "\[*\] not in C89" } */
  /* { dg-warning "implement" "\[*\] not implemented" { target *-*-* } 11 } */
! void foo1 (int, int [*]); /* { dg-error "ISO C89" "\[*\] not in C89" } */
  /* { dg-warning "implement" "\[*\] not implemented" { target *-*-* } 13 } */
  
  /* Use of static and type qualifiers (not allowed with abstract declarators)
     is a C99 feature.  */
  
  void bar0 (int a[const]); /* { dg-bogus "warning" "warning in place of error" } */
! /* { dg-error "ISO C89" "\[quals\] not in C89" { target *-*-* } 19 } */
  void bar1 (int a[const 2]); /* { dg-bogus "warning" "warning in place of error" } */
! /* { dg-error "ISO C89" "\[quals expr\] not in C89" { target *-*-* } 21 } */
  void bar2 (int a[static 2]); /* { dg-bogus "warning" "warning in place of error" } */
! /* { dg-error "ISO C89" "\[static expr\] not in C89" { target *-*-* } 23 } */
  void bar3 (int a[static const 2]); /* { dg-bogus "warning" "warning in place of error" } */
! /* { dg-error "ISO C89" "\[static quals expr\] not in C89" { target *-*-* } 25 } */
  void bar4 (int a[const static 2]); /* { dg-bogus "warning" "warning in place of error" } */
! /* { dg-error "ISO C89" "\[quals static expr\] not in C89" { target *-*-* } 27 } */
  
  /* Because [*] isn't properly implemented and so warns, we don't test here
     for [const *] yet.  */
--- 8,31 ----
     it correctly, so gives a warning about this. so we can't yet test here
     that we get just one error and no warnings.  */
  
! void foo0 (int a, int b[*]); /* { dg-error "ISO C90" "\[*\] not in C90" } */
  /* { dg-warning "implement" "\[*\] not implemented" { target *-*-* } 11 } */
! void foo1 (int, int [*]); /* { dg-error "ISO C90" "\[*\] not in C90" } */
  /* { dg-warning "implement" "\[*\] not implemented" { target *-*-* } 13 } */
  
  /* Use of static and type qualifiers (not allowed with abstract declarators)
     is a C99 feature.  */
  
  void bar0 (int a[const]); /* { dg-bogus "warning" "warning in place of error" } */
! /* { dg-error "ISO C90" "\[quals\] not in C90" { target *-*-* } 19 } */
  void bar1 (int a[const 2]); /* { dg-bogus "warning" "warning in place of error" } */
! /* { dg-error "ISO C90" "\[quals expr\] not in C90" { target *-*-* } 21 } */
  void bar2 (int a[static 2]); /* { dg-bogus "warning" "warning in place of error" } */
! /* { dg-error "ISO C90" "\[static expr\] not in C90" { target *-*-* } 23 } */
  void bar3 (int a[static const 2]); /* { dg-bogus "warning" "warning in place of error" } */
! /* { dg-error "ISO C90" "\[static quals expr\] not in C90" { target *-*-* } 25 } */
  void bar4 (int a[const static 2]); /* { dg-bogus "warning" "warning in place of error" } */
! /* { dg-error "ISO C90" "\[quals static expr\] not in C90" { target *-*-* } 27 } */
  
  /* Because [*] isn't properly implemented and so warns, we don't test here
     for [const *] yet.  */

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Say ISO C90, not ISO C89
  2002-07-21 14:47 Say ISO C90, not ISO C89 Gabriel Dos Reis
@ 2002-07-22  5:38 ` Geoff Keating
  2002-07-23  9:11   ` Gabriel Dos Reis
  0 siblings, 1 reply; 4+ messages in thread
From: Geoff Keating @ 2002-07-22  5:38 UTC (permalink / raw)
  To: Gabriel Dos Reis; +Cc: gcc-patches

Gabriel Dos Reis <gdr@nerim.net> writes:

> This patchlet changes the spelling 'ISO C89' to 'ISO C90' in
> diagnostic messages -- as there is nothing named 'ISO C89'.  
> 
> Bootstrapped and tested on an i686-pc-linux-gnu.

Please change doc/invoke.texi, which mentions C89 in many places, at
the same time.  If there isn't one already, it might help to add an
index entry that refers to a definition of ISO C90.

> 2002-07-21  Gabriel Dos Reis  <gdr@nerim.net>
> 
> 	* c-decl.c (build_array_declarator): Say 'ISO C90', not 'ISO C89'.
> 	(grokdeclarator): Likewise.
> 	* c-format.c (C_STD_NAME): Likewise.
> 	* c-lex.c (interpret_integer): Likewise.
> 	* c-typeck.c (build_array_ref): Likewise.
> 	* cpplex.c (_cpp_lex_direct): Likewise.
> 	* toplev.c (documented_lang_options): Likewise.
> 
> testsuite/
> 2002-07-21  Gabriel Dos Reis  <gdr@nerim.net>
> 
> 	* gcc.dg/c90-arraydecl-1.c: Change C89 too C90.
-- 
- Geoffrey Keating <geoffk@geoffk.org> <geoffk@redhat.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Say ISO C90, not ISO C89
  2002-07-22  5:38 ` Geoff Keating
@ 2002-07-23  9:11   ` Gabriel Dos Reis
  2002-07-23 12:00     ` Geoff Keating
  0 siblings, 1 reply; 4+ messages in thread
From: Gabriel Dos Reis @ 2002-07-23  9:11 UTC (permalink / raw)
  To: Geoff Keating; +Cc: gcc-patches

Geoff Keating <geoffk@geoffk.org> writes:

| Gabriel Dos Reis <gdr@nerim.net> writes:
| 
| > This patchlet changes the spelling 'ISO C89' to 'ISO C90' in
| > diagnostic messages -- as there is nothing named 'ISO C89'.  
| > 
| > Bootstrapped and tested on an i686-pc-linux-gnu.
| 
| Please change doc/invoke.texi, which mentions C89 in many places, at
| the same time.

Done with the patch below.

|  If there isn't one already, it might help to add an
| index entry that refers to a definition of ISO C90.

There is already an index.

Thanks,

-- Gaby

2002-07-23  Gabriel Dos Reis  <gdr@nerim.net>

	* doc/extend.texi: Say ISO C90, not ISO C89.
	* doc/invoke.texi: Likewise.
	* doc/standards.texi: Likewise.

Index: doc/extend.texi
===================================================================
RCS file: /cvs/gcc/egcs/gcc/doc/extend.texi,v
retrieving revision 1.88
diff -p -r1.88 extend.texi
*** doc/extend.texi	6 Jul 2002 00:16:42 -0000	1.88
--- doc/extend.texi	23 Jul 2002 15:50:22 -0000
*************** struct line *thisline = (struct line *)
*** 1232,1238 ****
  thisline->length = this_length;
  @end example
  
! In ISO C89, you would have to give @code{contents} a length of 1, which
  means either you waste space or complicate the argument to @code{malloc}.
  
  In ISO C99, you would use a @dfn{flexible array member}, which is
--- 1232,1238 ----
  thisline->length = this_length;
  @end example
  
! In ISO C90, you would have to give @code{contents} a length of 1, which
  means either you waste space or complicate the argument to @code{malloc}.
  
  In ISO C99, you would use a @dfn{flexible array member}, which is
*************** mode.
*** 4533,4546 ****
  The ISO C99 functions @code{conj}, @code{conjf}, @code{conjl},
  @code{creal}, @code{crealf}, @code{creall}, @code{cimag}, @code{cimagf},
  @code{cimagl}, @code{llabs} and @code{imaxabs} are handled as built-in
! functions except in strict ISO C89 mode.  There are also built-in
  versions of the ISO C99 functions @code{cosf}, @code{cosl},
  @code{fabsf}, @code{fabsl}, @code{sinf}, @code{sinl}, @code{sqrtf}, and
! @code{sqrtl}, that are recognized in any mode since ISO C89 reserves
  these names for the purpose to which ISO C99 puts them.  All these
  functions have corresponding versions prefixed with @code{__builtin_}.
  
! The ISO C89 functions @code{abs}, @code{cos}, @code{fabs},
  @code{fprintf}, @code{fputs}, @code{labs}, @code{memcmp}, @code{memcpy},
  @code{memset}, @code{printf}, @code{sin}, @code{sqrt}, @code{strcat},
  @code{strchr}, @code{strcmp}, @code{strcpy}, @code{strcspn},
--- 4533,4546 ----
  The ISO C99 functions @code{conj}, @code{conjf}, @code{conjl},
  @code{creal}, @code{crealf}, @code{creall}, @code{cimag}, @code{cimagf},
  @code{cimagl}, @code{llabs} and @code{imaxabs} are handled as built-in
! functions except in strict ISO C90 mode.  There are also built-in
  versions of the ISO C99 functions @code{cosf}, @code{cosl},
  @code{fabsf}, @code{fabsl}, @code{sinf}, @code{sinl}, @code{sqrtf}, and
! @code{sqrtl}, that are recognized in any mode since ISO C90 reserves
  these names for the purpose to which ISO C99 puts them.  All these
  functions have corresponding versions prefixed with @code{__builtin_}.
  
! The ISO C90 functions @code{abs}, @code{cos}, @code{fabs},
  @code{fprintf}, @code{fputs}, @code{labs}, @code{memcmp}, @code{memcpy},
  @code{memset}, @code{printf}, @code{sin}, @code{sqrt}, @code{strcat},
  @code{strchr}, @code{strcmp}, @code{strcpy}, @code{strcspn},
Index: doc/invoke.texi
===================================================================
RCS file: /cvs/gcc/egcs/gcc/doc/invoke.texi,v
retrieving revision 1.158
diff -p -r1.158 invoke.texi
*** doc/invoke.texi	16 Jul 2002 17:46:33 -0000	1.158
--- doc/invoke.texi	23 Jul 2002 15:50:28 -0000
*************** from C, such as C++ and Objective-C) tha
*** 967,977 ****
  @cindex ISO support
  @item -ansi
  @opindex ansi
! In C mode, support all ISO C89 programs.  In C++ mode,
  remove GNU extensions that conflict with ISO C++.
  
  This turns off certain features of GCC that are incompatible with ISO
! C89 (when compiling C code), or of standard C++ (when compiling C++ code),
  such as the @code{asm} and @code{typeof} keywords, and
  predefined macros such as @code{unix} and @code{vax} that identify the
  type of system you are using.  It also enables the undesirable and
--- 967,977 ----
  @cindex ISO support
  @item -ansi
  @opindex ansi
! In C mode, support all ISO C90 programs.  In C++ mode,
  remove GNU extensions that conflict with ISO C++.
  
  This turns off certain features of GCC that are incompatible with ISO
! C90 (when compiling C code), or of standard C++ (when compiling C++ code),
  such as the @code{asm} and @code{typeof} keywords, and
  predefined macros such as @code{unix} and @code{vax} that identify the
  type of system you are using.  It also enables the undesirable and
*************** possible values are
*** 1012,1021 ****
  @table @samp
  @item c89
  @itemx iso9899:1990
! ISO C89 (same as @option{-ansi}).
  
  @item iso9899:199409
! ISO C89 as modified in amendment 1.
  
  @item c99
  @itemx c9x
--- 1012,1021 ----
  @table @samp
  @item c89
  @itemx iso9899:1990
! ISO C90 (same as @option{-ansi}).
  
  @item iso9899:199409
! ISO C90 as modified in amendment 1.
  
  @item c99
  @itemx c9x
*************** ISO C99.  Note that this standard is not
*** 1026,1032 ****
  names @samp{c9x} and @samp{iso9899:199x} are deprecated.
  
  @item gnu89
! Default, ISO C89 plus GNU extensions (including some C99 features).
  
  @item gnu99
  @item gnu9x
--- 1026,1032 ----
  names @samp{c9x} and @samp{iso9899:199x} are deprecated.
  
  @item gnu89
! Default, ISO C90 plus GNU extensions (including some C99 features).
  
  @item gnu99
  @item gnu9x
*************** previous C standards.  For example, you 
*** 1041,1047 ****
  when @option{-std=c99} is not specified.
  
  The @option{-std} options specifying some version of ISO C have the same
! effects as @option{-ansi}, except that features that were not in ISO C89
  but are in the specified version (for example, @samp{//} comments and
  the @code{inline} keyword in ISO C99) are not disabled.
  
--- 1041,1047 ----
  when @option{-std=c99} is not specified.
  
  The @option{-std} options specifying some version of ISO C have the same
! effects as @option{-ansi}, except that features that were not in ISO C90
  but are in the specified version (for example, @samp{//} comments and
  the @code{inline} keyword in ISO C99) are not disabled.
  
*************** attributes (@pxref{Function Attributes})
*** 1837,1843 ****
  not in the C standard) families.
  
  The formats are checked against the format features supported by GNU
! libc version 2.2.  These include all ISO C89 and C99 features, as well
  as features from the Single Unix Specification and some BSD and GNU
  extensions.  Other library implementations may not support all these
  features; GCC does not support warning about features that go beyond a
--- 1837,1843 ----
  not in the C standard) families.
  
  The formats are checked against the format features supported by GNU
! libc version 2.2.  These include all ISO C90 and C99 features, as well
  as features from the Single Unix Specification and some BSD and GNU
  extensions.  Other library implementations may not support all these
  features; GCC does not support warning about features that go beyond a
Index: doc/standards.texi
===================================================================
RCS file: /cvs/gcc/egcs/gcc/doc/standards.texi,v
retrieving revision 1.7
diff -p -r1.7 standards.texi
*** doc/standards.texi	9 Jun 2002 22:40:14 -0000	1.7
--- doc/standards.texi	23 Jul 2002 15:50:28 -0000
***************
*** 14,20 ****
  @cindex X3.159-1989
  @cindex ISO C standard
  @cindex ISO C
- @cindex ISO C89
  @cindex ISO C90
  @cindex ISO/IEC 9899
  @cindex ISO 9899
--- 14,19 ----

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Say ISO C90, not ISO C89
  2002-07-23  9:11   ` Gabriel Dos Reis
@ 2002-07-23 12:00     ` Geoff Keating
  0 siblings, 0 replies; 4+ messages in thread
From: Geoff Keating @ 2002-07-23 12:00 UTC (permalink / raw)
  To: Gabriel Dos Reis; +Cc: gcc-patches

Gabriel Dos Reis <gdr@integrable-solutions.net> writes:

> Geoff Keating <geoffk@geoffk.org> writes:
> 
> | Gabriel Dos Reis <gdr@nerim.net> writes:
> | 
> | > This patchlet changes the spelling 'ISO C89' to 'ISO C90' in
> | > diagnostic messages -- as there is nothing named 'ISO C89'.  
> | > 
> | > Bootstrapped and tested on an i686-pc-linux-gnu.
> | 
> | Please change doc/invoke.texi, which mentions C89 in many places, at
> | the same time.
> 
> Done with the patch below.

Excellent!  Both patches are OK.

-- 
- Geoffrey Keating <geoffk@geoffk.org> <geoffk@redhat.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2002-07-23 18:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-07-21 14:47 Say ISO C90, not ISO C89 Gabriel Dos Reis
2002-07-22  5:38 ` Geoff Keating
2002-07-23  9:11   ` Gabriel Dos Reis
2002-07-23 12:00     ` Geoff Keating

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).