From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25957 invoked by alias); 15 Jan 2013 20:38:33 -0000 Received: (qmail 25945 invoked by uid 22791); 15 Jan 2013 20:38:33 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,TW_ZJ X-Spam-Check-By: sourceware.org Received: from mga14.intel.com (HELO mga14.intel.com) (143.182.124.37) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Jan 2013 20:37:50 +0000 Received: from azsmga002.ch.intel.com ([10.2.17.35]) by azsmga102.ch.intel.com with ESMTP; 15 Jan 2013 12:37:49 -0800 X-ExtLoop1: 1 Received: from tassilo.jf.intel.com ([10.7.201.84]) by AZSMGA002.ch.intel.com with ESMTP; 15 Jan 2013 12:37:49 -0800 Received: by tassilo.jf.intel.com (Postfix, from userid 501) id 4207A241A71; Tue, 15 Jan 2013 12:37:49 -0800 (PST) From: Andi Kleen To: Uros Bizjak Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH, RFA]: Properly mask memory model argument with MEMMODEL_MASK References: Date: Tue, 15 Jan 2013 20:38:00 -0000 In-Reply-To: (Uros Bizjak's message of "Tue, 15 Jan 2013 09:09:32 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg00804.txt.bz2 Uros Bizjak writes: > > 2013-01-15 Uros Bizjak > > * emit-rtl.c (need_atomic_barrier_p): Mask memory model argument > with MEMMODEL_MASK before comparing with MEMMODEL_* memory types. > * optabs.c (maybe_emit_sync_lock_test_and_set): Ditto. > (expand_mem_thread_fence): Ditto. > (expand_mem_signal_fence): Ditto. > (expand_atomic_load): Ditto. > (expand_atomic_store): Ditto. > > Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. > > OK for mainline? Looks good to me (but I cannot approve) -Andi