From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-293613-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 6625 invoked by alias); 4 Jun 2011 11:17:53 -0000
Received: (qmail 6617 invoked by uid 22791); 4 Jun 2011 11:17:53 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE
X-Spam-Check-By: sourceware.org
Received: from mail-out.m-online.net (HELO mail-out.m-online.net) (212.18.0.9)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 04 Jun 2011 11:17:37 +0000
Received: from frontend1.mail.m-online.net (unknown [192.168.8.180])	by mail-out.m-online.net (Postfix) with ESMTP id D442B1C0F587;	Sat,  4 Jun 2011 13:17:33 +0200 (CEST)
Received: from localhost (dynscan1.mnet-online.de [192.168.8.164])	by mail.m-online.net (Postfix) with ESMTP id C2FFB1C00046;	Sat,  4 Jun 2011 13:17:33 +0200 (CEST)
Received: from mail.mnet-online.de ([192.168.8.180])	by localhost (dynscan1.mail.m-online.net [192.168.8.164]) (amavisd-new, port 10024)	with ESMTP id ZNZO8uUgN5fR; Sat,  4 Jun 2011 13:17:33 +0200 (CEST)
Received: from igel.home (ppp-88-217-111-157.dynamic.mnet-online.de [88.217.111.157])	by mail.mnet-online.de (Postfix) with ESMTP;	Sat,  4 Jun 2011 13:17:33 +0200 (CEST)
Received: by igel.home (Postfix, from userid 501)	id 92EB6CA29C; Sat,  4 Jun 2011 13:17:32 +0200 (CEST)
From: Andreas Schwab <schwab@linux-m68k.org>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: Paolo Bonzini <bonzini@gnu.org>,  gcc-patches@gcc.gnu.org,  "Joseph S. Myers" <joseph@codesourcery.com>,  Ralf Wildenhues <Ralf.Wildenhues@gmx.de>,  Mike Stump <mikestump@comcast.net>,  "Loren J. Rittle" <ljrittle@acm.org>,  Kai Tietz <ktietz@redhat.com>,  Dave Korn <dave.korn.cygwin@gmail.com>,  Jason Thorpe <thorpej@netbsd.org>,  Krister Walfridsson <krister.walfridsson@gmail.com>,  Uros Bizjak <ubizjak@gmail.com>,  Richard Henderson <rth@redhat.com>,  Eric Botcazou <ebotcazou@adacore.com>
Subject: Re: [build] Move ENABLE_EXECUTE_STACK to toplevel libgcc
References: <yddipssrxgx.fsf@manam.CeBiTec.Uni-Bielefeld.DE>	<4DE4AEC2.3030502@gnu.org>	<yddwrh6rifi.fsf@manam.CeBiTec.Uni-Bielefeld.DE>	<4DE50FFB.90501@gnu.org>	<yddvcwmrkaj.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
X-Yow: Oh, I get it!!  ``The BEACH goes on,'' huh, SONNY??
Date: Sat, 04 Jun 2011 11:17:00 -0000
In-Reply-To: <yddvcwmrkaj.fsf@manam.CeBiTec.Uni-Bielefeld.DE> (Rainer Orth's	message of "Fri, 03 Jun 2011 17:45:08 +0200")
Message-ID: <m28vth9777.fsf@igel.home>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2011-06/txt/msg00298.txt.bz2

Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:

> * FreeBSD uses the unmodified address passed to __enable_execute_stack
>   to call mprocted, while all others round both address and size to a
>   pagesize boundary.  I cannot imagine that FreeBSD supports
>   byte-granularity mprotect, so this seems an oversight.

Apparently freebsd's mprotect aligns the address by itself, so it will
not make any difference.  At least linux's mprotect will barf if the
address is unaligned.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."