From: Andreas Schwab <schwab@linux-m68k.org>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
Paolo Bonzini <bonzini@gnu.org>, DJ Delorie <dj@redhat.com>,
neroden@gcc.gnu.org, Alexandre Oliva <aoliva@redhat.com>,
Ralf Wildenhues <Ralf.Wildenhues@gmx.de>,
gcc-patches@gcc.gnu.org
Subject: Re: Use libstdc++-raw-cxx.m4 in libjava
Date: Fri, 04 Jan 2013 10:06:00 -0000 [thread overview]
Message-ID: <m2hamxntyh.fsf@igel.home> (raw)
In-Reply-To: <CAMe9rOoLybL1L=ad=Jdxxx0KLK-Abb9THU3VZuZ3QvFrz5mkiw@mail.gmail.com> (H. J. Lu's message of "Thu, 3 Jan 2013 10:46:56 -0800")
"H.J. Lu" <hjl.tools@gmail.com> writes:
> On Thu, Jan 3, 2013 at 10:09 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>> "H.J. Lu" <hjl.tools@gmail.com> writes:
>>
>>> diff --git a/libjava/Makefile.am b/libjava/Makefile.am
>>> index c6c84e4..dd08a4f 100644
>>> --- a/libjava/Makefile.am
>>> +++ b/libjava/Makefile.am
>>> @@ -594,7 +594,7 @@ lib_gnu_awt_xlib_la_CPPFLAGS = \
>>> $(AM_CPPFLAGS) \
>>> $(LIBSTDCXX_RAW_CXX_CXXFLAGS)
>>> ## The mysterious backslash in the grep pattern is consumed by make.
>>> -lib_gnu_awt_xlib_la_LDFLAGS = $(LIBSTDCXX_RAW_CXX_LDLAGS) \
>>> +lib_gnu_awt_xlib_la_LDFLAGS = $(LIBSTDCXX_RAW_CXX_LIBADD) \
>>> @X_PRE_LIBS@ @X_LIBS@ -lX11 @X_EXTRA_LIBS@ \
>>> -rpath $(toolexeclibdir) $(LIBJAVA_LDFLAGS_NOUNDEF) \
>>> -version-info `grep -v '^\#' $(srcdir)/libtool-version`
>>> $(LIBGCJ_LD_SYMBOLIC)
>>
>> It is still wrong to use LDFLAGS for libraries to be linked in.
>> All of $(LIBSTDCXX_RAW_CXX_LIBADD) @X_PRE_LIBS@ @X_LIBS@ -lX11
>> @X_EXTRA_LIBS@ should be on lib_gnu_awt_xlib_la_LDADD.
>>
>
> This was how it was done before my change. If we want to
> make a change, I can submit a separate patch.
Libraries should never occur before the objects which reference them.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2013-01-04 10:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 22:00 H.J. Lu
2012-12-12 8:50 ` Paolo Bonzini
2013-01-02 11:11 ` Jakub Jelinek
2013-01-02 11:27 ` Andreas Schwab
2013-01-03 17:18 ` H.J. Lu
2013-01-03 18:09 ` Andreas Schwab
2013-01-03 18:47 ` H.J. Lu
2013-01-04 10:06 ` Andreas Schwab [this message]
2013-01-04 14:56 ` H.J. Lu
2013-01-07 17:49 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2hamxntyh.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=Ralf.Wildenhues@gmx.de \
--cc=aoliva@redhat.com \
--cc=bonzini@gnu.org \
--cc=dj@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=jakub@redhat.com \
--cc=neroden@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).