From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16517 invoked by alias); 4 Jan 2013 10:06:26 -0000 Received: (qmail 16501 invoked by uid 22791); 4 Jan 2013 10:06:25 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,TW_IB X-Spam-Check-By: sourceware.org Received: from mail-out.m-online.net (HELO mail-out.m-online.net) (212.18.0.10) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Jan 2013 10:06:18 +0000 Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3Yd1qD2QQSz3hjZ6; Fri, 4 Jan 2013 11:06:16 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3Yd1qC6pnZzbbhq; Fri, 4 Jan 2013 11:06:15 +0100 (CET) Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id kv0w2jMwwIi7; Fri, 4 Jan 2013 11:05:57 +0100 (CET) X-Auth-Info: MeufRxCmT0Ev19ze7HtM0Ih8a/WO+0rTBFzo3RRGTTA= Received: from igel.home (ppp-88-217-116-23.dynamic.mnet-online.de [88.217.116.23]) by mail.mnet-online.de (Postfix) with ESMTPA; Fri, 4 Jan 2013 11:06:14 +0100 (CET) Received: by igel.home (Postfix, from userid 501) id 32434CA2A2; Fri, 4 Jan 2013 11:06:14 +0100 (CET) From: Andreas Schwab To: "H.J. Lu" Cc: Jakub Jelinek , Paolo Bonzini , DJ Delorie , neroden@gcc.gnu.org, Alexandre Oliva , Ralf Wildenhues , gcc-patches@gcc.gnu.org Subject: Re: Use libstdc++-raw-cxx.m4 in libjava References: <20130102111116.GP2315@tucnak.redhat.com> X-Yow: Inside, I'm already SOBBING! Date: Fri, 04 Jan 2013 10:06:00 -0000 In-Reply-To: (H. J. Lu's message of "Thu, 3 Jan 2013 10:46:56 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg00166.txt.bz2 "H.J. Lu" writes: > On Thu, Jan 3, 2013 at 10:09 AM, Andreas Schwab wrote: >> "H.J. Lu" writes: >> >>> diff --git a/libjava/Makefile.am b/libjava/Makefile.am >>> index c6c84e4..dd08a4f 100644 >>> --- a/libjava/Makefile.am >>> +++ b/libjava/Makefile.am >>> @@ -594,7 +594,7 @@ lib_gnu_awt_xlib_la_CPPFLAGS = \ >>> $(AM_CPPFLAGS) \ >>> $(LIBSTDCXX_RAW_CXX_CXXFLAGS) >>> ## The mysterious backslash in the grep pattern is consumed by make. >>> -lib_gnu_awt_xlib_la_LDFLAGS = $(LIBSTDCXX_RAW_CXX_LDLAGS) \ >>> +lib_gnu_awt_xlib_la_LDFLAGS = $(LIBSTDCXX_RAW_CXX_LIBADD) \ >>> @X_PRE_LIBS@ @X_LIBS@ -lX11 @X_EXTRA_LIBS@ \ >>> -rpath $(toolexeclibdir) $(LIBJAVA_LDFLAGS_NOUNDEF) \ >>> -version-info `grep -v '^\#' $(srcdir)/libtool-version` >>> $(LIBGCJ_LD_SYMBOLIC) >> >> It is still wrong to use LDFLAGS for libraries to be linked in. >> All of $(LIBSTDCXX_RAW_CXX_LIBADD) @X_PRE_LIBS@ @X_LIBS@ -lX11 >> @X_EXTRA_LIBS@ should be on lib_gnu_awt_xlib_la_LDADD. >> > > This was how it was done before my change. If we want to > make a change, I can submit a separate patch. Libraries should never occur before the objects which reference them. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."