public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ian Lance Taylor <ian@airs.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Martin Jambor <mjambor@suse.cz>,
	GCC Patches <gcc-patches@gcc.gnu.org>,
	 David Edelsohn <dje.gcc@gmail.com>, Jeff Law <law@redhat.com>
Subject: Re: [hsa merge 08/10] HSAIL BRIG description header file
Date: Fri, 15 Jan 2016 01:19:00 -0000	[thread overview]
Message-ID: <m31t9jtzb3.fsf@pepe.airs.com> (raw)
In-Reply-To: <20160114130447.GF3017@tucnak.redhat.com> (Jakub Jelinek's	message of "Thu, 14 Jan 2016 14:04:47 +0100")

Jakub Jelinek <jakub@redhat.com> writes:

> On Wed, Jan 13, 2016 at 06:39:33PM +0100, Martin Jambor wrote:
>> the following patch adds a BRIG (binary representation of HSAIL)
>> representation description.  It is within a single header file
>> describing the binary structures and constants of the format.
>> 
>> The file comes from the HSA Foundation (I have only added the
>> HSA_BRIG_FORMAT_H macro and check and removed some weird comments
>> which are not present in proposed future versions of the file) and is
>> licensed under "University of Illinois/NCSA Open Source License."
>> 
>> The license is "GPL-compatible" according to FSF
>> (http://www.gnu.org/licenses/license-list.en.html#GPLCompatibleLicenses)
>> so I believe we can have it in GCC.  Nevertheless, it is not GPL and
>> there is no copyright assignment for it, but the situation is
>> hopefully analogous to some other libraries that have their upstream
>> elsewhere but we ship them as part of the GCC.
>> 
>> In the previous posting of this patch
>> (https://gcc.gnu.org/ml/gcc-patches/2015-12/msg00721.html) I have
>> requested a permission from the steering committee to include this file
>> with a different upstream in GCC.  I have not received an official
>> reply but since I have been chosen to be the HSA maintainer, I tend to
>> think there were no legal objections against HSA going forward,
>> including this file.

Martin, could you ask the HSA Foundation or AMD or whoever if there is
any way they could remove the second requirement of the license?  It
adds yet another case where anybody distributing GCC has to list yet
another copyright notice.

Barring that, I would personally prefer that you write your own version
of this header file, defining the constants and structs that you need.
That's basically what we've done for ELF and COFF and Mach-O, several
times over.  For example, libiberty/simple-object-elf.c.

Barring that, I agree with Jakub that this looks like something that
should go in the top-level include subdirectory rather than the gcc
subdirectory.

Ian

  reply	other threads:[~2016-01-15  1:19 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-13 17:55 [hsa merge 00/10] Merge of HSA branch Martin Jambor
2016-01-13 17:55 ` [hsa merge 02/10] Modifications to libgomp proper Martin Jambor
2016-01-20 13:37   ` Ilya Verbin
2016-01-20 14:48   ` Ilya Verbin
2016-01-20 14:55     ` Jakub Jelinek
2016-01-13 17:55 ` [hsa merge 07/10] IPA-HSA pass Martin Jambor
2016-01-14 12:59   ` Jakub Jelinek
2016-01-15 11:48     ` Martin Liška
2016-01-15 14:53     ` Martin Jambor
2016-01-15 15:01       ` Jakub Jelinek
2016-01-15 16:02         ` Martin Jambor
2016-01-15 16:10           ` Jakub Jelinek
2016-01-15 16:38             ` Ilya Verbin
2016-01-15 16:45               ` Jakub Jelinek
2016-01-15 18:06                 ` Ilya Verbin
2016-01-20 18:54                   ` Ilya Verbin
2016-01-21 11:39                     ` Alexander Monakov
2016-01-22 10:19                     ` Jakub Jelinek
2016-01-28 11:36                       ` Partial Offloading (was: [hsa merge 07/10] IPA-HSA pass) Thomas Schwinge
2016-02-17 16:41                         ` Ilya Verbin
2016-01-15 19:19                 ` [hsa merge 07/10] IPA-HSA pass Alexander Monakov
2016-01-15 19:32                   ` Jakub Jelinek
2016-01-15 19:46                     ` Alexander Monakov
2016-01-15 19:55                       ` Jakub Jelinek
2016-01-15  9:52   ` Jan Hubicka
2016-01-15 11:47     ` Martin Liška
2016-01-16 10:00       ` Jan Hubicka
2016-01-25 15:22         ` Martin Liška
2016-01-25 15:24           ` Jakub Jelinek
2016-01-25 23:41             ` Jan Hubicka
2016-01-27 12:38               ` Martin Liška
2016-01-13 17:55 ` [hsa merge 04/10] Avoid extraneous remapping in copy_gimple_seq_and_replace_locals Martin Jambor
2016-01-13 18:02   ` Jakub Jelinek
2016-01-13 17:55 ` [hsa merge 10/10] HSA register allocator Martin Jambor
2016-01-14 14:41   ` Jakub Jelinek
2016-01-15 15:09     ` Martin Jambor
2016-01-13 17:55 ` [hsa merge 01/10] Configury changes and new options Martin Jambor
2016-01-14 12:35   ` Jakub Jelinek
2016-02-02 12:53   ` Thomas Schwinge
2016-01-13 17:55 ` [hsa merge 06/10] Pass manager changes Martin Jambor
2016-01-14 12:52   ` Jakub Jelinek
2016-01-13 17:55 ` [hsa merge 03/10] HSA libgomp plugin Martin Jambor
2016-01-14 12:37   ` Jakub Jelinek
2016-01-13 18:11 ` [hsa merge 09/10] Majority of the HSA back-end Martin Jambor
2016-01-14 14:05   ` Jakub Jelinek
2016-01-15 15:08     ` Martin Jambor
2016-01-15 15:18       ` Jakub Jelinek
2016-01-15 23:49   ` Martin Jambor
2016-01-16  8:58     ` Jakub Jelinek
2016-01-16  9:23       ` Jakub Jelinek
2016-01-18 15:33       ` Martin Jambor
2016-01-18 15:48         ` Jakub Jelinek
2016-01-13 18:12 ` [hsa merge 08/10] HSAIL BRIG description header file Martin Jambor
2016-01-14 13:04   ` Jakub Jelinek
2016-01-15  1:19     ` Ian Lance Taylor [this message]
2016-01-15 10:03       ` Richard Biener
2016-01-15 10:14       ` Martin Jambor
2016-01-15 10:17         ` Richard Biener
2016-01-15 10:37         ` Jakub Jelinek
2016-01-15 12:03           ` Jakub Jelinek
2016-01-15 17:23             ` Martin Jambor
2016-01-16 11:43               ` Jakub Jelinek
2016-01-18 15:22                 ` Martin Jambor
2016-01-15 17:53           ` Mike Stump
2016-01-15 20:23             ` Richard Biener
2016-02-26 18:58       ` Martin Jambor
2016-02-26 19:28         ` Mike Stump
2016-01-13 18:17 ` [hsa merge 05/10] OpenMP lowering/expansion changes (gridification) Martin Jambor
2016-01-14 12:52   ` Jakub Jelinek
2016-01-15 14:52     ` Martin Jambor
2016-01-14 14:22   ` Alexander Monakov
2016-01-19 10:45 ` [hsa merge 00/10] Merge of HSA branch Martin Jambor
2016-01-19 14:25   ` Richard Biener
2016-01-21 23:10     ` Gerald Pfeifer
2016-01-27 14:20       ` Martin Jambor
2016-01-28 15:18         ` Gerald Pfeifer
2016-02-02 14:20           ` Martin Jambor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m31t9jtzb3.fsf@pepe.airs.com \
    --to=ian@airs.com \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=law@redhat.com \
    --cc=mjambor@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).